Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

test: seed the permission data the enterprise policy reads (#21780)

Zhichang Yudbb36d674386
diff --git a/internal/handler/providers_test.go b/internal/handler/providers_test.go
index a51ae6c309..5ff3fc645f 100644
--- a/internal/handler/providers_test.go
+++ b/internal/handler/providers_test.go
@@ -56,6 +56,7 @@ func setupProviderHandlerTestDB(t *testing.T) *gorm.DB {
t.Fatalf("failed to open sqlite: %v", err)
}
if err := db.AutoMigrate(
+ &entity.User{},
&entity.UserTenant{},
&entity.TenantModelProvider{},
&entity.TenantModelInstance{},
@@ -77,6 +78,8 @@ func seedProviderHandlerModel(t *testing.T, db *gorm.DB) {
t.Helper()
activeStatus := "1"
rows := []interface{}{
+ // The enterprise policy resolves the tenant role through the user row.
+ &entity.User{ID: "user-1", Nickname: "user", Email: "[email protected]", IsAuthenticated: "1", IsActive: "1", IsAnonymous: "0"},
&entity.UserTenant{ID: "user-tenant-1", UserID: "user-1", TenantID: "tenant-1", Role: "owner", InvitedBy: "user-1", Status: &activeStatus},
&entity.TenantModelProvider{ID: "provider-1", UserID: "user-1", TenantID: "tenant-1", ProviderName: "OpenAI"},
&entity.TenantModelInstance{ID: "instance-1", ProviderID: "provider-1", InstanceName: "default", APIKey: "sk-test", Status: "active", Extra: "{}"},
@@ -315,6 +318,11 @@ func TestListModelsSavedCredentialsUsesProviderCatalogMerge(t *testing.T) {
db := setupProviderHandlerTestDB(t)
useProviderHandlerTestDB(t, db)
seedProviderHandlerModel(t, db)
+ // The enterprise policy also reads group, role and grant tables; the
+ // fixture migrates and seeds them, and is a no-op in the community build.
+ if err := testsupport.PrepareEnterprisePermissionFixture(db, "tenant-1", "user-1"); err != nil {
+ t.Fatalf("prepare provider permission fixture: %v", err)
+ }
provider := dao.GetModelProviderManager().FindProvider("OpenAI")
if provider == nil {
diff --git a/internal/service/model_service_test.go b/internal/service/model_service_test.go
index 68bb80dd1c..037518e4c4 100644
--- a/internal/service/model_service_test.go
+++ b/internal/service/model_service_test.go
@@ -940,6 +940,9 @@ func TestCheckConnectionUsesStoredCredentialsAndAllowsOwnerOverrides(t *testing.
db := setupModelProviderServiceTestDB(t)
useModelProviderServiceTestDB(t, db)
seedModelProviderServiceScope(t, db)
+ if err := db.Model(&entity.TenantModelProvider{}).Where("id = ?", "provider-1").Update("tenant_id", "tenant-1").Error; err != nil {
+ t.Fatalf("move provider into test tenant: %v", err)
+ }
if err := db.Model(&entity.TenantModelInstance{}).Where("id = ?", "instance-1").Updates(map[string]interface{}{
"api_key": "sk-stored-secret",
"extra": `{"region":"us-east-1","base_url":"https://stored.example"}`,
diff --git a/internal/service/skill_space_test.go b/internal/service/skill_space_test.go
index caab1ee583..1afc340242 100644
--- a/internal/service/skill_space_test.go
+++ b/internal/service/skill_space_test.go
@@ -40,7 +40,8 @@ import (
// every retry and space creation refuses the same name.
func TestAsyncDeleteSpaceOutlivesTheRequestContext(t *testing.T) {
db := setupServiceTestDB(t)
- if err := db.AutoMigrate(&entity.SkillSpace{}); err != nil {
+ models := append([]interface{}{&entity.SkillSpace{}}, permissionChangeLogTestModels()...)
+ if err := db.AutoMigrate(models...); err != nil {
t.Fatalf("failed to migrate skill space: %v", err)
}
pushServiceDB(t, db)
@@ -77,7 +78,8 @@ func TestAsyncDeleteSpaceOutlivesTheRequestContext(t *testing.T) {
// and storage objects behind even though the space was marked deleted.
func TestAsyncDeleteSpaceDeletesTheFolderAsItsCreator(t *testing.T) {
db := setupServiceTestDB(t)
- if err := db.AutoMigrate(&entity.SkillSpace{}); err != nil {
+ models := append([]interface{}{&entity.SkillSpace{}}, permissionChangeLogTestModels()...)
+ if err := db.AutoMigrate(models...); err != nil {
t.Fatalf("failed to migrate skill space: %v", err)
}
pushServiceDB(t, db)
@@ -153,7 +155,8 @@ func failFolderLookupsOnce(t *testing.T, db *gorm.DB, budget int32) {
// the retry is what keeps the space and its folder in agreement.
func TestAsyncDeleteSpaceRetriesTheFolderLookup(t *testing.T) {
db := setupServiceTestDB(t)
- if err := db.AutoMigrate(&entity.SkillSpace{}); err != nil {
+ models := append([]interface{}{&entity.SkillSpace{}}, permissionChangeLogTestModels()...)
+ if err := db.AutoMigrate(models...); err != nil {
t.Fatalf("failed to migrate skill space: %v", err)
}
pushServiceDB(t, db)
@@ -212,7 +215,8 @@ func TestAsyncDeleteSpaceRetriesTheFolderLookup(t *testing.T) {
// storage objects survive.
func TestAsyncDeleteSpaceKeepsTheDeletingStatusWhenTheFolderCreatorCannotBeRead(t *testing.T) {
db := setupServiceTestDB(t)
- if err := db.AutoMigrate(&entity.SkillSpace{}); err != nil {
+ models := append([]interface{}{&entity.SkillSpace{}}, permissionChangeLogTestModels()...)
+ if err := db.AutoMigrate(models...); err != nil {
t.Fatalf("failed to migrate skill space: %v", err)
}
pushServiceDB(t, db)
@@ -260,7 +264,8 @@ func TestAsyncDeleteSpaceKeepsTheDeletingStatusWhenTheFolderCreatorCannotBeRead(
// space creation kept refusing the name.
func TestDeleteSpaceRestartsCleanupLeftInTheDeletingState(t *testing.T) {
db := setupServiceTestDB(t)
- if err := db.AutoMigrate(&entity.SkillSpace{}); err != nil {
+ models := append([]interface{}{&entity.SkillSpace{}}, permissionChangeLogTestModels()...)
+ if err := db.AutoMigrate(models...); err != nil {
t.Fatalf("failed to migrate skill space: %v", err)
}
pushServiceDB(t, db)
@@ -275,6 +280,14 @@ func TestDeleteSpaceRestartsCleanupLeftInTheDeletingState(t *testing.T) {
sqlDB.SetMaxOpenConns(1)
valid := string(entity.StatusValid)
+ // The enterprise policy resolves the tenant role through the user row, so
+ // the acting owner needs one; the community policy never reads it.
+ if err := db.Create(&entity.User{
+ ID: "owner-1", Nickname: "owner", Email: "[email protected]",
+ IsAuthenticated: "1", IsActive: "1", IsAnonymous: "0",
+ }).Error; err != nil {
+ t.Fatalf("create owner user: %v", err)
+ }
if err := db.Create(&entity.UserTenant{
ID: "owner-membership",
UserID: "owner-1",
@@ -284,6 +297,12 @@ func TestDeleteSpaceRestartsCleanupLeftInTheDeletingState(t *testing.T) {
}).Error; err != nil {
t.Fatalf("create membership: %v", err)
}
+ // The cleanup runs as member-1, the folder creator; the enterprise policy
+ // authorizes that principal through its tenant membership. The owner seeded
+ // above keeps the fixture from promoting member-1 to owner.
+ if err := testsupport.PrepareEnterprisePermissionFixture(db, "tenant-1", "member-1"); err != nil {
+ t.Fatalf("prepare skill space permission fixture: %v", err)
+ }
factory := storage.GetStorageFactory()
previous := factory.GetStorage()
diff --git a/internal/service/test_helpers_stub_test.go b/internal/service/test_helpers_stub_test.go
index 573fd87a72..1298f7a54e 100644
--- a/internal/service/test_helpers_stub_test.go
+++ b/internal/service/test_helpers_stub_test.go
@@ -25,3 +25,7 @@ import "testing"
// the enterprise repository defines the same helper for its build.
func grantServiceTestResource(_ *testing.T, _ string, _ string, _ string, _ string, _ int32) {
}
+
+// permissionChangeLogTestModels adds no tables: the community edition has no
+// permission audit log. It lives here for the same reason as the helper above.
+func permissionChangeLogTestModels() []interface{} { return nil }
diff --git a/internal/service/test_helpers_test.go b/internal/service/test_helpers_test.go
index 600bc07e7f..8900e5d25f 100644
--- a/internal/service/test_helpers_test.go
+++ b/internal/service/test_helpers_test.go
@@ -275,10 +275,6 @@ func insertTestIngestionTask(t *testing.T, id, userID, docID, datasetID string)
insertTestIngestionTaskWithStatus(t, id, userID, docID, datasetID, common.CREATED)
}
-// permissionChangeLogTestModels adds no tables: the community edition has no
-// permission audit log.
-func permissionChangeLogTestModels() []interface{} { return nil }
-
// insertTestIngestionTaskWithStatus inserts a test IngestionTask with a specific status.
func insertTestIngestionTaskWithStatus(t *testing.T, id, userID, docID, datasetID, status string) {
t.Helper()