Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(dataset): treat empty avatar as a clear signal on update (#20724)

ciele0b91ccc9fb1
diff --git a/internal/service/dataset/helpers.go b/internal/service/dataset/helpers.go
index f27078a555..afc34ce5e3 100644
--- a/internal/service/dataset/helpers.go
+++ b/internal/service/dataset/helpers.go
@@ -123,6 +123,9 @@ func quoteList(items []string) string {
}
func validateDatasetAvatar(avatar string) error {
+ if avatar == "" {
+ return nil
+ }
if !strings.Contains(avatar, ",") {
return errors.New("missing MIME prefix. Expected format: data:<mime>;base64,<data>")
}
diff --git a/internal/service/dataset/helpers_test.go b/internal/service/dataset/helpers_test.go
index e33c3ec317..a52d810ac2 100644
--- a/internal/service/dataset/helpers_test.go
+++ b/internal/service/dataset/helpers_test.go
@@ -50,6 +50,12 @@ func TestValidateParserID_RejectsUnknown(t *testing.T) {
// --- validateDatasetAvatar ---
+func TestValidateDatasetAvatar_Empty(t *testing.T) {
+ if err := validateDatasetAvatar(""); err != nil {
+ t.Fatalf("expected nil for empty avatar (clear signal), got %v", err)
+ }
+}
+
func TestValidateDatasetAvatar_MissingPrefix(t *testing.T) {
err := validateDatasetAvatar("iVBORw0KGgo=")
if err == nil {
diff --git a/internal/service/dataset/update_test.go b/internal/service/dataset/update_test.go
index 0647b56d83..a48f42a50a 100644
--- a/internal/service/dataset/update_test.go
+++ b/internal/service/dataset/update_test.go
@@ -99,6 +99,38 @@ func TestDatasetServiceUpdateDatasetUpdatesFields(t *testing.T) {
}
}
+func TestUpdateDataset_ClearsAvatarWithEmptyString(t *testing.T) {
+ db := setupDatasetUpdateTestDB(t)
+ pushServiceDB(t, db)
+ insertDatasetUpdateKB(t, "kb-1", "tenant-1", "Original")
+
+ svc := testDatasetUpdateService(t)
+ initial := "data:image/png;base64,iVBORw0KGgo="
+ if _, code, err := svc.UpdateDataset(t.Context(), "kb-1", "tenant-1", service.UpdateDatasetRequest{Avatar: &initial}); err != nil || code != common.CodeSuccess {
+ t.Fatalf("set avatar failed: code=%d err=%v", code, err)
+ }
+
+ empty := ""
+ result, code, err := svc.UpdateDataset(t.Context(), "kb-1", "tenant-1", service.UpdateDatasetRequest{Avatar: &empty})
+ if err != nil {
+ t.Fatalf("clear avatar failed: %v", err)
+ }
+ if code != common.CodeSuccess {
+ t.Fatalf("expected success code, got %d", code)
+ }
+ if result["avatar"] != "" {
+ t.Fatalf("expected empty avatar in response, got %#v", result["avatar"])
+ }
+
+ persisted, err := dao.NewKnowledgebaseDAO().GetByID(t.Context(), db, "kb-1")
+ if err != nil {
+ t.Fatalf("get updated kb: %v", err)
+ }
+ if persisted.Avatar == nil || *persisted.Avatar != "" {
+ t.Fatalf("expected persisted empty avatar, got %#v", persisted.Avatar)
+ }
+}
+
// TestUpdateDataset_ParentChildConfigReachesGeneralChunker verifies an edit to
// the dataset setting updates the runtime chunker parameter, not only the UI
// payload retained in parser_config.