Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(deepdoc): preserve PDF captions labeled as references (#20767)

lorenzozanee5ea8666ef96
diff --git a/internal/deepdoc/parser/pdf/table/table_annotate.go b/internal/deepdoc/parser/pdf/table/table_annotate.go
index 911a97460a..73770b4712 100644
--- a/internal/deepdoc/parser/pdf/table/table_annotate.go
+++ b/internal/deepdoc/parser/pdf/table/table_annotate.go
@@ -475,15 +475,15 @@ func AnnotateBoxLayouts(boxes []pdf.TextBox, regions []pdf.DLARegion, scale floa
}
// ── garbage layout helpers ────────────────────────────────────────────
-// garbageKeepFeat matches Python's keep_feats in LayoutRecognizer.__call__:
-// footer near page bottom (>90% of page height) or header near page top (<10%)
-// are real page decorations - keep them. Others are DLA noise.
+// garbageKeepFeat keeps likely false-positive garbage labels.
func garbageKeepFeat(ty string, box pdf.TextBox, pageImgHeight float64) bool {
switch ty {
case pdf.LayoutTypeFooter:
return box.Bottom < pageImgHeight*0.9
case pdf.LayoutTypeHeader:
return box.Top > pageImgHeight*0.1
+ case pdf.LayoutTypeReference:
+ return IsCaptionBox(box.Text, "")
}
return false
}
diff --git a/internal/deepdoc/parser/pdf/table/table_annotate_test.go b/internal/deepdoc/parser/pdf/table/table_annotate_test.go
index 6ffd615b99..4138ac8140 100644
--- a/internal/deepdoc/parser/pdf/table/table_annotate_test.go
+++ b/internal/deepdoc/parser/pdf/table/table_annotate_test.go
@@ -247,15 +247,29 @@ func TestAnnotateBoxLayouts_FooterKeptInMiddle(t *testing.T) {
}
}
-func TestAnnotateBoxLayouts_ReferenceAlwaysGarbage(t *testing.T) {
- // Reference type is always garbage regardless of position (no keep_feat).
- boxes := []pdf.TextBox{{X0: 0, X1: 100, Top: 50, Bottom: 70}}
+func TestAnnotateBoxLayouts_ReferenceEntryDropped(t *testing.T) {
+ // Ordinary reference-list text remains garbage regardless of position.
+ boxes := []pdf.TextBox{{X0: 0, X1: 100, Top: 50, Bottom: 70, Text: "A. Author, A reference entry."}}
regions := []pdf.DLARegion{
{X0: 0, Y0: 150, X1: 300, Y1: 210, Label: "reference", Confidence: 0.9},
}
boxes = AnnotateBoxLayouts(boxes, regions, 3.0, 300)
if len(boxes) != 0 {
- t.Errorf("reference: should always be garbage-filtered, got %q", boxes[0].LayoutType)
+ t.Errorf("reference entry should be garbage-filtered, got %q", boxes[0].LayoutType)
+ }
+}
+
+func TestAnnotateBoxLayouts_ReferenceCaptionPreserved(t *testing.T) {
+ boxes := []pdf.TextBox{{X0: 0, X1: 100, Top: 50, Bottom: 70, Text: "Table 8: Prompt for the Pick Task."}}
+ regions := []pdf.DLARegion{
+ {X0: 0, Y0: 150, X1: 300, Y1: 210, Label: "reference", Confidence: 0.9},
+ }
+ boxes = AnnotateBoxLayouts(boxes, regions, 3.0, 300)
+ if len(boxes) != 1 {
+ t.Fatalf("reference caption should be preserved, got %d boxes", len(boxes))
+ }
+ if boxes[0].Text != "Table 8: Prompt for the Pick Task." || boxes[0].LayoutType != "reference" {
+ t.Errorf("reference caption changed: got text=%q layout=%q", boxes[0].Text, boxes[0].LayoutType)
}
}