RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(agent): preserve Boolean values in Variable Assigner (#19499)
Fei Haihaoe77c6626d621
diff --git a/agent/component/variable_assigner.py b/agent/component/variable_assigner.pyindex 10906bda1b..19d7b24a8e 100644--- a/agent/component/variable_assigner.py+++ b/agent/component/variable_assigner.py@@ -109,6 +109,13 @@ class VariableAssigner(ComponentBase, ABC):elif isinstance(variable, str):return self._canvas.get_value_with_variable(parameter)elif isinstance(variable, bool):+ # Accept yes/true and no/false spellings case-insensitively.+ if isinstance(parameter, str):+ normalized = parameter.lower()+ if normalized in {"yes", "true"}:+ return True+ elif normalized in {"no", "false"}:+ return Falsereturn parameterelif isinstance(variable, int):return parameterdiff --git a/internal/agent/component/variable_assigner.go b/internal/agent/component/variable_assigner.goindex 43f232bb40..7fa2e948fd 100644--- a/internal/agent/component/variable_assigner.go+++ b/internal/agent/component/variable_assigner.go@@ -284,6 +284,17 @@ func operate(state *runtime.CanvasState, oldVal any, op string, param any) (any,}}return param, ""+ case bool:+ // Accept yes/true and no/false spellings case-insensitively.+ if s, ok := param.(string); ok {+ switch strings.ToLower(s) {+ case "yes", "true":+ return true, ""+ case "no", "false":+ return false, ""+ }+ }+ return param, ""default:return param, ""}diff --git a/internal/agent/component/variable_assigner_test.go b/internal/agent/component/variable_assigner_test.goindex f490b81e74..b505a13f5c 100644--- a/internal/agent/component/variable_assigner_test.go+++ b/internal/agent/component/variable_assigner_test.go@@ -82,6 +82,56 @@ func TestVariableAssigner_Overwrite(t *testing.T) {}}+// TestVariableAssigner_SetBoolean: boolean spellings are normalized+// case-insensitively, while native booleans are passed through unchanged.+func TestVariableAssigner_SetBoolean(t *testing.T) {+ tests := []struct {+ name string+ parameter any+ want bool+ }{+ {name: "native true", parameter: true, want: true},+ {name: "native false", parameter: false, want: false},+ {name: "legacy yes", parameter: "yes", want: true},+ {name: "legacy no", parameter: "no", want: false},+ {name: "uppercase yes", parameter: "YES", want: true},+ {name: "mixed-case no", parameter: "No", want: false},+ {name: "true spelling", parameter: "true", want: true},+ {name: "uppercase false spelling", parameter: "FALSE", want: false},+ }++ for _, tt := range tests {+ t.Run(tt.name, func(t *testing.T) {+ state := canvas.NewCanvasState("run-set-boolean", "task-set-boolean")+ state.Outputs["cpn_0"] = map[string]any{"flag": false}+ ctx := canvas.WithState(t.Context(), state)++ vars := []map[string]any{+ {+ "variable": "cpn_0@flag",+ "operator": "set",+ "parameter": tt.parameter,+ },+ }+ c, err := NewVariableAssignerComponent(map[string]any{"variables": vars})+ if err != nil {+ t.Fatalf("NewVariableAssignerComponent: %v", err)+ }+ if _, err = c.Invoke(ctx, nil, nil); err != nil {+ t.Fatalf("Invoke: %v", err)+ }++ got, ok := state.Outputs["cpn_0"]["flag"].(bool)+ if !ok {+ t.Fatalf("flag has type %T, want bool", state.Outputs["cpn_0"]["flag"])+ }+ if got != tt.want {+ t.Errorf("flag: got %v, want %v", got, tt.want)+ }+ })+ }+}+// TestVariableAssigner_DivideByZero: assert "ERROR:DIVIDE_BY_ZERO"// returned, state unchanged.func TestVariableAssigner_DivideByZero(t *testing.T) {diff --git a/test/unit_test/agent/component/test_variable_assigner.py b/test/unit_test/agent/component/test_variable_assigner.pynew file mode 100644index 0000000000..5e0e2b0646--- /dev/null+++ b/test/unit_test/agent/component/test_variable_assigner.py@@ -0,0 +1,27 @@+import pytest++from agent.component.variable_assigner import VariableAssigner+++ ("parameter", "expected"),+ [+ (True, True),+ (False, False),+ ("yes", True),+ ("no", False),+ ("YES", True),+ ("No", False),+ ("true", True),+ ("FALSE", False),+ ],+)+def test_set_boolean_normalizes_boolean_spellings(parameter, expected):+ # Boolean normalization does not access instance state, so initialization is unnecessary.+ component = VariableAssigner.__new__(VariableAssigner)++ result = component._set(False, parameter)++ assert result is expected+ assert type(result) is bool