Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix: preserve non-string values in update_metadata_to (#17346)

天海蒼灆e9cace9a0909
diff --git a/common/metadata_utils.py b/common/metadata_utils.py
index df762793fc..9d76e486dd 100644
--- a/common/metadata_utils.py
+++ b/common/metadata_utils.py
@@ -306,6 +306,14 @@ def dedupe_list(values: list) -> list:
def update_metadata_to(metadata, meta):
+ """Merge ``meta`` into ``metadata``.
+
+ String / list[str] values keep the previous multi-value merge + dedupe
+ behavior (used by LLM-extracted metadata). Scalars (bool / int / float /
+ None) and structured values (list[dict], dict, ...) are preserved so that
+ document system fields such as ``_isCurrent`` / ``_version`` and PDF
+ ``outline`` survive merges that later fully replace ``meta_fields``.
+ """
if not meta:
return metadata
if isinstance(meta, str):
@@ -319,22 +327,78 @@ def update_metadata_to(metadata, meta):
for k, v in meta.items():
if isinstance(v, list):
- v = [vv for vv in v if isinstance(vv, str)]
- if not v:
+ if all(isinstance(vv, str) for vv in v):
+ if not v:
+ continue
+ v = dedupe_list(v)
+ else:
+ # Structured list (e.g. outline [{title, depth}, ...]).
+ if k not in metadata:
+ logging.debug(
+ "update_metadata_to preserve structured list key=%s src=%s",
+ k,
+ type(v).__name__,
+ )
+ metadata[k] = v
+ else:
+ logging.debug(
+ "update_metadata_to skip structured list key=%s src=%s dst=%s",
+ k,
+ type(v).__name__,
+ type(metadata[k]).__name__,
+ )
continue
- v = dedupe_list(v)
- if not isinstance(v, list) and not isinstance(v, str):
+ elif isinstance(v, (str, bool, int, float)) or v is None:
+ pass
+ else:
+ # dict / other structured values: keep if absent.
+ if k not in metadata:
+ logging.debug(
+ "update_metadata_to preserve structured value key=%s src=%s",
+ k,
+ type(v).__name__,
+ )
+ metadata[k] = v
+ else:
+ logging.debug(
+ "update_metadata_to skip structured value key=%s src=%s dst=%s",
+ k,
+ type(v).__name__,
+ type(metadata[k]).__name__,
+ )
continue
+
if k not in metadata:
+ if not isinstance(v, (list, str)):
+ logging.debug(
+ "update_metadata_to preserve scalar key=%s src=%s",
+ k,
+ type(v).__name__,
+ )
metadata[k] = v
continue
- if isinstance(metadata[k], list):
+ if isinstance(metadata[k], list) and isinstance(v, (list, str)):
+ if not all(isinstance(x, str) for x in metadata[k]):
+ logging.debug(
+ "update_metadata_to skip merge into structured list key=%s src=%s dst=%s",
+ k,
+ type(v).__name__,
+ type(metadata[k]).__name__,
+ )
+ continue
if isinstance(v, list):
metadata[k].extend(v)
else:
metadata[k].append(v)
metadata[k] = dedupe_list(metadata[k])
else:
+ if not isinstance(v, (list, str)):
+ logging.debug(
+ "update_metadata_to replace scalar key=%s src=%s dst=%s",
+ k,
+ type(v).__name__,
+ type(metadata[k]).__name__,
+ )
metadata[k] = v
return metadata
diff --git a/test/unit_test/common/test_update_metadata_to.py b/test/unit_test/common/test_update_metadata_to.py
new file mode 100644
index 0000000000..eec92ae85f
--- /dev/null
+++ b/test/unit_test/common/test_update_metadata_to.py
@@ -0,0 +1,78 @@
+#
+# Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
+#
+
+from common.metadata_utils import update_metadata_to
+
+
+def test_update_metadata_to_merges_string_lists():
+ base = {"tags": ["a"]}
+ update_metadata_to(base, {"tags": ["a", "b"]})
+ assert base["tags"] == ["a", "b"]
+
+
+def test_update_metadata_to_preserves_bool_int_when_merging_existing():
+ # Same call shape as outline persist: new fields first, existing doc meta second.
+ merged = update_metadata_to(
+ {"outline": [{"title": "Ch1", "depth": 0}]},
+ {
+ "_isCurrent": True,
+ "_version": 1,
+ "_processStatus": 4,
+ "category_code": "02",
+ },
+ )
+ assert merged["_isCurrent"] is True
+ assert merged["_version"] == 1
+ assert merged["_processStatus"] == 4
+ assert merged["category_code"] == "02"
+ assert merged["outline"] == [{"title": "Ch1", "depth": 0}]
+
+
+def test_update_metadata_to_keeps_first_outline_when_existing_also_has_outline():
+ merged = update_metadata_to(
+ {"outline": [{"title": "new", "depth": 0}]},
+ {"outline": [{"title": "old", "depth": 1}], "_version": 2},
+ )
+ assert merged["outline"] == [{"title": "new", "depth": 0}]
+ assert merged["_version"] == 2
+
+
+def test_update_metadata_to_skips_empty_string_list():
+ base = {"tags": ["a"]}
+ update_metadata_to(base, {"tags": [], "other": []})
+ assert base == {"tags": ["a"]}
+
+
+def test_update_metadata_to_preserves_float_and_none():
+ merged = update_metadata_to({}, {"score": 1.5, "note": None})
+ assert merged["score"] == 1.5
+ assert merged["note"] is None
+
+
+def test_update_metadata_to_preserves_dict_when_absent():
+ merged = update_metadata_to({}, {"extra": {"a": 1}})
+ assert merged["extra"] == {"a": 1}
+
+
+def test_update_metadata_to_skips_dict_when_present():
+ base = {"extra": {"a": 1}}
+ update_metadata_to(base, {"extra": {"b": 2}})
+ assert base["extra"] == {"a": 1}
+
+
+def test_update_metadata_to_inserts_structured_list_when_absent():
+ merged = update_metadata_to({}, {"outline": [{"title": "Ch1", "depth": 0}]})
+ assert merged["outline"] == [{"title": "Ch1", "depth": 0}]
+
+
+def test_update_metadata_to_does_not_append_string_to_structured_list():
+ base = {"outline": [{"title": "Ch1", "depth": 0}]}
+ update_metadata_to(base, {"outline": "chapter"})
+ assert base["outline"] == [{"title": "Ch1", "depth": 0}]
+
+
+def test_update_metadata_to_does_not_extend_structured_list_with_strings():
+ base = {"outline": [{"title": "Ch1", "depth": 0}]}
+ update_metadata_to(base, {"outline": ["a", "b"]})
+ assert base["outline"] == [{"title": "Ch1", "depth": 0}]