RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(agent): reject empty message rows when saving canvas (#19149)
Sbaaoui Idrissec8f5e042101
diff --git a/internal/agent/component/dynamic_params.go b/internal/agent/component/dynamic_params.goindex 4ca1dfa044..fc255525e2 100644--- a/internal/agent/component/dynamic_params.go+++ b/internal/agent/component/dynamic_params.go@@ -53,6 +53,10 @@ func validateDynamicParams(component string, params map[string]any) error {}}switch strings.ToLower(component) {+ case "message":+ if err := validateMessageContent(params); err != nil {+ return fmt.Errorf("[%s] %w", component, err)+ }case "dataoperations":for _, field := range []string{"select_keys", "remove_keys"} {if values, ok := params[field].([]any); ok && containsBlank(values) {@@ -92,6 +96,43 @@ func validateDynamicParams(component string, params map[string]any) error {return nil}+func validateMessageContent(params map[string]any) error {+ if text, ok := params["text"]; ok {+ if !isNonBlankString(text) {+ return fmt.Errorf("content does not support empty value")+ }+ return nil+ }+ content, ok := params["content"]+ if !ok {+ return fmt.Errorf("content does not support empty value")+ }+ switch values := content.(type) {+ case string:+ if !isNonBlankString(values) {+ return fmt.Errorf("content does not support empty value")+ }+ case []string:+ for _, value := range values {+ if strings.TrimSpace(value) == "" {+ return fmt.Errorf("content does not support empty entries")+ }+ }+ case []any:+ if len(values) == 0 {+ return fmt.Errorf("content does not support empty value")+ }+ for _, value := range values {+ if !isNonBlankString(value) {+ return fmt.Errorf("content does not support empty entries")+ }+ }+ default:+ return fmt.Errorf("content does not support empty value")+ }+ return nil+}+func validateRows(component string, params map[string]any, field string, required []string) error {rows, ok := params[field].([]any)if !ok {diff --git a/internal/agent/component/dynamic_params_test.go b/internal/agent/component/dynamic_params_test.goindex 74d29c3816..91aa1f064f 100644--- a/internal/agent/component/dynamic_params_test.go+++ b/internal/agent/component/dynamic_params_test.go@@ -28,6 +28,7 @@ func TestValidateDynamicEntries(t *testing.T) {componentDSL("Iteration", map[string]any{"outputs": map[string]any{"result": map[string]any{"type": "string", "ref": "Iteration@result"},}}),+ componentDSL("Message", map[string]any{"text": "hello"}),// Whitespace-only delimiters are legitimate split tokens: the web// form's default row is "\n" (a real newline) and the delimiter// input converts a typed "\n"/"\t" into the raw control character@@ -61,6 +62,10 @@ func TestValidateDynamicEntries(t *testing.T) {{"input option", componentDSL("UserFillUp", map[string]any{"inputs": map[string]any{"choice": map[string]any{"options": []any{"one", ""}}}}), "inputs.choice.options"},{"empty delimiter entry", componentDSL("TokenChunker", map[string]any{"delimiters": []any{"ok", ""}}), "delimiters"},{"empty children delimiter entry", componentDSL("TokenChunker", map[string]any{"children_delimiters": []any{""}}), "children_delimiters"},+ {"empty message text", componentDSL("Message", map[string]any{"text": " \t "}), "Message"},+ {"empty message content", componentDSL("Message", map[string]any{"content": []any{""}}), "Message"},+ {"missing message content", componentDSL("Message", map[string]any{}), "Message"},+ {"blank message row after valid row", componentDSL("Message", map[string]any{"content": []any{"hello", " "}}), "Message"},}for _, test := range tests {diff --git a/web/src/pages/agent/hooks/use-save-graph.ts b/web/src/pages/agent/hooks/use-save-graph.tsindex 00f8da650b..e67d3e615e 100644--- a/web/src/pages/agent/hooks/use-save-graph.ts+++ b/web/src/pages/agent/hooks/use-save-graph.ts@@ -119,6 +119,7 @@ export const useSaveGraph = (message.warning(`${emptyMessageNodeNames.join(', ')}: ${t('flow.messageMsg')}`,);+ return;}}diff --git a/web/src/pages/agent/utils.test.ts b/web/src/pages/agent/utils.test.tsindex a4f550136b..56f44e598b 100644--- a/web/src/pages/agent/utils.test.ts+++ b/web/src/pages/agent/utils.test.ts@@ -64,7 +64,7 @@ describe('Message component content validation', () => {it('accepts content with at least one non-blank string entry', () => {expect(isEmptyMessageContent(['hi'])).toBe(false);- expect(isEmptyMessageContent(['', '{begin@query}'])).toBe(false);+ expect(isEmptyMessageContent(['', '{begin@query}'])).toBe(true);expect(isEmptyMessageContent([' text '])).toBe(false);});});diff --git a/web/src/pages/agent/utils.ts b/web/src/pages/agent/utils.tsindex 61d6cd1672..99e8cac219 100644--- a/web/src/pages/agent/utils.ts+++ b/web/src/pages/agent/utils.ts@@ -942,7 +942,8 @@ export function convertToObjectArray<T extends string | number | boolean>(export function isEmptyMessageContent(content?: unknown): boolean {return (!Array.isArray(content) ||- !content.some((item) => typeof item === 'string' && item.trim() !== '')+ content.length === 0 ||+ content.some((item) => typeof item !== 'string' || item.trim() === ''));}