RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(storage): prevent MinIO client reconnect races (#20888)
Sbaaoui Idrissfe8dc679abee
diff --git a/internal/storage/minio.go b/internal/storage/minio.goindex 1ae6615b14..b48085b617 100644--- a/internal/storage/minio.go+++ b/internal/storage/minio.go@@ -81,12 +81,6 @@ func (m *MinioStorage) connect() error {return nil}-func (m *MinioStorage) reconnect() {- if err := m.connect(); err != nil {- common.Fatal(fmt.Sprintf("Failed to reconnect to MinIO, %s", err.Error()))- }-}-func (m *MinioStorage) resolveBucketAndPath(bucket, fnm string) (string, string) {actualBucket := bucketif m.bucket != "" {@@ -140,7 +134,6 @@ func (m *MinioStorage) Put(ctx context.Context, bucket, fnm string, binary []bytreturn ctxErr}common.Warn("Failed to check bucket existence", zap.String("bucket", bucket), zap.Error(err))- m.reconnect()if sleepErr := sleepOrAbort(ctx, time.Second); sleepErr != nil {return sleepErr}@@ -153,7 +146,6 @@ func (m *MinioStorage) Put(ctx context.Context, bucket, fnm string, binary []bytreturn ctxErr}common.Warn("Failed to create bucket", zap.String("bucket", bucket), zap.Error(err))- m.reconnect()if sleepErr := sleepOrAbort(ctx, time.Second); sleepErr != nil {return sleepErr}@@ -171,7 +163,6 @@ func (m *MinioStorage) Put(ctx context.Context, bucket, fnm string, binary []bytreturn ctxErr}common.Warn(warnMessage, zap.String("bucket", bucket), zap.String("key", fnm), zap.Error(err))- m.reconnect()if sleepErr := sleepOrAbort(ctx, time.Second); sleepErr != nil {return sleepErr}@@ -197,7 +188,6 @@ func (m *MinioStorage) Get(ctx context.Context, bucket, fnm string, tenantID ...return nil, ctxErr}common.Warn("failed to get object", zap.String("bucket", bucket), zap.String("key", fnm), zap.Error(err))- m.reconnect()if sleepErr := sleepOrAbort(ctx, time.Second); sleepErr != nil {return nil, sleepErr}@@ -216,7 +206,6 @@ func (m *MinioStorage) Get(ctx context.Context, bucket, fnm string, tenantID ...return nil, ctxErr}common.Error("failed to read object data", err, zap.String("bucket", bucket), zap.String("key", fnm))- m.reconnect()if sleepErr := sleepOrAbort(ctx, time.Second); sleepErr != nil {return nil, sleepErr}@@ -291,7 +280,6 @@ func (m *MinioStorage) GetPresignedURL(ctx context.Context, bucket, fnm string,return "", ctxErr}common.Warn("Failed to get presigned URL", zap.String("bucket", bucket), zap.String("key", fnm), zap.Error(err))- m.reconnect()if err = sleepOrAbort(ctx, time.Second); err != nil {return "", err}