Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.
TypeScript i18nextnext-authnextjspostgresqlprismareact-emailt3-stacktailwindcsstrpcturborepotypescriptzod
✨ Route review requests to Trustpilot or Capterra by email type (#3452)
Luke Vella06678f0d7bc3
diff --git a/apps/web/public/locales/en/app.json b/apps/web/public/locales/en/app.jsonindex fe837d7ab..d6ff57be4 100644--- a/apps/web/public/locales/en/app.json+++ b/apps/web/public/locales/en/app.json@@ -894,7 +894,7 @@"reviewRequestClose": "Dismiss","reviewRequestCta": "Write a review","reviewRequestFounderRole": "Founder of Rallly",- "reviewRequestMessage": "If Rallly saved you some back-and-forth, would you leave a quick review on G2? It helps others find us.",+ "reviewRequestMessage": "If Rallly saved you some back-and-forth, would you leave a quick review on {site}? It helps others find us.","revoke": "Revoke","revokeConfirmation": "Are you sure you want to revoke {name}? This will immediately disable the key.","revoked": "Revoked",diff --git a/apps/web/src/env.ts b/apps/web/src/env.tsindex e4243ae00..4e4a2fc8c 100644--- a/apps/web/src/env.ts+++ b/apps/web/src/env.ts@@ -114,6 +114,13 @@ export const env = createEnv({GOOGLE_CLIENT_ID: z.string().optional(),GOOGLE_CLIENT_SECRET: z.string().optional(),+ /**+ * Review site the post-finalize review request sends business users to.+ * Users on a free mail provider are sent to Trustpilot instead.+ */+ REVIEW_REQUEST_BUSINESS_SITE: z+ .enum(["capterra", "g2"])+ .default("capterra"),/*** Conferencing integrations (Zoom, Google Meet, Microsoft Teams, Webex).* The flag needs at least one provider's OAuth app configured; see@@ -311,6 +318,7 @@ export const env = createEnv({LICENSE_API_AUTH_TOKEN: process.env.LICENSE_API_AUTH_TOKEN,GOOGLE_CLIENT_ID: process.env.GOOGLE_CLIENT_ID,GOOGLE_CLIENT_SECRET: process.env.GOOGLE_CLIENT_SECRET,+ REVIEW_REQUEST_BUSINESS_SITE: process.env.REVIEW_REQUEST_BUSINESS_SITE,CONFERENCING_ENABLED: process.env.CONFERENCING_ENABLED,ZOOM_CLIENT_ID: process.env.ZOOM_CLIENT_ID,ZOOM_CLIENT_SECRET: process.env.ZOOM_CLIENT_SECRET,diff --git a/apps/web/src/features/poll/components/finalize-poll-dialog.tsx b/apps/web/src/features/poll/components/finalize-poll-dialog.tsxindex 5b8b15906..ef74b7846 100644--- a/apps/web/src/features/poll/components/finalize-poll-dialog.tsx+++ b/apps/web/src/features/poll/components/finalize-poll-dialog.tsx@@ -41,6 +41,7 @@ import type { PollParticipant } from "@/features/poll/types";import type { OptionVotes } from "@/features/poll/utils";import { rankOptionsByPopularity } from "@/features/poll/utils";import { ReviewRequestCard } from "@/features/review-request/components/review-request-card";+import type { ReviewSite } from "@/features/review-request/constants";import {EventDate,EventTimeRange,@@ -575,11 +576,11 @@ function FinalizeWizard({ onClose }: { onClose: () => void }) {() => new Set(participants.filter((p) => p.email).map((p) => p.id)),);const option = options.find((o) => o.id === optionId);- const [askForReview, setAskForReview] = React.useState(false);+ const [reviewSite, setReviewSite] = React.useState<ReviewSite | null>(null);const finalize = trpc.polls.book.useMutation({onSuccess: (data) => {- setAskForReview(data?.askForReview ?? false);+ setReviewSite(data?.reviewSite ?? null);setStep("done");// The page behind the dialog picks up the scheduled status.router.refresh();@@ -640,7 +641,7 @@ function FinalizeWizard({ onClose }: { onClose: () => void }) {</DialogDescription></DialogHeader></div>- {askForReview ? <ReviewRequestCard /> : null}+ {reviewSite ? <ReviewRequestCard site={reviewSite} /> : null}<Button className="w-full" onClick={onClose}><Trans i18nKey="backToPoll" defaults="Back to poll" /></Button>diff --git a/apps/web/src/features/review-request/components/review-request-card.tsx b/apps/web/src/features/review-request/components/review-request-card.tsxindex ef0cad6d6..10980d17b 100644--- a/apps/web/src/features/review-request/components/review-request-card.tsx+++ b/apps/web/src/features/review-request/components/review-request-card.tsx@@ -6,15 +6,17 @@ import { XIcon } from "lucide-react";import Image from "next/image";import React from "react";import { Trans, useTranslation } from "@/i18n/client";-import { reviewRequestUrl } from "../constants";+import type { ReviewSite } from "../constants";+import { reviewSites } from "../constants";/**- * Asks the user for a G2 review as a short note signed by the founder. The+ * Asks the user for a review on the given site as a short note signed by the founder. The* server decides eligibility and records the ask, so this renders only when* it should and only once per user.*/-export function ReviewRequestCard() {+export function ReviewRequestCard({ site }: { site: ReviewSite }) {const { t } = useTranslation();+ const { name, url } = reviewSites[site];const [dismissed, setDismissed] = React.useState(false);if (dismissed) {@@ -31,7 +33,7 @@ export function ReviewRequestCard() {onClick={() => {posthog?.capture("review_request:dismiss_click", {channel: "in_app",- destination: "g2",+ destination: site,});setDismissed(true);}}@@ -41,24 +43,19 @@ export function ReviewRequestCard() {<p className="text-pretty pr-6"><Transi18nKey="reviewRequestMessage"- defaults="If Rallly saved you some back-and-forth, would you leave a quick review on G2? It helps others find us."+ defaults="If Rallly saved you some back-and-forth, would you leave a quick review on {site}? It helps others find us."+ values={{ site: name }}/></p><ButtonclassName="w-full"variant="primary"nativeButton={false}- render={- <a- href={reviewRequestUrl}- target="_blank"- rel="noopener noreferrer"- />- }+ render={<a href={url} target="_blank" rel="noopener noreferrer" />}onClick={() => {posthog?.capture("review_request:cta_click", {channel: "in_app",- destination: "g2",+ destination: site,});setDismissed(true);}}diff --git a/apps/web/src/features/review-request/constants.ts b/apps/web/src/features/review-request/constants.tsindex 67a79c4a6..7418ecaf3 100644--- a/apps/web/src/features/review-request/constants.ts+++ b/apps/web/src/features/review-request/constants.ts@@ -4,7 +4,77 @@ import { isSelfHosted } from "@/lib/constants";// through the README and the license email insteadexport const isReviewRequestEnabled = !isSelfHosted;-// G2 first: splitting a few reviews a week across sites leaves both too thin-// for G2's badges. Add Capterra once G2 has enough reviews.-export const reviewRequestUrl =- "https://www.g2.com/products/rallly/review_modalities/new?utm_source=rallly&utm_medium=in-app&utm_campaign=review-request";+// Consumers review on Trustpilot; business users on one B2B site at a time,+// because splitting a few reviews a week across sites leaves each too thin for+// its badges. REVIEW_REQUEST_BUSINESS_SITE picks the B2B site.+export const reviewSites = {+ trustpilot: {+ name: "Trustpilot",+ url: "https://www.trustpilot.com/evaluate/rallly.co",+ },+ capterra: {+ name: "Capterra",+ url: "https://reviews.capterra.com/products/new/98997d01-ab0a-4292-9842-5b34c9411138/?utm_source=vp&utm_campaign=vendor_request",+ },+ g2: {+ name: "G2",+ url: "https://www.g2.com/products/rallly/review_modalities/new?utm_source=rallly&utm_medium=in-app&utm_campaign=review-request",+ },+} as const;++export type ReviewSite = keyof typeof reviewSites;++export const businessReviewSites = ["capterra", "g2"] as const;++export type BusinessReviewSite = (typeof businessReviewSites)[number];++/**+ * Free mail providers. An address on one of these is treated as a consumer.+ * Deliberately not exhaustive: a miss sends a consumer to the business review+ * site, which costs nothing worse than a less fitting ask.+ */+export const consumerEmailDomains: ReadonlySet<string> = new Set([+ "gmail.com",+ "googlemail.com",+ "outlook.com",+ "hotmail.com",+ "hotmail.co.uk",+ "hotmail.fr",+ "live.com",+ "live.co.uk",+ "msn.com",+ "yahoo.com",+ "yahoo.co.uk",+ "yahoo.fr",+ "yahoo.de",+ "ymail.com",+ "icloud.com",+ "me.com",+ "mac.com",+ "aol.com",+ "proton.me",+ "protonmail.com",+ "pm.me",+ "gmx.com",+ "gmx.de",+ "gmx.net",+ "web.de",+ "t-online.de",+ "mail.com",+ "zoho.com",+ "yandex.com",+ "yandex.ru",+ "mail.ru",+ "orange.fr",+ "free.fr",+ "laposte.net",+ "libero.it",+ "btinternet.com",+ "comcast.net",+ "qq.com",+ "163.com",+ "naver.com",+ "fastmail.com",+ "hey.com",+ "tutanota.com",+]);diff --git a/apps/web/src/features/review-request/mutations.ts b/apps/web/src/features/review-request/mutations.tsindex 1bef3607e..b3b11ac3e 100644--- a/apps/web/src/features/review-request/mutations.ts+++ b/apps/web/src/features/review-request/mutations.ts@@ -2,46 +2,51 @@ import "server-only";import { prisma } from "@rallly/database";import { createLogger } from "@rallly/logger";+import { env } from "@/env";import { isFeatureEnabled } from "@/lib/feature-flags/server";import { track } from "@/lib/posthog";import { countFinalizedPolls } from "./data";-import { isEligibleForReviewRequest } from "./utils";+import { isEligibleForReviewRequest, pickReviewSite } from "./utils";const logger = createLogger("review-request");/*** Decides whether to ask the user for a review right after they finalize a- * poll, and records the ask so it is shown once per user. Returns true when- * the caller should show the ask. Never throws: it runs after the poll is- * already finalized, so a failure here must not fail the finalize request.+ * poll, and records the ask so it is shown once per user. Returns the site to+ * ask for, or null when the caller should not ask. Never throws: it runs after+ * the poll is already finalized, so a failure here must not fail the finalize+ * request.*/export async function claimReviewRequest(params: {userId: string;+ email: string;participantCount: number;}) {try {return await claimReviewRequestOrThrow(params);} catch (error) {logger.error({ error, userId: params.userId }, "Review request failed");- return false;+ return null;}}async function claimReviewRequestOrThrow({userId,+ email,participantCount,}: {userId: string;+ email: string;participantCount: number;}) {if (!isFeatureEnabled("reviewRequests")) {- return false;+ return null;}const finalizedPollCount = await countFinalizedPolls(userId);if (!isEligibleForReviewRequest({ finalizedPollCount, participantCount })) {- return false;+ return null;}// Conditional on the column being unset, so two finalizations racing each@@ -52,21 +57,26 @@ async function claimReviewRequestOrThrow({});if (count === 0) {- return false;+ return null;}+ const site = pickReviewSite({+ email,+ businessSite: env.REVIEW_REQUEST_BUSINESS_SITE,+ });+track({ id: userId, isGuest: false },{event: "review_request:prompt_view",properties: {channel: "in_app",- destination: "g2",+ destination: site,finalized_poll_count: finalizedPollCount,participant_count: participantCount,},},);- return true;+ return site;}diff --git a/apps/web/src/features/review-request/utils.test.ts b/apps/web/src/features/review-request/utils.test.tsindex 1bd7b4866..87d273f59 100644--- a/apps/web/src/features/review-request/utils.test.ts+++ b/apps/web/src/features/review-request/utils.test.ts@@ -1,5 +1,5 @@import { describe, expect, it } from "vitest";-import { isEligibleForReviewRequest } from "./utils";+import { isEligibleForReviewRequest, pickReviewSite } from "./utils";describe("isEligibleForReviewRequest", () => {it("asks on the second finalized poll with three participants", () => {@@ -29,3 +29,29 @@ describe("isEligibleForReviewRequest", () => {).toBe(false);});});++describe("pickReviewSite", () => {+ it("sends free mail addresses to Trustpilot", () => {+ expect(+ pickReviewSite({ email: "[email protected]", businessSite: "capterra" }),+ ).toBe("trustpilot");+ });++ it("sends company addresses to the business site", () => {+ expect(+ pickReviewSite({ email: "[email protected]", businessSite: "capterra" }),+ ).toBe("capterra");+ expect(+ pickReviewSite({ email: "[email protected]", businessSite: "g2" }),+ ).toBe("g2");+ });++ it("does not treat a subdomain of a free mail provider as consumer", () => {+ expect(+ pickReviewSite({+ email: "[email protected]",+ businessSite: "g2",+ }),+ ).toBe("g2");+ });+});diff --git a/apps/web/src/features/review-request/utils.ts b/apps/web/src/features/review-request/utils.tsindex d97aaafe7..4f120ded1 100644--- a/apps/web/src/features/review-request/utils.ts+++ b/apps/web/src/features/review-request/utils.ts@@ -1,3 +1,6 @@+import type { BusinessReviewSite } from "./constants";+import { consumerEmailDomains } from "./constants";+// One finalized poll can be a fluke; a second one means Rallly worked for themconst minFinalizedPolls = 2;// Filters out solo tests: the poll worked for a group@@ -15,3 +18,20 @@ export function isEligibleForReviewRequest({participantCount >= minParticipants);}++/**+ * Consumers are pointed to Trustpilot, everyone else to the business review+ * site, judged by whether the address is on a free mail provider.+ */+export function pickReviewSite({+ email,+ businessSite,+}: {+ email: string;+ businessSite: BusinessReviewSite;+}) {+ const domain = email.trim().toLowerCase().split("@").pop();+ return domain && consumerEmailDomains.has(domain)+ ? ("trustpilot" as const)+ : businessSite;+}diff --git a/apps/web/src/trpc/routers/polls.ts b/apps/web/src/trpc/routers/polls.tsindex 2cf9f7b99..8f1ce8286 100644--- a/apps/web/src/trpc/routers/polls.ts+++ b/apps/web/src/trpc/routers/polls.ts@@ -1474,12 +1474,13 @@ export const polls = router({},});- const askForReview = await claimReviewRequest({+ const reviewSite = await claimReviewRequest({userId: ctx.user.id,+ email: ctx.user.email,participantCount: poll.participants.length,});- return { askForReview };+ return { reviewSite };}}),reopen: privateProcedurediff --git a/turbo.json b/turbo.jsonindex 692319698..cf78a729d 100644--- a/turbo.json+++ b/turbo.json@@ -99,6 +99,7 @@"PORT","RATE_LIMIT_ENABLED","QUICK_CREATE_ENABLED",+ "REVIEW_REQUEST_BUSINESS_SITE","S3_ACCESS_KEY_ID","S3_BUCKET_NAME","S3_ENDPOINT",