Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

♻️ Replace manual pageview capture with posthog-js history_change (#2815)

Luke Vella06ff79c4836f
diff --git a/apps/landing/src/app/[locale]/layout.tsx b/apps/landing/src/app/[locale]/layout.tsx
index 46db94bd8..b85d65b32 100644
--- a/apps/landing/src/app/[locale]/layout.tsx
+++ b/apps/landing/src/app/[locale]/layout.tsx
@@ -5,8 +5,6 @@ import { Analytics } from "@vercel/analytics/react";
import { domAnimation, LazyMotion } from "motion/react";
import type { Metadata, Viewport } from "next";
import { cacheLife } from "next/cache";
-import { Suspense } from "react";
-import { PostHogPageView } from "@/components/posthog-page-view";
import { sans } from "@/fonts/sans";
import { I18nProvider } from "@/i18n/client/i18n-provider";
import { getTranslation } from "@/i18n/server";
@@ -36,9 +34,6 @@ export default async function Root(props: {
<html lang={i18n.resolvedLanguage} className={sans.className}>
<body>
<LazyMotion features={domAnimation}>
- <Suspense fallback={null}>
- <PostHogPageView />
- </Suspense>
<I18nProvider locale={i18n.resolvedLanguage} resources={translations}>
{children}
</I18nProvider>
diff --git a/apps/landing/src/components/posthog-page-view.tsx b/apps/landing/src/components/posthog-page-view.tsx
deleted file mode 100644
index ad195a760..000000000
--- a/apps/landing/src/components/posthog-page-view.tsx
+++ /dev/null
@@ -1,23 +0,0 @@
-"use client";
-import { posthog } from "@rallly/posthog/client";
-import { usePathname, useSearchParams } from "next/navigation";
-import { useEffect } from "react";
-
-export function PostHogPageView() {
- const pathname = usePathname();
- const searchParams = useSearchParams();
- useEffect(() => {
- // Track pageviews
- if (pathname) {
- let url = window.origin + pathname;
- if (searchParams?.toString()) {
- url = `${url}?${searchParams.toString()}`;
- }
- posthog.capture("$pageview", {
- $current_url: url,
- });
- }
- }, [pathname, searchParams]);
-
- return null;
-}
diff --git a/apps/web/src/app/[locale]/layout.tsx b/apps/web/src/app/[locale]/layout.tsx
index 1cb503cb5..49f18e253 100644
--- a/apps/web/src/app/[locale]/layout.tsx
+++ b/apps/web/src/app/[locale]/layout.tsx
@@ -19,7 +19,6 @@ import { FeatureFlagsProvider } from "@/lib/feature-flags/client";
import { featureFlagConfig } from "@/lib/feature-flags/config";
import { ThemeProvider } from "@/lib/theme";
import { TRPCProvider } from "@/trpc/client/provider";
-import { PostHogPageView } from "../posthog-page-view";
const inter = Inter({
subsets: ["latin"],
@@ -81,7 +80,6 @@ export default async function Root({
<TRPCProvider>
<LazyMotion features={domAnimation}>
<SkipNavLink />
- <PostHogPageView />
<TimeZoneSync>
<TooltipProvider>{children}</TooltipProvider>
</TimeZoneSync>
diff --git a/apps/web/src/app/posthog-page-view.tsx b/apps/web/src/app/posthog-page-view.tsx
deleted file mode 100644
index ad195a760..000000000
--- a/apps/web/src/app/posthog-page-view.tsx
+++ /dev/null
@@ -1,23 +0,0 @@
-"use client";
-import { posthog } from "@rallly/posthog/client";
-import { usePathname, useSearchParams } from "next/navigation";
-import { useEffect } from "react";
-
-export function PostHogPageView() {
- const pathname = usePathname();
- const searchParams = useSearchParams();
- useEffect(() => {
- // Track pageviews
- if (pathname) {
- let url = window.origin + pathname;
- if (searchParams?.toString()) {
- url = `${url}?${searchParams.toString()}`;
- }
- posthog.capture("$pageview", {
- $current_url: url,
- });
- }
- }, [pathname, searchParams]);
-
- return null;
-}
diff --git a/packages/posthog/src/client.ts b/packages/posthog/src/client.ts
index 233a198ba..925f4773e 100644
--- a/packages/posthog/src/client.ts
+++ b/packages/posthog/src/client.ts
@@ -13,7 +13,7 @@ if (typeof window !== "undefined" && process.env.NEXT_PUBLIC_POSTHOG_API_KEY) {
debug: false,
api_host: process.env.NEXT_PUBLIC_POSTHOG_API_HOST,
ui_host: process.env.NEXT_PUBLIC_POSTHOG_UI_HOST,
- capture_pageview: false,
+ capture_pageview: "history_change",
capture_pageleave: true,
enable_heatmaps: false,
persistence: "cookie",