Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

🐛 Fix doubled "v" prefix on the control panel version tile (#2887)

Luke Vella3cd056ab66ac
diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml
index 43e1f9ff0..6cc0260fa 100644
--- a/.github/workflows/docker-image.yml
+++ b/.github/workflows/docker-image.yml
@@ -87,6 +87,16 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
+ # -----------------------------------------------------------------
+ # Resolve App Version
+ # Purpose: Strip the leading "v" from the release tag so the app
+ # reports an unprefixed version, matching the value
+ # produced by scripts/inject-version.js.
+ # -----------------------------------------------------------------
+ - name: Resolve App Version
+ id: version
+ run: echo "app_version=${GITHUB_REF_NAME#v}" | tee -a $GITHUB_OUTPUT
+
- name: Build and Push Multi-Arch Image
id: build
uses: docker/build-push-action@v5
@@ -98,7 +108,7 @@ jobs:
type=image,"name=${{ env.DOCKER_REGISTRY }}/${{ env.DOCKER_IMAGE_NAME }}",
push-by-digest=true,name-canonical=true,push=true
build-args: |
- APP_VERSION=${{ github.ref_name }}
+ APP_VERSION=${{ steps.version.outputs.app_version }}
SELF_HOSTED=true
# -----------------------------------------------------------------
diff --git a/apps/web/src/app/[locale]/control-panel/version-tile.tsx b/apps/web/src/app/[locale]/control-panel/version-tile.tsx
index a18364ae0..5d8789416 100644
--- a/apps/web/src/app/[locale]/control-panel/version-tile.tsx
+++ b/apps/web/src/app/[locale]/control-panel/version-tile.tsx
@@ -43,7 +43,9 @@ export function VersionTile() {
<PageIcon>
<DownloadIcon />
</PageIcon>
- <TileTitle>{`v${appVersion ?? "unknown"}`}</TileTitle>
+ <TileTitle>
+ {appVersion ? `v${appVersion.replace(/^v/, "")}` : "unknown"}
+ </TileTitle>
<TileDescription>
<Suspense fallback={<Skeleton className="h-4 w-24" />}>
<UpdateStatus />