Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

👷 Avoid skipping linting and type check (#1145)

Luke Vella5f11191fe92c
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index dad2d983f..d1af53730 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -12,27 +12,9 @@ concurrency:
cancel-in-progress: true
jobs:
- changes:
- name: Check for changes
- runs-on: ubuntu-latest
- permissions:
- pull-requests: read
- outputs:
- has-files-requiring-all-checks: ${{ steps.filter.outputs.has-files-requiring-all-checks }}
- steps:
- - uses: actions/checkout@v4
- - uses: dorny/paths-filter@v3
- id: filter
- with:
- filters: |
- has-files-requiring-all-checks:
- - "!(**.md|.github)"
-
type-check:
name: Type check
runs-on: ubuntu-latest
- needs: changes
- if: ${{ needs.changes.outputs.has-files-requiring-all-checks == 'true' }}
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-node
@@ -44,8 +26,6 @@ jobs:
linting:
name: Linting
runs-on: ubuntu-latest
- needs: changes
- if: ${{ needs.changes.outputs.has-files-requiring-all-checks == 'true' }}
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-node
@@ -56,7 +36,6 @@ jobs:
unit-tests:
name: Unit tests
- needs: changes
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
@@ -69,7 +48,6 @@ jobs:
# Label of the container job
integration-tests:
name: Integration tests
- needs: changes
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4