Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

🐛 Send the review request email from [email protected] (#3634)

Luke Vella6aeb23893dad
diff --git a/apps/web/src/features/review-request/constants.ts b/apps/web/src/features/review-request/constants.ts
index b813ec8de..b45fb5b01 100644
--- a/apps/web/src/features/review-request/constants.ts
+++ b/apps/web/src/features/review-request/constants.ts
@@ -4,6 +4,13 @@ import { isSelfHosted } from "@/lib/constants";
// through the README and the license email instead
export const isReviewRequestEnabled = !isSelfHosted;
+// The email is a personal note from the founder, so it comes from a person
+// who reads the replies rather than the no-reply address
+export const reviewRequestSender = {
+ name: "Luke from Rallly",
+ address: "[email protected]",
+};
+
// Long enough that the email reads as a note rather than a receipt for the
// finalize click, short enough that the booking is still fresh
export const reviewRequestEmailDelayMs = 60 * 60_000;
diff --git a/apps/web/src/features/review-request/mutations.ts b/apps/web/src/features/review-request/mutations.ts
index d0b268558..12a752926 100644
--- a/apps/web/src/features/review-request/mutations.ts
+++ b/apps/web/src/features/review-request/mutations.ts
@@ -5,7 +5,6 @@ import { sendReviewRequestEmail } from "@rallly/emails/templates/review-request"
import { createLogger } from "@rallly/logger";
import { Effect } from "effect";
import { getInstanceBranding } from "@/emails/branding";
-import { env } from "@/env";
import { queueEmails } from "@/features/email-queue/mutations";
import {
QueuedEmailFailed,
@@ -13,7 +12,11 @@ import {
} from "@/features/email-queue/service";
import { isFeatureEnabled } from "@/lib/feature-flags/server";
import { track } from "@/lib/posthog";
-import { reviewRequestEmailDelayMs, reviewSites } from "./constants";
+import {
+ reviewRequestEmailDelayMs,
+ reviewRequestSender,
+ reviewSites,
+} from "./constants";
import { countFinalizedPolls, getReviewRequestRecipient } from "./data";
import {
getFirstName,
@@ -126,8 +129,7 @@ export const sendReviewRequest = Effect.fn("reviewRequest.sendReviewRequest")(
to: user.email,
locale: user.locale ?? undefined,
branding,
- // Replies go to a person: the email invites them.
- replyTo: env.SUPPORT_EMAIL,
+ from: reviewRequestSender,
props: {
firstName: getFirstName(user.name),
siteName: reviewSites[site].name,