Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

✨ Show pinging indicator when there are invisible options (#2036)

Luke Vella71ecd045a07c
diff --git a/apps/web/package.json b/apps/web/package.json
index 267699126..928c802c7 100644
--- a/apps/web/package.json
+++ b/apps/web/package.json
@@ -95,7 +95,6 @@
"react-hook-form-persist": "^3.0.0",
"react-i18next": "^15.5.1",
"react-image-crop": "^11.0.10",
- "react-remove-scroll": "^2.5.6",
"react-use": "^17.6.0",
"smoothscroll-polyfill": "^0.4.4",
"spacetime": "^7.4.7",
diff --git a/apps/web/src/components/poll/desktop-poll.tsx b/apps/web/src/components/poll/desktop-poll.tsx
index 0184b8049..7395fbae3 100644
--- a/apps/web/src/components/poll/desktop-poll.tsx
+++ b/apps/web/src/components/poll/desktop-poll.tsx
@@ -13,7 +13,6 @@ import {
Users2Icon,
} from "lucide-react";
import * as React from "react";
-import { RemoveScroll } from "react-remove-scroll";
import { useMeasure, useScroll } from "react-use";
import useClickAway from "react-use/lib/useClickAway";
@@ -93,7 +92,10 @@ const DesktopPoll: React.FunctionComponent = () => {
const [measureRef, { height }] = useMeasure<HTMLDivElement>();
+ const [didScroll, setDidScroll] = React.useState(false);
+
const goToNextPage = () => {
+ setDidScroll(true);
if (scrollRef.current) {
scrollRef.current.scrollLeft += 235;
}
@@ -168,6 +170,7 @@ const DesktopPoll: React.FunctionComponent = () => {
<Tooltip>
<TooltipTrigger asChild>
<Button
+ className="relative"
variant="ghost"
size="icon"
disabled={Boolean(
@@ -182,6 +185,12 @@ const DesktopPoll: React.FunctionComponent = () => {
<Icon>
<ArrowRightIcon />
</Icon>
+ {!didScroll ? (
+ <span className="-top-0.5 -right-0.5 absolute flex size-2">
+ <span className="absolute top-0 right-0 inline-flex h-full w-full animate-ping rounded-full bg-rose-400 opacity-75" />
+ <span className="relative inline-flex size-2 rounded-full bg-rose-500" />
+ </span>
+ ) : null}
</Button>
</TooltipTrigger>
<TooltipContent>
@@ -210,7 +219,7 @@ const DesktopPoll: React.FunctionComponent = () => {
</TooltipContent>
</Tooltip>
) : (
- <Tooltip>
+ <Tooltip delayDuration={0}>
<TooltipTrigger asChild>
<Button
variant="ghost"
@@ -293,8 +302,12 @@ const DesktopPoll: React.FunctionComponent = () => {
)}
/>
- <RemoveScroll
- enabled={expanded}
+ <div
+ onScroll={() => {
+ if (!didScroll) {
+ setDidScroll(true);
+ }
+ }}
ref={scrollRef}
className={cn(
"scrollbar-thin hover:scrollbar-thumb-gray-400 scrollbar-thumb-gray-300 scrollbar-track-gray-100 relative z-10 flex-grow overflow-auto scroll-smooth",
@@ -374,7 +387,7 @@ const DesktopPoll: React.FunctionComponent = () => {
</Button>
</div>
) : null}
- </RemoveScroll>
+ </div>
</div>
) : (
<EmptyState className="p-16">
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 848a52971..2f6270d36 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -80,7 +80,7 @@ importers:
version: 8.1.0([email protected])
'@vercel/analytics':
specifier: ^1.5.0
dayjs:
specifier: ^1.11.13
version: 1.11.13
@@ -119,7 +119,7 @@ importers:
next-seo:
specifier: ^6.1.0
react:
specifier: ^19.1.0
version: 19.1.0
@@ -400,9 +400,6 @@ importers:
react-image-crop:
specifier: ^11.0.10
version: 11.0.10([email protected])
- react-remove-scroll:
- specifier: ^2.5.6
- version: 2.6.3(@types/[email protected])([email protected])
react-use:
specifier: ^17.6.0
@@ -14707,7 +14704,7 @@ snapshots:
dependencies:
crypto-js: 4.2.0
optionalDependencies:
react: 19.1.0
@@ -18095,7 +18092,7 @@ snapshots:
react: 19.1.0
react-dom: 19.1.0([email protected])
dependencies:
react: 19.1.0