Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

♻️ Replace events server action with tRPC mutation (RAL-1024) (#2246)

Luke Vella9a817535682e
diff --git a/apps/web/src/features/scheduled-event/actions.ts b/apps/web/src/features/scheduled-event/actions.ts
deleted file mode 100644
index 44c907f76..000000000
--- a/apps/web/src/features/scheduled-event/actions.ts
+++ /dev/null
@@ -1,134 +0,0 @@
-"use server";
-import { subject } from "@casl/ability";
-import { prisma } from "@rallly/database";
-import * as z from "zod";
-import { AppError } from "@/lib/errors";
-import { spaceActionClient } from "@/lib/safe-action/server";
-import { getEmailClient } from "@/utils/emails";
-import { createIcsEvent } from "@/utils/ics";
-import { formatEventDateTime } from "./utils";
-
-export const cancelEventAction = spaceActionClient
- .metadata({ actionName: "cancel_event" })
- .inputSchema(
- z.object({
- eventId: z.string(),
- }),
- )
- .action(async ({ ctx, parsedInput }) => {
- const event = await prisma.scheduledEvent.findUnique({
- where: {
- id: parsedInput.eventId,
- },
- });
-
- if (!event) {
- throw new AppError({
- code: "NOT_FOUND",
- message: "Event not found",
- });
- }
-
- if (
- ctx.getMemberAbility().cannot("cancel", subject("ScheduledEvent", event))
- ) {
- throw new AppError({
- code: "UNAUTHORIZED",
- message: "You do not have permission to cancel this event",
- });
- }
-
- const updatedEvent = await prisma.scheduledEvent.update({
- where: {
- id: parsedInput.eventId,
- },
- data: {
- status: "canceled",
- sequence: {
- increment: 1,
- },
- },
- include: {
- invites: true,
- },
- });
-
- const cancelEvent = createIcsEvent({
- uid: updatedEvent.uid,
- sequence: updatedEvent.sequence,
- title: updatedEvent.title,
- description: updatedEvent.description ?? undefined,
- location: updatedEvent.location ?? undefined,
- start: updatedEvent.start,
- end: updatedEvent.end,
- allDay: updatedEvent.allDay,
- timeZone: updatedEvent.timeZone ?? undefined,
- organizer: {
- name: ctx.user.name,
- email: ctx.user.email,
- },
- attendees: updatedEvent.invites.map((invite) => ({
- name: invite.inviteeName,
- email: invite.inviteeEmail,
- })),
- method: "cancel",
- status: "CANCELLED",
- });
-
- if (cancelEvent.error) {
- throw new AppError({
- code: "INTERNAL_SERVER_ERROR",
- message: `Failed to generate cancellation ICS: ${cancelEvent.error.message}`,
- });
- }
-
- if (!cancelEvent.value) {
- throw new AppError({
- code: "INTERNAL_SERVER_ERROR",
- message: "Failed to generate cancellation ICS",
- });
- }
-
- // notify attendees
- const attendees = await prisma.scheduledEventInvite.findMany({
- where: {
- scheduledEventId: parsedInput.eventId,
- },
- select: {
- inviteeEmail: true,
- inviteeName: true,
- inviteeTimeZone: true,
- status: true,
- },
- });
-
- for (const attendee of attendees) {
- if (attendee.status !== "declined") {
- const { day, dow, date, time } = formatEventDateTime({
- start: event.start,
- end: event.end,
- allDay: event.allDay,
- timeZone: event.timeZone,
- inviteeTimeZone: attendee.inviteeTimeZone,
- });
-
- const emailClient = await getEmailClient();
- emailClient.queueTemplate("EventCanceledEmail", {
- to: attendee.inviteeEmail,
- props: {
- title: event.title,
- hostName: ctx.user.name,
- day,
- dow,
- date,
- time,
- },
- icalEvent: {
- filename: "cancel.ics",
- method: "cancel",
- content: cancelEvent.value,
- },
- });
- }
- }
- });
diff --git a/apps/web/src/features/scheduled-event/components/scheduled-event-list.tsx b/apps/web/src/features/scheduled-event/components/scheduled-event-list.tsx
index 3b6eabda6..8103953c6 100644
--- a/apps/web/src/features/scheduled-event/components/scheduled-event-list.tsx
+++ b/apps/web/src/features/scheduled-event/components/scheduled-event-list.tsx
@@ -26,9 +26,8 @@ import { MoreHorizontalIcon } from "lucide-react";
import { OptimizedAvatarImage } from "@/components/optimized-avatar-image";
import { StackedList } from "@/components/stacked-list";
import { Trans } from "@/i18n/client";
-import { useSafeAction } from "@/lib/safe-action/client";
import { FormattedDateTime } from "@/lib/timezone/client/formatted-date-time";
-import { cancelEventAction } from "../actions";
+import { trpc } from "@/trpc/client";
export const ScheduledEventList = StackedList;
@@ -54,7 +53,7 @@ export function ScheduledEventListItem({
createdBy: { name: string; image?: string };
}) {
const dialog = useDialog();
- const cancelEvent = useSafeAction(cancelEventAction, {
+ const cancelEvent = trpc.events.cancel.useMutation({
onSuccess: () => {
dialog.dismiss();
},
@@ -201,9 +200,9 @@ export function ScheduledEventListItem({
</DialogClose>
<Button
variant="destructive"
- loading={cancelEvent.isExecuting}
+ loading={cancelEvent.isPending}
onClick={() =>
- cancelEvent.executeAsync({
+ cancelEvent.mutate({
eventId,
})
}
diff --git a/apps/web/src/features/space/member/ability.ts b/apps/web/src/features/space/member/ability.ts
index 6c8a44af1..d5defbf28 100644
--- a/apps/web/src/features/space/member/ability.ts
+++ b/apps/web/src/features/space/member/ability.ts
@@ -66,6 +66,10 @@ function defineSpaceMemberRules(
) {
const { can } = builder;
+ can("read", "ScheduledEvent", {
+ spaceId: space.id,
+ });
+
can("cancel", "ScheduledEvent", {
spaceId: space.id,
userId: user.id,
diff --git a/apps/web/src/trpc/routers/events.ts b/apps/web/src/trpc/routers/events.ts
index 3da51ac4c..b60074820 100644
--- a/apps/web/src/trpc/routers/events.ts
+++ b/apps/web/src/trpc/routers/events.ts
@@ -1,5 +1,12 @@
+import { subject } from "@casl/ability";
+import { prisma } from "@rallly/database";
+import { TRPCError } from "@trpc/server";
import * as z from "zod";
import { getEventsChronological } from "@/features/scheduled-event/data";
+import { formatEventDateTime } from "@/features/scheduled-event/utils";
+import { defineAbilityForMember } from "@/features/space/member/ability";
+import { getEmailClient } from "@/utils/emails";
+import { createIcsEvent } from "@/utils/ics";
import { router, spaceProcedure } from "../trpc";
export const events = router({
@@ -39,4 +46,119 @@ export const events = router({
total: result.total,
};
}),
+
+ cancel: spaceProcedure
+ .input(z.object({ eventId: z.string() }))
+ .mutation(async ({ ctx, input }) => {
+ const memberAbility = defineAbilityForMember({
+ user: ctx.user,
+ space: ctx.space,
+ });
+
+ const event = await prisma.scheduledEvent.findFirst({
+ where: { id: input.eventId, spaceId: ctx.space.id },
+ });
+
+ if (!event) {
+ throw new TRPCError({
+ code: "NOT_FOUND",
+ message: "Event not found",
+ });
+ }
+
+ if (memberAbility.cannot("cancel", subject("ScheduledEvent", event))) {
+ throw new TRPCError({
+ code: "FORBIDDEN",
+ message: "You do not have permission to cancel this event",
+ });
+ }
+
+ // Atomically update only if not already canceled to ensure idempotency
+ const { count } = await prisma.scheduledEvent.updateMany({
+ where: {
+ id: input.eventId,
+ status: { not: "canceled" },
+ },
+ data: {
+ status: "canceled",
+ sequence: { increment: 1 },
+ },
+ });
+
+ // Already canceled — skip notifications
+ if (count === 0) {
+ return;
+ }
+
+ const updatedEvent = await prisma.scheduledEvent.findUniqueOrThrow({
+ where: { id: input.eventId },
+ include: { invites: true },
+ });
+
+ const cancelEvent = createIcsEvent({
+ uid: updatedEvent.uid,
+ sequence: updatedEvent.sequence,
+ title: updatedEvent.title,
+ description: updatedEvent.description ?? undefined,
+ location: updatedEvent.location ?? undefined,
+ start: updatedEvent.start,
+ end: updatedEvent.end,
+ allDay: updatedEvent.allDay,
+ timeZone: updatedEvent.timeZone ?? undefined,
+ organizer: {
+ name: ctx.user.name,
+ email: ctx.user.email,
+ },
+ attendees: updatedEvent.invites.map((invite) => ({
+ name: invite.inviteeName,
+ email: invite.inviteeEmail,
+ })),
+ method: "cancel",
+ status: "CANCELLED",
+ });
+
+ if (cancelEvent.error) {
+ throw new TRPCError({
+ code: "INTERNAL_SERVER_ERROR",
+ message: `Failed to generate cancellation ICS: ${cancelEvent.error.message}`,
+ });
+ }
+
+ if (!cancelEvent.value) {
+ throw new TRPCError({
+ code: "INTERNAL_SERVER_ERROR",
+ message: "Failed to generate cancellation ICS",
+ });
+ }
+
+ for (const invite of updatedEvent.invites) {
+ if (invite.status !== "declined") {
+ const { day, dow, date, time } = formatEventDateTime({
+ start: updatedEvent.start,
+ end: updatedEvent.end,
+ allDay: updatedEvent.allDay,
+ timeZone: updatedEvent.timeZone,
+ inviteeTimeZone: invite.inviteeTimeZone,
+ });
+
+ const emailClient = await getEmailClient();
+ emailClient.queueTemplate("EventCanceledEmail", {
+ to: invite.inviteeEmail,
+ props: {
+ title: updatedEvent.title,
+ hostName: ctx.user.name,
+ day,
+ dow,
+ date,
+ time,
+ },
+ icalEvent: {
+ filename: "cancel.ics",
+ method: "cancel",
+ content: cancelEvent.value,
+ },
+ });
+ }
+ }
+ }),
});