Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

♿️ Add input autocomplete tokens and poll header scopes (WCAG 1.3.5 / 1.3.1) (#2502)

Luke Vellad8c7840b7953
diff --git a/apps/web/src/app/[locale]/(auth)/forgot-password/components/forgot-password-form.tsx b/apps/web/src/app/[locale]/(auth)/forgot-password/components/forgot-password-form.tsx
index 5c558eff3..0b051f3a8 100644
--- a/apps/web/src/app/[locale]/(auth)/forgot-password/components/forgot-password-form.tsx
+++ b/apps/web/src/app/[locale]/(auth)/forgot-password/components/forgot-password-form.tsx
@@ -91,6 +91,7 @@ export function ForgotPasswordForm() {
{...field}
large
type="email"
+ autoComplete="email"
disabled={formState.isSubmitting}
autoFocus={true}
placeholder={t("emailPlaceholder")}
diff --git a/apps/web/src/app/[locale]/(auth)/login/components/login-email-form.tsx b/apps/web/src/app/[locale]/(auth)/login/components/login-email-form.tsx
index f7d71b4aa..62e5c70fd 100644
--- a/apps/web/src/app/[locale]/(auth)/login/components/login-email-form.tsx
+++ b/apps/web/src/app/[locale]/(auth)/login/components/login-email-form.tsx
@@ -144,6 +144,7 @@ export function LoginWithEmailForm() {
{...field}
large
type="text"
+ autoComplete="username"
disabled={formState.isSubmitting}
autoFocus={true}
placeholder={t("emailPlaceholder")}
@@ -184,6 +185,7 @@ export function LoginWithEmailForm() {
autoFocus={true}
large
type="password"
+ autoComplete="current-password"
disabled={form.formState.isSubmitting}
placeholder="••••••••"
{...field}
diff --git a/apps/web/src/app/[locale]/(auth)/register/components/register-name-form.tsx b/apps/web/src/app/[locale]/(auth)/register/components/register-name-form.tsx
index eaffce62f..f5288fcd0 100644
--- a/apps/web/src/app/[locale]/(auth)/register/components/register-name-form.tsx
+++ b/apps/web/src/app/[locale]/(auth)/register/components/register-name-form.tsx
@@ -137,6 +137,7 @@ export function RegisterNameForm() {
<Input
{...field}
large
+ autoComplete="name"
data-1p-ignore
placeholder={t("namePlaceholder")}
disabled={form.formState.isSubmitting}
@@ -159,6 +160,8 @@ export function RegisterNameForm() {
<FormControl>
<Input
large
+ type="email"
+ autoComplete="email"
placeholder={t("emailPlaceholder")}
disabled={form.formState.isSubmitting}
{...field}
@@ -179,6 +182,7 @@ export function RegisterNameForm() {
<FormControl>
<PasswordInput
large
+ autoComplete="new-password"
placeholder="••••••••"
disabled={form.formState.isSubmitting}
{...field}
diff --git a/apps/web/src/app/[locale]/(auth)/reset-password/components/reset-password-form.tsx b/apps/web/src/app/[locale]/(auth)/reset-password/components/reset-password-form.tsx
index abf8639c3..04eecf961 100644
--- a/apps/web/src/app/[locale]/(auth)/reset-password/components/reset-password-form.tsx
+++ b/apps/web/src/app/[locale]/(auth)/reset-password/components/reset-password-form.tsx
@@ -92,6 +92,7 @@ export function ResetPasswordForm() {
<PasswordInput
{...field}
large
+ autoComplete="new-password"
disabled={formState.isSubmitting}
autoFocus={true}
placeholder="••••••••"
diff --git a/apps/web/src/app/[locale]/(space)/settings/profile/profile-email-address.tsx b/apps/web/src/app/[locale]/(space)/settings/profile/profile-email-address.tsx
index 70fb7ca78..ec1d8ff70 100644
--- a/apps/web/src/app/[locale]/(space)/settings/profile/profile-email-address.tsx
+++ b/apps/web/src/app/[locale]/(space)/settings/profile/profile-email-address.tsx
@@ -225,7 +225,12 @@ export const ProfileEmailAddress = () => {
<Trans i18nKey="email" />
</FormLabel>
<FormControl>
- <Input disabled={form.formState.isSubmitting} {...field} />
+ <Input
+ type="email"
+ autoComplete="email"
+ disabled={form.formState.isSubmitting}
+ {...field}
+ />
</FormControl>
<FormMessage />
</FormItem>
diff --git a/apps/web/src/app/[locale]/(space)/settings/security/components/change-password-form.tsx b/apps/web/src/app/[locale]/(space)/settings/security/components/change-password-form.tsx
index 124afa496..649a1f9cb 100644
--- a/apps/web/src/app/[locale]/(space)/settings/security/components/change-password-form.tsx
+++ b/apps/web/src/app/[locale]/(space)/settings/security/components/change-password-form.tsx
@@ -107,6 +107,7 @@ export function ChangePasswordForm() {
<FormControl>
<PasswordInput
{...field}
+ autoComplete="current-password"
disabled={formState.isSubmitting}
placeholder="••••••••"
/>
@@ -127,6 +128,7 @@ export function ChangePasswordForm() {
<FormControl>
<PasswordInput
{...field}
+ autoComplete="new-password"
disabled={formState.isSubmitting}
placeholder="••••••••"
/>
diff --git a/apps/web/src/app/[locale]/e/[id]/components/registration-form.tsx b/apps/web/src/app/[locale]/e/[id]/components/registration-form.tsx
index f52a943cc..e73a7ff5d 100644
--- a/apps/web/src/app/[locale]/e/[id]/components/registration-form.tsx
+++ b/apps/web/src/app/[locale]/e/[id]/components/registration-form.tsx
@@ -75,6 +75,7 @@ export function RegistrationForm({
<FormControl>
<Input
autoFocus
+ autoComplete="name"
disabled={form.formState.isSubmitting}
placeholder={t("namePlaceholder", {
defaultValue: "Jessie Smith",
@@ -96,6 +97,7 @@ export function RegistrationForm({
<FormControl>
<Input
type="email"
+ autoComplete="email"
disabled={form.formState.isSubmitting}
placeholder={t("emailPlaceholder", {
defaultValue: "[email protected]",
diff --git a/apps/web/src/components/poll/desktop-poll/poll-header.tsx b/apps/web/src/components/poll/desktop-poll/poll-header.tsx
index 5d505b4ef..2a37a3d1d 100644
--- a/apps/web/src/components/poll/desktop-poll/poll-header.tsx
+++ b/apps/web/src/components/poll/desktop-poll/poll-header.tsx
@@ -111,6 +111,7 @@ const PollHeader = () => {
{monthGroups.map((group) => (
<th
key={`${group.month} ${group.year}`}
+ scope="colgroup"
colSpan={group.count}
style={{ height: monthRowHeight }}
className={cn(
@@ -128,6 +129,7 @@ const PollHeader = () => {
{dayGroups.map((group) => (
<th
key={`${group.year}-${group.month}-${group.day}`}
+ scope="colgroup"
colSpan={group.count}
style={{ height: dayRowHeight, top: monthRowHeight }}
className="sticky z-10 border-l bg-background"
@@ -149,6 +151,7 @@ const PollHeader = () => {
return (
<th
key={option.optionId}
+ scope="col"
style={{ minWidth: 80, top: scoreRowTop }}
className="sticky z-20 border-b border-l bg-background pb-2.5 align-top"
>