Skip to content

Rallly is an open-source scheduling and collaboration tool designed to make organizing events and meetings easier.

🔒️ Harden name validation (#1629)

Luke Vellaf3c64f399e5b
diff --git a/apps/web/src/app/[locale]/(auth)/register/components/schema.ts b/apps/web/src/app/[locale]/(auth)/register/components/schema.ts
index 30d1d2dd3..4a32a83a9 100644
--- a/apps/web/src/app/[locale]/(auth)/register/components/schema.ts
+++ b/apps/web/src/app/[locale]/(auth)/register/components/schema.ts
@@ -1,7 +1,11 @@
import { z } from "zod";
+import { isValidName } from "@/utils/is-valid-name";
+
export const registerNameFormSchema = z.object({
- name: z.string().min(1).max(100),
+ name: z.string().trim().min(1).max(100).refine(isValidName, {
+ message: "Please enter a valid name, not a URL, email, or phone number",
+ }),
email: z.string().email(),
});
diff --git a/apps/web/src/trpc/routers/auth.ts b/apps/web/src/trpc/routers/auth.ts
index 1c5f7d55a..d7d5b3149 100644
--- a/apps/web/src/trpc/routers/auth.ts
+++ b/apps/web/src/trpc/routers/auth.ts
@@ -8,6 +8,7 @@ import { isEmailBlocked } from "@/auth/helpers/is-email-blocked";
import { mergeGuestsIntoUser } from "@/auth/helpers/merge-user";
import { isTemporaryEmail } from "@/auth/helpers/temp-email-domains";
import { getEmailClient } from "@/utils/emails";
+import { isValidName } from "@/utils/is-valid-name";
import { createToken, decryptToken } from "@/utils/session";
import { createRateLimitMiddleware, publicProcedure, router } from "../trpc";
@@ -33,7 +34,7 @@ export const auth = router({
.use(createRateLimitMiddleware("request_registration", 5, "1 m"))
.input(
z.object({
- name: z.string().min(1).max(100),
+ name: z.string().trim().min(1).max(100).refine(isValidName),
email: z.string().email(),
}),
)
diff --git a/apps/web/src/utils/is-valid-name.ts b/apps/web/src/utils/is-valid-name.ts
new file mode 100644
index 000000000..a71f8203f
--- /dev/null
+++ b/apps/web/src/utils/is-valid-name.ts
@@ -0,0 +1,32 @@
+/**
+ * Checks if a string contains contact information like URLs, email addresses, or phone numbers
+ * Returns true if the string is a valid personal/company name (no contact info)
+ * Returns false if the string contains contact information
+ */
+export function isValidName(value: string) {
+ // Check for URL patterns
+ // First check for common prefixes to avoid false positives with names like "Dr. Smith"
+ if (/(https?:\/\/|www\.|http:|https:)/.test(value)) {
+ return false;
+ }
+
+ // Common TLDs that would indicate a URL
+ const commonTLDs = /\.(com|org|net|edu|gov|io|co|me|app|dev|info)(\s|$|\/)/i;
+ if (commonTLDs.test(value)) {
+ return false;
+ }
+
+ // Check for email patterns
+ const emailPattern = /.+@.+\..+/i;
+ if (emailPattern.test(value)) {
+ return false;
+ }
+
+ // Check for phone number patterns (various formats)
+ const phonePattern = /\+?[\d\s\(\)\-\.]{7,}/;
+ if (phonePattern.test(value)) {
+ return false;
+ }
+
+ return true;
+}