"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files
Go azure-blobazure-blob-storageazure-filesbackblaze-b2cloud-storagedropboxencryptionftpfuse-filesystemgogolanggoogle-cloud-storagegoogle-driveonedriveopenstack-swiftrclones3sftpsyncwebdav
lib/http: fix race between Serve() and Shutdown()
Nick Craig-Wood084e35c49dab
diff --git a/lib/http/server.go b/lib/http/server.goindex 98f4f5ca7..f098d7593 100644--- a/lib/http/server.go+++ b/lib/http/server.go@@ -229,7 +229,8 @@ type Server struct {cfg Configtemplate *TemplateConfightmlTemplate *template.Template- usingAuth bool // set if we are using auth middleware+ usingAuth bool // set if we are using auth middleware+ mu sync.Mutex // mutex protects RW variables belowatexitHandle atexit.FnHandle}@@ -524,7 +525,9 @@ func (s *Server) Serve() {go ii.serve(&s.wg)}// Install an atexit handler to shutdown gracefully+ s.mu.Lock()s.atexitHandle = atexit.Register(func() { _ = s.Shutdown() })+ s.mu.Unlock()}// Wait blocks while the server is serving requests@@ -543,10 +546,12 @@ const gracefulShutdownTime = 10 * time.Second// Shutdown gracefully shuts down the serverfunc (s *Server) Shutdown() error {// Stop the atexit handler+ s.mu.Lock()if s.atexitHandle != nil {atexit.Unregister(s.atexitHandle)s.atexitHandle = nil}+ s.mu.Unlock()for _, ii := range s.instances {expiry := time.Now().Add(gracefulShutdownTime)ctx, cancel := context.WithDeadline(context.Background(), expiry)