Skip to content

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files

serve ftp: add test for auth proxy configured via rc GHSA-p569-5gjg-9cmj CVE-PENDING

Nick Craig-Wood212178eea1a6
diff --git a/cmd/serve/ftp/ftp_test.go b/cmd/serve/ftp/ftp_test.go
index df6655ac5..ef897c58f 100644
--- a/cmd/serve/ftp/ftp_test.go
+++ b/cmd/serve/ftp/ftp_test.go
@@ -21,6 +21,7 @@ import (
"github.com/rclone/rclone/lib/israce"
"github.com/rclone/rclone/vfs/vfscommon"
"github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/require"
)
const (
@@ -100,6 +101,27 @@ func TestCheckPasswd(t *testing.T) {
}
}
+// TestNewServerPerServerAuthProxy checks that a per-server proxyOpt.AuthProxy
+// enables proxy mode even when the process-global proxy.Opt.AuthProxy is empty,
+// which is the normal case when the server is configured via serve/start.
+func TestNewServerPerServerAuthProxy(t *testing.T) {
+ // Ensure the global is empty so we only test the per-server option.
+ assert.Equal(t, "", proxy.Opt.AuthProxy)
+
+ opt := Opt
+ opt.ListenAddr = testHOST + ":" + testPORT
+ opt.PassivePorts = testPASSIVEPORTRANGE
+
+ proxyOpt := proxy.Opt
+ proxyOpt.AuthProxy = "/path/to/auth/proxy"
+
+ d, err := newServer(context.Background(), nil, &opt, &vfscommon.Opt, &proxyOpt)
+ require.NoError(t, err)
+ defer d.provider.Shutdown()
+ assert.True(t, d.provider.IsProxy(), "expected auth proxy to be enabled by per-server option")
+ assert.Nil(t, d.provider.VFS(), "expected no fixed VFS when auth proxy is in use")
+}
+
func TestRc(t *testing.T) {
if israce.Enabled {
t.Skip("Skipping under race detector as underlying library is racy")