Skip to content

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files

ftp: fix incorrect modtime after uploading a file or setting its modtime

Nick Craig-Wood2a91ea8cf270
diff --git a/backend/ftp/ftp.go b/backend/ftp/ftp.go
index 5b73801b0..ce90d3f0f 100644
--- a/backend/ftp/ftp.go
+++ b/backend/ftp/ftp.go
@@ -1235,7 +1235,10 @@ func (o *Object) SetModTime(ctx context.Context, modTime time.Time) error {
path = o.fs.opt.Enc.FromStandardPath(path)
err = c.SetTime(path, modTime.In(time.UTC))
if err == nil && o.info != nil {
- o.info.ModTime = modTime
+ // The server stores modtimes with second precision so
+ // truncate here too to keep the in-memory modtime identical
+ // to the one a fresh listing returns.
+ o.info.ModTime = modTime.Truncate(time.Second)
o.info.precise = true
}
o.fs.putFtpConnection(&c, err)
@@ -1390,9 +1393,12 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op
o.fs.putFtpConnection(&c, nil)
if o.fs.opt.NoCheckUpload {
o.info = &FileInfo{
- Name: o.remote,
- Size: uint64(src.Size()),
- ModTime: src.ModTime(ctx),
+ Name: o.remote,
+ Size: uint64(src.Size()),
+ // The server stores modtimes with second precision so
+ // truncate here too to keep the in-memory modtime
+ // identical to the one a fresh listing returns.
+ ModTime: src.ModTime(ctx).Truncate(time.Second),
precise: true,
IsDir: false,
}