Skip to content

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files

build: disable staticcheck SA4023 to fix lint job timeout

Nick Craig-Wood357c2a2b4453
diff --git a/.golangci.yml b/.golangci.yml
index 5f33d6183..4b5d373d1 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -46,6 +46,11 @@ linters:
- -ST1022
# Disable quickfix checks
- -QF*
+ # Disabled because its dataflow analysis (new in staticcheck
+ # 0.8.0) makes linting large packages more than 10x slower,
+ # which takes the CI lint job past its timeout, and it
+ # produces false positives (eg on operations.Delete).
+ - -SA4023
gocritic:
# With gocritic there are different settings, but since enabled-checks
# and disabled-checks cannot both be set, for full customization the
diff --git a/fs/log/log.go b/fs/log/log.go
index 8f1896633..2de359e05 100644
--- a/fs/log/log.go
+++ b/fs/log/log.go
@@ -291,8 +291,7 @@ func InitLogging() {
// Windows event logging
if Opt.WindowsEventLogLevel != fs.LogLevelOff {
- err := startWindowsEventLog(Handler)
- if err != nil {
+ if err := startWindowsEventLog(Handler); err != nil {
fs.Fatalf(nil, "Failed to start windows event log: %v", err)
}
}