"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files
Go azure-blobazure-blob-storageazure-filesbackblaze-b2cloud-storagedropboxencryptionftpfuse-filesystemgogolanggoogle-cloud-storagegoogle-driveonedriveopenstack-swiftrclones3sftpsyncwebdav
sia: fix corrupted files being created when the source ends early
Nick Craig-Wood5d057549b9fc
diff --git a/backend/sia/sia.go b/backend/sia/sia.goindex 9f4e02bf0..d5f2ae99b 100644--- a/backend/sia/sia.go+++ b/backend/sia/sia.go@@ -24,6 +24,7 @@ import ("github.com/rclone/rclone/fs/hash""github.com/rclone/rclone/lib/encoder""github.com/rclone/rclone/lib/pacer"+ "github.com/rclone/rclone/lib/readers""github.com/rclone/rclone/lib/rest")@@ -176,11 +177,12 @@ func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.Read// Update the object with the contents of the io.Readerfunc (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, options ...fs.OpenOption) (err error) {size := src.Size()+ counter := readers.NewCountingReader(in)var resp *http.Responseopts := rest.Opts{Method: "POST",Path: path.Join("/renter/uploadstream/", o.fs.opt.Enc.FromStandardPath(path.Join(o.fs.root, o.remote))),- Body: in,+ Body: counter,ContentLength: &size,Parameters: url.Values{},}@@ -191,6 +193,14 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, opreturn o.fs.shouldRetry(resp, err)})+ // Check the source supplied the number of bytes it declared+ // otherwise a truncated file would be stored as a good upload.+ // The partially uploaded file is cleaned up by Put which copes+ // with it appearing asynchronously after the failed upload.+ if err == nil && size >= 0 && int64(counter.BytesRead()) != size {+ return fmt.Errorf("expected %d bytes in input, but got %d: %w", size, counter.BytesRead(), io.ErrUnexpectedEOF)+ }+if err == nil {err = o.readMetaData(ctx)}