"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files
Go azure-blobazure-blob-storageazure-filesbackblaze-b2cloud-storagedropboxencryptionftpfuse-filesystemgogolanggoogle-cloud-storagegoogle-driveonedriveopenstack-swiftrclones3sftpsyncwebdav
azurefiles: fix zero padded files being created when the source ends early
Nick Craig-Wood884b28c203c5
diff --git a/backend/azurefiles/azurefiles.go b/backend/azurefiles/azurefiles.goindex d31d6d78f..ce7d89f4c 100644--- a/backend/azurefiles/azurefiles.go+++ b/backend/azurefiles/azurefiles.go@@ -696,11 +696,9 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, op}}- // Measure the size if it is unknown- if sizeUnknown {- counter = readers.NewCountingReader(in)- in = counter- }+ // Count the bytes read so short reads from the source can be detected+ counter = readers.NewCountingReader(in)+ in = counter// Check we have a source MD5 hash...if hashStr, err := src.Hash(ctx, hash.MD5); err == nil && hashStr != "" {@@ -735,6 +733,21 @@ func (o *Object) Update(ctx context.Context, in io.Reader, src fs.ObjectInfo, opif sizeUnknown {// Read the uploaded size - the file will be truncated to that size by updateSizeHashModTimesize = int64(counter.BytesRead())+ } else if bytesRead := int64(counter.BytesRead()); bytesRead != size {+ // The file was created at the declared size so a short source+ // leaves the remainder padded with zeroes+ if isNewlyCreated {+ if _, delErr := fc.Delete(ctx, nil); delErr != nil {+ fs.Errorf(o, "failed to delete partially uploaded file: %v", delErr)+ }+ } else if bytesRead < size {+ // Truncate the file to the bytes actually received so it+ // is not left padded to the declared size with zeroes+ if _, resizeErr := fc.Resize(ctx, bytesRead, nil); resizeErr != nil {+ fs.Errorf(o, "failed to truncate partially updated file: %v", resizeErr)+ }+ }+ return fmt.Errorf("update: expected %d bytes in input, but got %d: %w", size, bytesRead, io.ErrUnexpectedEOF)}if hashUnknown {md5Hash = hasher.Sum(nil)