"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files
Go azure-blobazure-blob-storageazure-filesbackblaze-b2cloud-storagedropboxencryptionftpfuse-filesystemgogolanggoogle-cloud-storagegoogle-driveonedriveopenstack-swiftrclones3sftpsyncwebdav
onedrive: treat non-2xx preauth download as error
ifloppy9a0d7e57dd85
diff --git a/backend/onedrive/onedrive.go b/backend/onedrive/onedrive.goindex 35fada17e..c5c053b29 100644--- a/backend/onedrive/onedrive.go+++ b/backend/onedrive/onedrive.go@@ -2434,7 +2434,7 @@ func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.Readif err != nil {if resp != nil {if virus := resp.Header.Get("X-Virus-Infected"); virus != "" {- err = fmt.Errorf("server reports this file is infected with a virus - use --onedrive-av-override to download anyway: %s: %w", virus, err)+ err = malwareDownloadError(o.fs.opt.AVOverride, fmt.Errorf("%s: %w", virus, err))}}return nil, err@@ -2442,12 +2442,26 @@ func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.Readif redirectReq != nil {err = o.fs.pacer.Call(func() (bool, error) {resp, err = o.fs.unAuth.Do(redirectReq)+ if err != nil {+ return shouldRetry(ctx, resp, err)+ }+ // unAuth.Do does not check status; treat non-2xx as failure so a malware+ // JSON body is not written out as file content.+ if resp.StatusCode < 200 || resp.StatusCode > 299 {+ body, _ := io.ReadAll(io.LimitReader(resp.Body, 512))+ _ = resp.Body.Close()+ err = fmt.Errorf("HTTP error %d (%s) %s", resp.StatusCode, resp.Status, strings.TrimSpace(string(body)))+ if strings.Contains(string(body), "malwareDetected") || resp.Header.Get("X-Virus-Infected") != "" {+ err = malwareDownloadError(o.fs.opt.AVOverride, err)+ }+ return shouldRetry(ctx, resp, err)+ }return shouldRetry(ctx, resp, err)})if err != nil {if resp != nil {if virus := resp.Header.Get("X-Virus-Infected"); virus != "" {- err = fmt.Errorf("server reports this file is infected with a virus - use --onedrive-av-override to download anyway: %s: %w", virus, err)+ err = malwareDownloadError(o.fs.opt.AVOverride, fmt.Errorf("%s: %w", virus, err))}}return nil, err@@ -2461,6 +2475,14 @@ func (o *Object) Open(ctx context.Context, options ...fs.OpenOption) (in io.Readreturn resp.Body, err}+// malwareDownloadError formats an error when the server blocks a malware-flagged file.+func malwareDownloadError(avOverride bool, err error) error {+ if avOverride {+ return fmt.Errorf("server reports this file is infected with a virus: %w (if downloads remain blocked, use application permissions / client_credentials or a tenant admin account)", err)+ }+ return fmt.Errorf("server reports this file is infected with a virus - use --onedrive-av-override to download anyway: %w", err)+}+// createUploadSession creates an upload session for the objectfunc (o *Object) createUploadSession(ctx context.Context, src fs.ObjectInfo, modTime time.Time) (response *api.CreateUploadResponse, metadata fs.Metadata, err error) {opts := o.fs.newOptsCallWithPath(ctx, o.remote, "POST", "/createUploadSession")