Skip to content

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files

s3: fix crash if no UploadId in multipart upload

Nick Craig-Woodc16c22d6e110
diff --git a/backend/s3/s3.go b/backend/s3/s3.go
index d7ca47a77..c0359029e 100644
--- a/backend/s3/s3.go
+++ b/backend/s3/s3.go
@@ -5711,6 +5711,13 @@ func (f *Fs) OpenChunkWriter(ctx context.Context, remote string, src fs.ObjectIn
var mOut *s3.CreateMultipartUploadOutput
err = f.pacer.Call(func() (bool, error) {
mOut, err = f.c.CreateMultipartUploadWithContext(ctx, &mReq)
+ if err == nil {
+ if mOut == nil {
+ err = fserrors.RetryErrorf("internal error: no info from multipart upload")
+ } else if mOut.UploadId == nil {
+ err = fserrors.RetryErrorf("internal error: no UploadId in multpart upload: %#v", *mOut)
+ }
+ }
return f.shouldRetry(ctx, err)
})
if err != nil {