Skip to content

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files

onedrive: fix setting modification time on directories for onedrive Personal

Nick Craig-Woodc64161822d3e
diff --git a/backend/onedrive/api/types.go b/backend/onedrive/api/types.go
index 7fe032c23..ba23a1165 100644
--- a/backend/onedrive/api/types.go
+++ b/backend/onedrive/api/types.go
@@ -133,7 +133,7 @@ type RemoteItemFacet struct {
// FolderFacet groups folder-related data on OneDrive into a single structure
type FolderFacet struct {
- ChildCount int64 `json:"childCount"` // Number of children contained immediately within this container.
+ ChildCount int64 `json:"childCount,omitempty"` // Number of children contained immediately within this container.
}
// HashesType groups different types of hashes into a single structure, for an item on OneDrive.
diff --git a/backend/onedrive/metadata.go b/backend/onedrive/metadata.go
index d6df4dd1e..f81a58188 100644
--- a/backend/onedrive/metadata.go
+++ b/backend/onedrive/metadata.go
@@ -816,15 +816,13 @@ func (f *Fs) MkdirMetadata(ctx context.Context, dir string, metadata fs.Metadata
if err != nil {
return nil, err
}
- info, meta, err = f.createDir(ctx, parentID, dir, leaf, metadata)
+ _, meta, err = f.createDir(ctx, parentID, dir, leaf, metadata)
if err != nil {
return nil, err
}
- if f.driveType != driveTypePersonal {
- // for some reason, OneDrive Business needs this extra step to set modtime, while Personal does not. Seems like a bug...
- fs.Debugf(dir, "setting time %v", meta.mtime)
- info, err = meta.Write(ctx, false)
- }
+ // for some reason, OneDrive Business and Personal needs this extra step to set modtime. Seems like a bug...
+ fs.Debugf(dir, "setting time %v", meta.mtime)
+ info, err = meta.Write(ctx, false)
} else if err == nil {
// Directory exists and needs updating
info, meta, err = f.updateDir(ctx, dirID, dir, metadata)