Skip to content

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files

lib/http: accept the Basic auth scheme in any case

kevincf93478f8755
diff --git a/lib/http/middleware.go b/lib/http/middleware.go
index 0e59c1a71..31c6016ba 100644
--- a/lib/http/middleware.go
+++ b/lib/http/middleware.go
@@ -19,7 +19,7 @@ func parseAuthorization(r *http.Request) (user, pass string, ok bool) {
authHeader := r.Header.Get("Authorization")
if authHeader != "" {
s := strings.SplitN(authHeader, " ", 2)
- if len(s) == 2 && s[0] == "Basic" {
+ if len(s) == 2 && strings.EqualFold(s[0], "Basic") {
b, err := base64.StdEncoding.DecodeString(s[1])
if err == nil {
parts := strings.SplitN(string(b), ":", 2)
diff --git a/lib/http/middleware_test.go b/lib/http/middleware_test.go
index 0b9ada121..510dfff55 100644
--- a/lib/http/middleware_test.go
+++ b/lib/http/middleware_test.go
@@ -767,3 +767,36 @@ func TestMiddlewareResponseHeaders(t *testing.T) {
})
}
}
+
+func TestParseAuthorization(t *testing.T) {
+ for _, test := range []struct {
+ header string
+ user string
+ pass string
+ ok bool
+ }{
+ {"", "", "", false},
+ {"Basic dXNlcjpwYXNz", "user", "pass", true},
+ // The auth scheme is case-insensitive (RFC 7617 section 2, RFC 9110 section 11.1)
+ {"basic dXNlcjpwYXNz", "user", "pass", true},
+ {"BASIC dXNlcjpwYXNz", "user", "pass", true},
+ {"Basic dXNlcjo=", "user", "", true},
+ {"Basic dXNlcg==", "user", "", false},
+ {"Basic !!!", "", "", false},
+ {"Bearer dXNlcjpwYXNz", "", "", false},
+ {"Basicx dXNlcjpwYXNz", "", "", false},
+ } {
+ t.Run(test.header, func(t *testing.T) {
+ r := httptest.NewRequest("GET", "/", nil)
+ if test.header != "" {
+ r.Header.Set("Authorization", test.header)
+ }
+ user, pass, ok := parseAuthorization(r)
+ require.Equal(t, test.ok, ok)
+ if test.ok {
+ require.Equal(t, test.user, user)
+ require.Equal(t, test.pass, pass)
+ }
+ })
+ }
+}