Skip to content

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files

vfs/vfscache/downloaders: kick waiters periodically, not just once

Nick Craig-Woodd2b8b73ea342
diff --git a/vfs/vfscache/downloaders/downloaders.go b/vfs/vfscache/downloaders/downloaders.go
index c4b66783f..495fdf2bf 100644
--- a/vfs/vfscache/downloaders/downloaders.go
+++ b/vfs/vfscache/downloaders/downloaders.go
@@ -117,16 +117,18 @@ func New(ctx context.Context, item Item, opt *vfscommon.Options, remote string,
}
dls.wg.Go(func() {
ticker := time.NewTicker(backgroundKickerInterval)
- select {
- case <-ticker.C:
- err := dls.kickWaiters()
- if err != nil {
- fs.Errorf(dls.src, "vfs cache: failed to kick waiters: %v", err)
+ defer ticker.Stop()
+ for {
+ select {
+ case <-ticker.C:
+ err := dls.kickWaiters()
+ if err != nil {
+ fs.Errorf(dls.src, "vfs cache: failed to kick waiters: %v", err)
+ }
+ case <-ctx.Done():
+ return
}
- case <-ctx.Done():
- break
}
- ticker.Stop()
})
return dls