Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

26.7 KB
Raw Blame
import { createHash } from "node:crypto";
import { writeFile, unlink } from "node:fs/promises";
import { join } from "node:path";
import { expect, it } from "vitest";
import { toolContract } from "../../src/contracts/toolContracts.js";
import {
  modelArtifactSchema,
  type ModelArtifact,
} from "../../src/domain/model/modelArtifact.js";
import {
  modelArtifactSummaryViewResultSchema,
  analysisViewResultSchema,
} from "../../src/domain/analysisView/analysisView.js";
import { createEvidence, parseEvidence } from "../../src/domain/evidence.js";
import { readEvidenceBundle } from "../../src/application/EvidenceBundleFiles.js";
import { connectLocalToolsMcp } from "../fixtures/localToolsMcp.js";
import { parseMcpToolError } from "../fixtures/mcpToolError.js";
import { ggufFixture, safetensorsFixture } from "../fixtures/model/model.js";
import { createTestTempDirectory } from "../fixtures/temporaryDirectory.js";
import { cliTest } from "../support/cli/cliFixture.js";

cliTest(
  "preserves exact large safetensors dimensions while bounding actual offsets",
  async ({ cli }) => {
    const root = await createTestTempDirectory("rea-model-shape-precision-");
    const path = join(root, "empty.safetensors");
    const fixture = safetensorsFixture(
      '{"a":{"dtype":"F32","shape":[0,9007199254740992],"data_offsets":[0,0]},"b":{"dtype":"F32","shape":[18446744073709551615,0],"data_offsets":[0,0]}}',
      Buffer.alloc(0),
    );
    await writeFile(path, fixture.bytes);
    const result = await cli.run({
      arguments: [
        "inspect-model-artifact",
        path,
        "--detail",
        "complete",
        "--hash",
        "full",
        "--json",
      ],
    });
    expect(result.exitCode, result.stderr).toBe(0);
    const report = modelArtifactSchema.parse(
      toolContract("inspect_model_artifact").outputSchema.parse(result.json)
        .normalized_result,
    );
    expect(
      report.tensors.map(
        ({ shape, parameter_count, byte_length, storage_validation }) => ({
          shape,
          parameter_count,
          byte_length,
          storage_validation,
        }),
      ),
    ).toEqual([
      {
        shape: ["0", "9007199254740992"],
        parameter_count: "0",
        byte_length: 0,
        storage_validation: "consistent",
      },
      {
        shape: ["18446744073709551615", "0"],
        parameter_count: "0",
        byte_length: 0,
        storage_validation: "consistent",
      },
    ]);
    expect(report.totals).toMatchObject({
      parameter_count: "0",
      tensor_bytes: 0,
    });
    expect(report.artifact.sha256).toBe(
      createHash("sha256").update(fixture.bytes).digest("hex"),
    );
    const { call } = await connectLocalToolsMcp();
    const response = await call("inspect_model_artifact", {
      path,
      detail: "complete",
      hash: "full",
    });
    expect(response.isError, JSON.stringify(response)).not.toBe(true);
    expect(parseEvidence(response.structuredContent).normalized_result).toEqual(
      report,
    );

    await writeFile(
      path,
      safetensorsFixture(
        '{"x":{"dtype":"F32","shape":[0],"data_offsets":[9007199254740992,9007199254740992]}}',
        Buffer.alloc(0),
      ).bytes,
    );
    const offsetFailure = parseMcpToolError(
      await call("inspect_model_artifact", { path }),
    );
    expect(offsetFailure.error).toMatchObject({
      code: "resource_constraint",
      details: {
        reported_limits: { maximum_exact_offset: Number.MAX_SAFE_INTEGER },
      },
    });
  },
);

it.each(["named", "default", "inventory-only", "absent"] as const)(
  "reports actual chat-template presence in summaries and page context (%s)",
  async (kind) => {
    const root = await createTestTempDirectory("rea-model-templates-");
    const path = join(root, "model.gguf");
    const { text, u32, u64 } = ggufFixture();
    const names = {
      key: "tokenizer.chat_templates",
      type: 9,
      value: Buffer.concat([u32(8), u64(1n), text("tool_use")]),
    };
    const template = {
      key:
        kind === "default"
          ? "tokenizer.chat_template"
          : "tokenizer.chat_template.tool_use",
      type: 8,
      value: text("{{ messages }}"),
    };
    const metadata =
      kind === "named"
        ? [names, template]
        : kind === "default"
          ? [template]
          : kind === "inventory-only"
            ? [names]
            : [];
    await writeFile(path, ggufFixture({ metadata }).bytes);
    const { call } = await connectLocalToolsMcp();
    const response = await call("inspect_model_artifact", { path });
    expect(response.isError, JSON.stringify(response)).not.toBe(true);
    const summary = modelArtifactSummaryViewResultSchema.parse(
      parseEvidence(response.structuredContent).normalized_result,
    );
    const present = kind === "named" || kind === "default";
    expect(summary.summary.chat_template_present).toBe(present);
    const pageResponse = await call("inspect_analysis_view", {
      source: {
        kind: "retained-evidence",
        evidence_id: summary.parent_evidence_id,
      },
      view: {
        kind: "model-artifact",
        collection: "metadata",
        fields: ["key", "value"],
      },
    });
    expect(pageResponse.isError, JSON.stringify(pageResponse)).not.toBe(true);
    const page = analysisViewResultSchema.parse(
      parseEvidence(pageResponse.structuredContent).normalized_result,
    );
    if (page.kind !== "model-artifact") throw new Error("Incorrect model view");
    expect(page.model.chat_template_present).toBe(present);
    expect(
      page.items.map((row) => ("key" in row ? row.key : undefined)),
    ).toEqual(metadata.map((row) => row.key));
  },
);

it("keeps generated headline keys and imported compound metadata out of compact summaries", async () => {
  const root = await createTestTempDirectory("rea-model-headlines-");
  const path = join(root, "model");
  const architecture = "a".repeat(12000);
  const { text, u32 } = ggufFixture();
  await writeFile(
    path,
    ggufFixture({
      tensors: [],
      metadata: [
        { key: "general.architecture", type: 8, value: text(architecture) },
        { key: `${architecture}.context_length`, type: 4, value: u32(2048) },
      ],
    }).bytes,
  );
  const { call } = await connectLocalToolsMcp();
  const compact = await call("inspect_model_artifact", { path });
  expect(compact.isError, JSON.stringify(compact)).not.toBe(true);
  const summary = modelArtifactSummaryViewResultSchema.parse(
    parseEvidence(compact.structuredContent).normalized_result,
  );
  expect(summary.summary.headlines).toEqual([]);
  const full = parseEvidence(
    (await call("inspect_model_artifact", { path, detail: "complete" }))
      .structuredContent,
  );
  const report = modelArtifactSchema.parse(full.normalized_result);
  expect(report.metadata.map(({ key, value }) => ({ key, value }))).toEqual([
    { key: "general.architecture", value: architecture },
    { key: `${architecture}.context_length`, value: 2048 },
  ]);
  report.metadata[0]!.value = { future: architecture };
  const imported = createEvidence(undefined, full.provider, {
    operation: "inspect_model_artifact",
    parameters: full.parameters,
    result: report,
  });
  const page = await call("inspect_analysis_view", {
    source: { kind: "inline", evidence: imported },
    view: { kind: "summary" },
  });
  expect(page.isError, JSON.stringify(page)).not.toBe(true);
  const importedSummary = modelArtifactSummaryViewResultSchema.parse(
    parseEvidence(page.structuredContent).normalized_result,
  );
  expect(importedSummary.summary.headlines).toEqual([]);
});

it("rejects noncanonical imported model indexes and duplicate identities through public MCP", async () => {
  const root = await createTestTempDirectory("rea-model-import-");
  const path = join(root, "model");
  await writeFile(path, ggufFixture().bytes);
  const { call } = await connectLocalToolsMcp();
  const response = await call("inspect_model_artifact", {
    path,
    detail: "complete",
  });
  const complete = parseEvidence(response.structuredContent);
  const report = modelArtifactSchema.parse(complete.normalized_result);
  const corruptions: ((value: ModelArtifact) => void)[] = [
    (value) => {
      value.tensors[0]!.index = 7;
    },
    (value) => {
      value.metadata[0]!.index = 7;
    },
    (value) => {
      value.tensors[1]!.name = value.tensors[0]!.name;
    },
    (value) => {
      value.metadata[1]!.key = value.metadata[0]!.key;
    },
    (value) => {
      value.totals.by_type[1]!.type = value.totals.by_type[0]!.type;
    },
  ];
  for (const corrupt of corruptions) {
    const result = structuredClone(report);
    corrupt(result);
    const evidence = createEvidence(undefined, complete.provider, {
      operation: "inspect_model_artifact",
      parameters: complete.parameters,
      result,
    });
    const failure = parseMcpToolError(
      await call("inspect_analysis_view", {
        source: { kind: "inline", evidence },
        view: {
          kind: "model-artifact",
          collection: "tensors",
          names: ["weight"],
        },
      }),
    );
    expect(failure.error).toMatchObject({ code: "invalid_request" });
  }
  await assertHistoricalModelPages(call, complete.evidence_id, report);
});

it("bounds compact model warnings and omits unselected long labels while retaining complete Evidence", async () => {
  const root = await createTestTempDirectory("rea-model-long-labels-");
  const path = join(root, "model");
  const name = "tensor".repeat(4000);
  const type = "FUTURE".repeat(4000);
  const key = "metadata".repeat(3000);
  await writeFile(
    path,
    safetensorsFixture(
      JSON.stringify({
        __metadata__: { [key]: "kept" },
        [name]: { dtype: type, shape: [0], data_offsets: [0, 0] },
      }),
      Buffer.alloc(0),
    ).bytes,
  );
  const { call } = await connectLocalToolsMcp();
  const response = await call("inspect_model_artifact", { path });
  expect(response.isError, JSON.stringify(response)).not.toBe(true);
  expect(JSON.stringify(response).length).toBeLessThan(16_000);
  const summary = modelArtifactSummaryViewResultSchema.parse(
    parseEvidence(response.structuredContent).normalized_result,
  );
  expect(summary.summary.coverage.storage_sizes).toBe("partial");
  expect(summary.summary.limitations.join(" ")).toContain(
    summary.parent_evidence_id,
  );
  const source = {
    kind: "retained-evidence",
    evidence_id: summary.parent_evidence_id,
  };
  for (const collection of ["tensors", "metadata", "types"] as const) {
    const page = await call("inspect_analysis_view", {
      source,
      view: { kind: "model-artifact", collection, fields: [], limit: 1 },
    });
    expect(page.isError, JSON.stringify(page)).not.toBe(true);
    expect(JSON.stringify(page).length).toBeLessThan(16_000);
    const view = analysisViewResultSchema.parse(
      parseEvidence(page.structuredContent).normalized_result,
    );
    if (view.kind !== "model-artifact") throw new Error("Incorrect view");
    expect(view.items).toEqual([{ index: 0 }]);
    expect(view.source_coverage.storage_sizes).toBe("partial");
    expect(view.limitations.join(" ")).toContain(summary.parent_evidence_id);
  }
  const full = await call("inspect_model_artifact", {
    path,
    detail: "complete",
  });
  expect(full.isError, JSON.stringify(full)).not.toBe(true);
  const report = modelArtifactSchema.parse(
    parseEvidence(full.structuredContent).normalized_result,
  );
  expect(report.tensors[0]).toMatchObject({ name, type });
  expect(report.metadata[0]).toMatchObject({ key, value: "kept" });
  expect(report.limitations.join(" ")).toContain(type);
});

const assertHistoricalModelPages = async (
  call: Awaited<ReturnType<typeof connectLocalToolsMcp>>["call"],
  parentEvidenceId: string,
  report: ModelArtifact,
): Promise<void> => {
  const pages = [];
  for (let offset = 0; offset < report.tensors.length; offset++) {
    const page = await call("inspect_analysis_view", {
      source: {
        kind: "retained-evidence",
        evidence_id: parentEvidenceId,
      },
      view: {
        kind: "model-artifact",
        collection: "tensors",
        offset,
        limit: 1,
        fields: ["name", "type", "shape", "file_offset"],
      },
    });
    expect(page.isError, JSON.stringify(page)).not.toBe(true);
    const selected = analysisViewResultSchema.parse(
      parseEvidence(page.structuredContent).normalized_result,
    );
    if (selected.kind !== "model-artifact") throw new Error("Incorrect view");
    expect(selected.source.header_sha256).toBe(report.artifact.header_sha256);
    expect(selected.source.sha256).toBeNull();
    pages.push(...selected.items);
  }
  expect(pages).toEqual(
    report.tensors.map(({ index, name, type, shape, file_offset }) => ({
      index,
      name,
      type,
      shape,
      file_offset,
    })),
  );
  const selected = await call("inspect_analysis_view", {
    source: {
      kind: "retained-evidence",
      evidence_id: parentEvidenceId,
    },
    view: {
      kind: "model-artifact",
      collection: "tensors",
      names: ["weight", "absent"],
      indices: [0, 1],
      fields: [],
    },
  });
  const selectedView = analysisViewResultSchema.parse(
    parseEvidence(selected.structuredContent).normalized_result,
  );
  if (selectedView.kind !== "model-artifact") throw new Error("Incorrect view");
  expect(selectedView.items).toEqual(
    report.tensors
      .filter((row) => row.name === "weight")
      .map(({ index }) => ({ index })),
  );
  const empty = await call("inspect_analysis_view", {
    source: {
      kind: "retained-evidence",
      evidence_id: parentEvidenceId,
    },
    view: {
      kind: "model-artifact",
      collection: "metadata",
      keys: [],
      offset: 100,
    },
  });
  expect(empty.isError, JSON.stringify(empty)).not.toBe(true);
  const emptyView = analysisViewResultSchema.parse(
    parseEvidence(empty.structuredContent).normalized_result,
  );
  expect(emptyView.coverage).toMatchObject({ total: 0, exhausted: true });
  const unverified = await call("inspect_analysis_view", {
    source: {
      kind: "retained-evidence",
      evidence_id: parentEvidenceId,
    },
    view: {
      kind: "model-artifact",
      collection: "tensors",
      storage_validation: ["unknown"],
      fields: ["name", "storage_validation", "byte_length"],
    },
  });
  expect(unverified.isError, JSON.stringify(unverified)).not.toBe(true);
  const unverifiedView = analysisViewResultSchema.parse(
    parseEvidence(unverified.structuredContent).normalized_result,
  );
  if (unverifiedView.kind !== "model-artifact")
    throw new Error("Incorrect storage selection");
  expect(unverifiedView.items).toEqual(
    report.tensors
      .filter((row) => row.storage_validation === "unknown")
      .map(({ index, name, storage_validation, byte_length }) => ({
        index,
        name,
        storage_validation,
        byte_length,
      })),
  );
  const histogram = await call("inspect_analysis_view", {
    source: {
      kind: "retained-evidence",
      evidence_id: parentEvidenceId,
    },
    view: {
      kind: "model-artifact",
      collection: "types",
      types: ["F32"],
      fields: ["type", "tensors", "parameter_count", "bytes"],
    },
  });
  expect(histogram.isError, JSON.stringify(histogram)).not.toBe(true);
  const histogramView = analysisViewResultSchema.parse(
    parseEvidence(histogram.structuredContent).normalized_result,
  );
  if (histogramView.kind !== "model-artifact")
    throw new Error("Incorrect histogram view");
  expect(histogramView.items).toEqual(
    report.totals.by_type.flatMap((row, index) =>
      row.type === "F32" ? [{ index, ...row }] : [],
    ),
  );
};

cliTest(
  "shares scoped model facts through real CLI/MCP and pages retained metadata after source removal",
  async ({ cli }) => {
    const root = await createTestTempDirectory("rea-model-cli-");
    const { call } = await connectLocalToolsMcp();
    for (const [format, fixture] of [
      ["gguf", ggufFixture()],
      ["safetensors", safetensorsFixture()],
      [
        "safetensors",
        safetensorsFixture(
          '{"future":{"dtype":"FUTURE4","shape":[2],"data_offsets":[0,4]}}',
          Buffer.alloc(4),
        ),
      ],
    ] as const) {
      const path = join(root, `${format}.arbitrary`);
      await writeFile(path, fixture.bytes);
      const result = await cli.run({
        arguments: [
          "inspect-model-artifact",
          path,
          "--detail",
          "complete",
          "--json",
        ],
      });
      expect(result.exitCode, result.stderr).toBe(0);
      const evidence = toolContract(
        "inspect_model_artifact",
      ).outputSchema.parse(result.json);
      const report = modelArtifactSchema.parse(evidence.normalized_result);
      expect(report.format).toBe(format);
      expect(report.artifact.sha256).toBeNull();
      expect(evidence.subject).toBeNull();
      const complete = await call("inspect_model_artifact", {
        path,
        detail: "complete",
      });
      expect(complete.isError, JSON.stringify(complete)).not.toBe(true);
      expect(
        parseEvidence(complete.structuredContent).normalized_result,
      ).toEqual(report);
      const hashed = await call("inspect_model_artifact", {
        path,
        detail: "complete",
        hash: "full",
      });
      expect(hashed.isError, JSON.stringify(hashed)).not.toBe(true);
      expect(
        parseEvidence(hashed.structuredContent).subject?.digest.sha256,
      ).toBe(createHash("sha256").update(fixture.bytes).digest("hex"));
      const summary = await call("inspect_model_artifact", { path });
      expect(summary.isError, JSON.stringify(summary)).not.toBe(true);
      const retained = modelArtifactSummaryViewResultSchema.parse(
        parseEvidence(summary.structuredContent).normalized_result,
      );
      expect(retained.summary.counts.tensors).toBe(report.tensors.length);
      const direct = await call("inspect_model_artifact", {
        path,
        view: {
          collection: "tensors",
          names: ["weight"],
          fields: ["name", "type", "shape", "file_offset"],
        },
      });
      expect(direct.isError, JSON.stringify(direct)).not.toBe(true);
      const directView = analysisViewResultSchema.parse(
        parseEvidence(direct.structuredContent).normalized_result,
      );
      if (directView.kind !== "model-artifact")
        throw new Error("Incorrect direct selection");
      expect(directView.model.counts.tensors).toBe(report.tensors.length);
      expect(directView.items).toEqual(
        report.tensors
          .filter((row) => row.name === "weight")
          .map(({ index, name, type, shape, file_offset }) => ({
            index,
            name,
            type,
            shape,
            file_offset,
          })),
      );
      expect(directView.parent_evidence_id).toBe(
        parseEvidence(complete.structuredContent).evidence_id,
      );
      await unlink(path);
      await assertHistoricalModelPages(
        call,
        retained.parent_evidence_id,
        report,
      );
    }
  },
);

cliTest(
  "preserves optional safetensors fields and aligns empty GGUF data in CLI and MCP",
  async ({ cli }) => {
    const root = await createTestTempDirectory("rea-model-boundary-compat-");
    const { call } = await connectLocalToolsMcp();
    const safetensors = safetensorsFixture(
      '{"__metadata__":null,"weight":{"dtype":"F32","shape":[1],"data_offsets":[0,4],"note":{"source":"local","flags":[null,false,-1,1.25]}}}',
      Buffer.alloc(4),
    );
    const emptyGgufHeader = ggufFixture({ tensors: [], metadata: [] });
    const alignedOffset = Math.ceil(emptyGgufHeader.header.length / 32) * 32;
    const emptyGguf = Buffer.concat([
      emptyGgufHeader.header,
      Buffer.alloc(alignedOffset - emptyGgufHeader.header.length),
    ]);

    for (const [name, bytes] of [
      ["optional.safetensors", safetensors.bytes],
      ["empty.gguf", emptyGguf],
    ] as const) {
      const path = join(root, name);
      await writeFile(path, bytes);
      const result = await cli.run({
        arguments: [
          "inspect-model-artifact",
          path,
          "--detail",
          "complete",
          "--json",
        ],
      });
      expect(result.exitCode, result.stderr).toBe(0);
      const report = modelArtifactSchema.parse(
        toolContract("inspect_model_artifact").outputSchema.parse(result.json)
          .normalized_result,
      );
      if (name.endsWith("safetensors")) {
        expect(report.metadata).toEqual([]);
        expect(report.tensors[0]?.name).toBe("weight");
        expect(report.artifact.header_sha256).toBe(
          createHash("sha256").update(safetensors.header).digest("hex"),
        );
      } else {
        expect(report.tensors).toEqual([]);
        expect(report.tensor_data_offset).toBe(alignedOffset);
        expect(report.artifact.header_length).toBe(
          emptyGgufHeader.header.length,
        );
        expect(report.artifact.header_sha256).toBe(
          createHash("sha256").update(emptyGgufHeader.header).digest("hex"),
        );
      }
      const response = await call("inspect_model_artifact", {
        path,
        detail: "complete",
      });
      expect(response.isError, JSON.stringify(response)).not.toBe(true);
      expect(
        parseEvidence(response.structuredContent).normalized_result,
      ).toEqual(report);
    }

    const mapPath = join(root, "same-key-map.safetensors");
    await writeFile(
      mapPath,
      safetensorsFixture(
        '{"__metadata__":{"json_number":"1.25"}}',
        Buffer.alloc(0),
      ).bytes,
    );
    const mapCli = await cli.run({
      arguments: [
        "inspect-model-artifact",
        mapPath,
        "--detail",
        "complete",
        "--json",
      ],
    });
    expect(mapCli.exitCode, mapCli.stderr).toBe(0);
    const mapReport = modelArtifactSchema.parse(
      toolContract("inspect_model_artifact").outputSchema.parse(mapCli.json)
        .normalized_result,
    );
    expect(
      mapReport.metadata.map(({ key, value }) => ({ key, value })),
    ).toEqual([{ key: "json_number", value: "1.25" }]);
    const mapMcp = await call("inspect_model_artifact", {
      path: mapPath,
      detail: "complete",
    });
    expect(mapMcp.isError, JSON.stringify(mapMcp)).not.toBe(true);
    expect(parseEvidence(mapMcp.structuredContent).normalized_result).toEqual(
      mapReport,
    );

    for (const [name, numeric] of [
      ["decimal", "1.25"],
      ["negative", "-1"],
      ["overflow", "18446744073709551616"],
    ] as const) {
      const malformedPath = join(root, `${name}-metadata.safetensors`);
      await writeFile(
        malformedPath,
        safetensorsFixture(`{"__metadata__":${numeric}}`, Buffer.alloc(0))
          .bytes,
      );
      const malformedCli = await cli.run({
        arguments: ["inspect-model-artifact", malformedPath, "--json"],
      });
      expect(malformedCli.exitCode).toBe(1);
      expect(malformedCli.json).toMatchObject({
        code: "target_unavailable",
        category: "unsupported_target",
        details: { constraint: "file_format_rejected" },
      });
      const malformedMcp = parseMcpToolError(
        await call("inspect_model_artifact", { path: malformedPath }),
      );
      expect(malformedMcp.error).toMatchObject({
        code: "target_unavailable",
        category: "unsupported_target",
        details: { constraint: "file_format_rejected" },
      });
    }
  },
);

cliTest(
  "exports complete model Evidence for portable paging and returns typed malformed errors",
  async ({ cli }) => {
    const root = await createTestTempDirectory("rea-model-export-");
    const path = join(root, "model");
    const output = join(root, "evidence.json");
    await writeFile(path, ggufFixture().bytes);
    const result = await cli.run({
      arguments: [
        "inspect-model-artifact",
        path,
        "--detail",
        "summary",
        "--view",
        JSON.stringify({
          collection: "metadata",
          keys: ["tokenizer.chat_template"],
          fields: ["key", "value"],
        }),
        "--evidence_output",
        output,
        "--json",
      ],
    });
    expect(result.exitCode, result.stderr).toBe(0);
    const receipt = result.json as { summary: unknown };
    const delivered = analysisViewResultSchema.parse(
      parseEvidence(receipt.summary).normalized_result,
    );
    if (delivered.kind !== "model-artifact")
      throw new Error("Missing CLI direct selection");
    expect(delivered.items).toEqual([
      { index: 5, key: "tokenizer.chat_template", value: "{{ messages }}" },
    ]);
    const exported = await readEvidenceBundle(output);
    if (!exported.ok) throw exported.error;
    const complete = exported.value.records.find(
      (evidence) => evidence.operation === "inspect_model_artifact",
    );
    if (complete === undefined)
      throw new Error("Missing complete exported model Evidence");
    const recordPath = join(root, "model-record.json");
    await writeFile(recordPath, JSON.stringify(complete));
    const { call } = await connectLocalToolsMcp();
    await unlink(path);
    const page = await call("inspect_analysis_view", {
      source: { kind: "evidence-file", path: recordPath },
      view: {
        kind: "model-artifact",
        collection: "metadata",
        keys: ["tokenizer.chat_template", "custom.exact"],
        fields: ["key", "type", "value", "source_offset", "source_length"],
      },
    });
    expect(page.isError, JSON.stringify(page)).not.toBe(true);
    const selected = analysisViewResultSchema.parse(
      parseEvidence(page.structuredContent).normalized_result,
    );
    if (selected.kind !== "model-artifact") throw new Error("Incorrect view");
    expect(selected.items.map((row) => ("key" in row ? row.key : ""))).toEqual([
      "custom.exact",
      "tokenizer.chat_template",
    ]);
    await writeFile(
      path,
      safetensorsFixture(
        '{"x":{"dtype":"F32","shape":[3],"data_offsets":[4,16]}}',
      ).bytes,
    );
    const malformed = parseMcpToolError(
      await call("inspect_model_artifact", { path }),
    );
    expect(malformed.error).toMatchObject({
      code: "target_unavailable",
      category: "unsupported_target",
      details: { constraint: "file_format_rejected" },
    });
  },
);

cliTest(
  "rejects malformed model view JSON before opening the selected path",
  async ({ cli }) => {
    const root = await createTestTempDirectory("rea-model-view-json-");
    const missing = join(root, "not-created.gguf");
    const result = await cli.run({
      arguments: ["inspect-model-artifact", missing, "--view", "{", "--json"],
    });

    expect(result.exitCode).toBe(1);
    expect(result.json).toMatchObject({
      code: "invalid_request",
      details: {
        operation: "inspect_model_artifact",
        issues: [
          {
            path: ["view"],
            reason: "invalid_format",
            message: "view must be a JSON model page selection",
          },
        ],
      },
    });
    expect(JSON.stringify(result.json)).not.toContain("ENOENT");
  },
);