Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

refactor(browser): reuse CDP endpoint parsing

morluto00abf45d2085
diff --git a/src/browser/CdpEndpoint.ts b/src/browser/CdpEndpoint.ts
index 55a226ab7..df810721c 100644
--- a/src/browser/CdpEndpoint.ts
+++ b/src/browser/CdpEndpoint.ts
@@ -86,12 +86,12 @@ export const discoverCdpEndpoint = async (
operation,
signal,
);
- const version = parseEndpointValue(
+ const version = parseCdpEndpointValue(
endpointVersionSchema,
versionInput,
operation,
);
- const targets = parseEndpointValue(
+ const targets = parseCdpEndpointValue(
endpointTargetsSchema,
targetsInput,
operation,
@@ -199,7 +199,8 @@ const availableCdpTargetWebSocket = (
: undefined;
};
-const parseEndpointValue = <Output>(
+/** Parse one CDP discovery value through its exact boundary schema. */
+export const parseCdpEndpointValue = <Output>(
schema: z.ZodType<Output>,
input: unknown,
operation: BrowserObservationOperation,
diff --git a/src/browser/V8InspectorEndpoint.ts b/src/browser/V8InspectorEndpoint.ts
index cb63b0c17..3c8fd0b96 100644
--- a/src/browser/V8InspectorEndpoint.ts
+++ b/src/browser/V8InspectorEndpoint.ts
@@ -8,7 +8,7 @@ import {
BrowserObservationError,
type BrowserObservationOperation,
} from "../domain/errors.js";
-import { readBoundedCdpJson } from "./CdpEndpoint.js";
+import { parseCdpEndpointValue, readBoundedCdpJson } from "./CdpEndpoint.js";
const MAX_VERSION_BYTES = 64 * 1_024;
const MAX_TARGET_LIST_BYTES = 2 * 1_024 * 1_024;
@@ -65,8 +65,8 @@ export const discoverV8Inspector = async (
signal,
),
]);
- const version = parse(versionSchema, versionInput, operation);
- const targets = parse(targetsSchema, targetsInput, operation);
+ const version = parseCdpEndpointValue(versionSchema, versionInput, operation);
+ const targets = parseCdpEndpointValue(targetsSchema, targetsInput, operation);
return {
runtime: {
product: version.Browser,
@@ -88,19 +88,6 @@ export const discoverV8Inspector = async (
};
};
-const parse = <Output>(
- schema: z.ZodType<Output>,
- input: unknown,
- operation: BrowserObservationOperation,
-): Output => {
- const parsed = schema.safeParse(input);
- if (!parsed.success)
- throw new BrowserObservationError(operation, "invalid_endpoint_response", {
- cause: parsed.error,
- });
- return parsed.data;
-};
-
const validatedInspectorWebSocket = (
endpoint: string,
targetId: string,