Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(gpu): keep unknown targets out of exact filters

morluto0205f870db66
diff --git a/src/domain/analysisView/gpuCodeObjectsView.ts b/src/domain/analysisView/gpuCodeObjectsView.ts
index 1b256b756..0b1df43dd 100644
--- a/src/domain/analysisView/gpuCodeObjectsView.ts
+++ b/src/domain/analysisView/gpuCodeObjectsView.ts
@@ -344,17 +344,19 @@ export const projectGpuCodeObjectsView = (
: view.collection === "targets"
? targetRows
: report.kernels;
+ const matchesTarget = (row: (typeof rows)[number]): boolean => {
+ if (targets === undefined) return true;
+ const target =
+ "target" in row ? row.target : byId.get(row.object_id)?.target;
+ return target !== null && target !== undefined && targets.has(target);
+ };
const matches = rows.filter(
(row) =>
(ids === undefined || ids.has(row.id)) &&
(objectIds === undefined ||
("object_id" in row && objectIds.has(row.object_id))) &&
(names === undefined || ("name" in row && names.has(row.name))) &&
- (targets === undefined ||
- targets.has(
- ("target" in row ? row.target : byId.get(row.object_id)?.target) ??
- "",
- )),
+ matchesTarget(row),
);
const defaults =
view.collection === "kernels"
diff --git a/tests/acceptance/gpuCodeObjectsCli.test.ts b/tests/acceptance/gpuCodeObjectsCli.test.ts
index bb5bc8ce0..01e069cac 100644
--- a/tests/acceptance/gpuCodeObjectsCli.test.ts
+++ b/tests/acceptance/gpuCodeObjectsCli.test.ts
@@ -334,6 +334,35 @@ it("keeps unknown target discovery visible in the default MCP summary", async ()
);
expect(result.summary.coverage.discovery).toBe("partial");
expect(result.summary.counts).toMatchObject({ objects: 1, targets: 0 });
+ const detailedReply = await call("inspect_gpu_code_objects", {
+ path,
+ analysis: "kernels",
+ view: { collection: "objects" },
+ });
+ expect(detailedReply.isError, JSON.stringify(detailedReply)).not.toBe(true);
+ const detailed = gpuCodeObjectsPageViewResultSchema.parse(
+ parseEvidence(detailedReply.structuredContent).normalized_result,
+ );
+ expect(detailed.items).toHaveLength(1);
+ const source = {
+ kind: "retained-evidence",
+ evidence_id: detailed.parent_evidence_id,
+ } as const;
+ for (const collection of ["objects", "targets", "kernels"] as const) {
+ const filteredReply = await call("inspect_analysis_view", {
+ source,
+ view: {
+ kind: "gpu-code-objects",
+ collection,
+ targets: [""],
+ },
+ });
+ expect(filteredReply.isError, JSON.stringify(filteredReply)).not.toBe(true);
+ const filtered = gpuCodeObjectsPageViewResultSchema.parse(
+ parseEvidence(filteredReply.structuredContent).normalized_result,
+ );
+ expect(filtered.items).toEqual([]);
+ }
});
it("retains selected kernel facts and complete PTX for historical MCP pages after source removal", async () => {