Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

refactor(core): use canonical file outcomes and unknown schema

morluto106779208d9f
diff --git a/src/application/RegularFileRead.ts b/src/application/RegularFileRead.ts
index cd4c4db1a..7e46e1430 100644
--- a/src/application/RegularFileRead.ts
+++ b/src/application/RegularFileRead.ts
@@ -54,19 +54,17 @@ export class InvalidUtf8FileError extends TypeError {
export { RegularFileCleanupFailure } from "../filesystem/OwnedRegularFile.js";
-export type RegularFileReadOutcome<Value> = RegularFileOperationOutcome<Value>;
-
/** Retry a failed close through its retained owner and report any remaining cleanup. */
export const retryRegularFileCleanup = async <Value>(
failure: RegularFileCleanupFailure<Value>,
resources: ArtifactResourceScope,
signal?: AbortSignal,
): Promise<{
- readonly outcome: RegularFileReadOutcome<Value>;
+ readonly outcome: RegularFileOperationOutcome<Value>;
readonly cleanupLease?: AnalysisCleanupLease;
readonly cleanup?: AnalysisCleanupObservation;
}> => {
- const outcome: RegularFileReadOutcome<Value> =
+ const outcome: RegularFileOperationOutcome<Value> =
failure.outcome.kind === "failed" &&
failure.operationFailure === undefined &&
failure.outcome.cause instanceof RegularFileOperationCancelled &&
diff --git a/src/domain/residualUnknown.ts b/src/domain/residualUnknown.ts
index cfa45ae10..b6ac7eb8c 100644
--- a/src/domain/residualUnknown.ts
+++ b/src/domain/residualUnknown.ts
@@ -221,7 +221,7 @@ const refineRevision = (value: UnknownRevision, context: z.RefinementCtx) => {
});
};
-const residualUnknownValidatedSchema = residualUnknownObjectSchema.superRefine(
+export const residualUnknownSchema = residualUnknownObjectSchema.superRefine(
(value, context) => {
if (computeRevisionDigest(value) !== value.revision_digest)
context.addIssue({
@@ -233,8 +233,6 @@ const residualUnknownValidatedSchema = residualUnknownObjectSchema.superRefine(
},
);
-export const residualUnknownSchema = residualUnknownValidatedSchema;
-
const generatedRevisionSchema = residualUnknownObjectSchema
.omit({ revision_digest: true })
.superRefine(refineRevision);