Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

refactor: remove redundant contract and syntax definitions

morluto1828cf87a06a
diff --git a/scripts/ci/artifacts.d.mts b/scripts/ci/artifacts.d.mts
index 8c93058a4..0d041fd07 100644
--- a/scripts/ci/artifacts.d.mts
+++ b/scripts/ci/artifacts.d.mts
@@ -77,7 +77,7 @@ export function safeSha(value: unknown): string | null;
export function validRepoPath(value: unknown): value is string;
export function selectStaticCheckArtifact(
page: unknown,
- run: { id?: string | number; head_sha?: string },
+ run: Pick<CiRun, "id" | "head_sha">,
runAttempt: number,
name?: string,
): unknown | null;
diff --git a/src/application/EvidenceInputResolver.ts b/src/application/EvidenceInputResolver.ts
index be2fd37cf..6f382f9f9 100644
--- a/src/application/EvidenceInputResolver.ts
+++ b/src/application/EvidenceInputResolver.ts
@@ -1,4 +1,4 @@
-import type { EvidenceInput } from "../contracts/evidenceInputContracts.js";
+import type { EvidenceInput } from "../domain/evidenceReference.js";
import type { Evidence } from "../domain/evidence.js";
import { EvidenceReferenceError } from "../domain/evidenceErrors.js";
import { err, ok, type Result } from "../domain/result.js";
diff --git a/src/application/environment/environmentReplay.test.ts b/src/application/environment/environmentReplay.test.ts
index 43b7851af..5b8cd40e0 100644
--- a/src/application/environment/environmentReplay.test.ts
+++ b/src/application/environment/environmentReplay.test.ts
@@ -13,13 +13,13 @@ import { projectAnalysisError } from "../../domain/analysisErrorProjection.js";
import { inspectAnalysisView } from "../analysisView/AnalysisViewService.js";
import {
REPLAY_BODY_LIMIT_BYTES,
+ type EnvironmentSource,
+ type RecordedExchange,
+} from "./environmentSource.js";
+import {
replayEnvironmentTool,
selectReplayExchange,
} from "./environmentReplay.js";
-import type {
- EnvironmentSource,
- RecordedExchange,
-} from "./environmentSource.js";
const source = environmentServeSource();
diff --git a/src/application/environment/environmentReplay.ts b/src/application/environment/environmentReplay.ts
index 4b66ea08e..db83a8e52 100644
--- a/src/application/environment/environmentReplay.ts
+++ b/src/application/environment/environmentReplay.ts
@@ -16,8 +16,6 @@ import {
type RecordedExchange,
} from "./environmentSource.js";
-export { REPLAY_BODY_LIMIT_BYTES } from "./environmentSource.js";
-
/** Caller arguments as the MCP tool receives them. */
export type ReplayArguments = Readonly<Record<string, unknown>>;
diff --git a/src/application/environment/environmentStateAnswer.test.ts b/src/application/environment/environmentStateAnswer.test.ts
index 52ac7667e..32af8c9b3 100644
--- a/src/application/environment/environmentStateAnswer.test.ts
+++ b/src/application/environment/environmentStateAnswer.test.ts
@@ -9,8 +9,10 @@ import {
environmentStateServeInputs,
} from "../../../tests/fixtures/environmentServe.js";
import { projectAnalysisError } from "../../domain/analysisErrorProjection.js";
-import { REPLAY_BODY_LIMIT_BYTES } from "./environmentReplay.js";
-import type { EnvironmentSource } from "./environmentSource.js";
+import {
+ REPLAY_BODY_LIMIT_BYTES,
+ type EnvironmentSource,
+} from "./environmentSource.js";
import {
answerFromState,
type StateServing,
diff --git a/src/application/environment/environmentStateAnswer.ts b/src/application/environment/environmentStateAnswer.ts
index dbd6b4553..59f274d1c 100644
--- a/src/application/environment/environmentStateAnswer.ts
+++ b/src/application/environment/environmentStateAnswer.ts
@@ -24,7 +24,6 @@ import { err, ok, type Result } from "../../domain/result.js";
import {
decodedPathSegment,
pathValueMatches,
- REPLAY_BODY_LIMIT_BYTES,
replayAnswer,
replayEnvironmentTool,
selectReplayExchange,
@@ -34,6 +33,7 @@ import {
} from "./environmentReplay.js";
import {
ENVIRONMENT_SERVE_OPERATION,
+ REPLAY_BODY_LIMIT_BYTES,
type EnvironmentManifestTool,
type EnvironmentSource,
type RecordedExchange,
diff --git a/src/contracts/advertisedInputExamples.test.ts b/src/contracts/advertisedInputExamples.test.ts
index 3f7b12745..e4d76c5e5 100644
--- a/src/contracts/advertisedInputExamples.test.ts
+++ b/src/contracts/advertisedInputExamples.test.ts
@@ -2,7 +2,7 @@ import { describe, expect, it } from "vitest";
import { z } from "zod";
import { advertisedInputExamples } from "./advertisedInputExamples.js";
-import { evidenceInputSchema } from "./evidenceInputContracts.js";
+import { evidenceInputSchema } from "../domain/evidenceReference.js";
import { JAVASCRIPT_FEATURE_TRACE_EXAMPLE } from "./javascript/javascriptApplicationWorkflowExamples.js";
import { TOOL_CONTRACTS } from "./toolContracts.js";
import { evidenceSchema } from "../domain/evidence.js";
diff --git a/src/contracts/evidenceInputContracts.ts b/src/contracts/evidenceInputContracts.ts
deleted file mode 100644
index 0419ba5d5..000000000
--- a/src/contracts/evidenceInputContracts.ts
+++ /dev/null
@@ -1,5 +0,0 @@
-/** Canonical Evidence selection contracts are owned by the domain. */
-export {
- evidenceInputSchema,
- type EvidenceInput,
-} from "../domain/evidenceReference.js";
diff --git a/src/contracts/javascript/applicationWorkflowInputContracts.ts b/src/contracts/javascript/applicationWorkflowInputContracts.ts
index 53773c2d1..c4a7cbbe5 100644
--- a/src/contracts/javascript/applicationWorkflowInputContracts.ts
+++ b/src/contracts/javascript/applicationWorkflowInputContracts.ts
@@ -6,7 +6,7 @@ import { sourceToBundleViewRequestSchema } from "../../domain/analysisView/sourc
import { evidenceSchema } from "../../domain/evidence.js";
import { z } from "zod";
-import { evidenceInputSchema } from "../evidenceInputContracts.js";
+import { evidenceInputSchema } from "../../domain/evidenceReference.js";
import { compareApplicationVersionsInputSchema } from "../../domain/javascript/javascriptApplicationVersionComparisonSchemas.js";
import { compareJavaScriptExportShapesInputSchema } from "../../domain/javascript/javascriptExportShapeComparisonSchemas.js";
import { traceApplicationFeatureInputSchema } from "../../domain/javascript/javascriptFeatureTraceSchemas.js";
diff --git a/src/contracts/native/functionMatchingContracts.ts b/src/contracts/native/functionMatchingContracts.ts
index e8bc5c38c..00cbf301b 100644
--- a/src/contracts/native/functionMatchingContracts.ts
+++ b/src/contracts/native/functionMatchingContracts.ts
@@ -1,5 +1,5 @@
import { z } from "zod";
-import { evidenceInputSchema } from "../evidenceInputContracts.js";
+import { evidenceInputSchema } from "../../domain/evidenceReference.js";
// Borrow inline payloads until application admission; advertise the exact public
// Evidence/reference union without a pre-admission recursive SDK clone.
diff --git a/src/contracts/wasm/wasmComparisonContracts.ts b/src/contracts/wasm/wasmComparisonContracts.ts
index 7eae508b7..a04c81414 100644
--- a/src/contracts/wasm/wasmComparisonContracts.ts
+++ b/src/contracts/wasm/wasmComparisonContracts.ts
@@ -1,6 +1,6 @@
import { evidenceResultOf } from "../toolOutputSchemaPrimitives.js";
import { z } from "zod";
-import { evidenceInputSchema } from "../evidenceInputContracts.js";
+import { evidenceInputSchema } from "../../domain/evidenceReference.js";
import { wasmInterfaceSchema } from "../../domain/wasm/wasmInterface.js";
import { toolContractMetadata } from "../toolEffects.js";
import type { ToolContract } from "../toolContractTypes.js";
diff --git a/src/domain/analysisView/analysisView.ts b/src/domain/analysisView/analysisView.ts
index 2f7badbbb..f77286525 100644
--- a/src/domain/analysisView/analysisView.ts
+++ b/src/domain/analysisView/analysisView.ts
@@ -30,6 +30,10 @@ import {
projectFridaSessionStatusView,
} from "./fridaSessionStatusView.js";
import { commandObservationSchema } from "../commandObservation.js";
+import {
+ rustBinaryViewPageSchema,
+ rustBinaryViewRequestSchema,
+} from "../rust/rustBinaryQuery.js";
import {
goBinarySummarySchema,
goBinaryViewContextSchema,
@@ -40,8 +44,6 @@ import {
import {
rustBinarySummarySchema,
rustBinaryViewContextSchema,
- rustBinaryViewPageSchema,
- rustBinaryViewRequestSchema,
projectRustBinaryView,
} from "./rustBinaryView.js";
import {
diff --git a/src/domain/analysisView/rustBinaryView.ts b/src/domain/analysisView/rustBinaryView.ts
index e192c245b..5402c0c67 100644
--- a/src/domain/analysisView/rustBinaryView.ts
+++ b/src/domain/analysisView/rustBinaryView.ts
@@ -7,10 +7,6 @@ import {
rustcCommitSchema,
type RustBinary,
} from "../rust/rustBinary.js";
-export {
- rustBinaryViewPageSchema,
- rustBinaryViewRequestSchema,
-} from "../rust/rustBinaryQuery.js";
import { isImmutableJsonSnapshot } from "../immutableJson.js";
import { err, ok, type Result } from "../result.js";
import type {
diff --git a/src/domain/webBundleAnalyzerAst.ts b/src/domain/webBundleAnalyzerAst.ts
index f9972a27f..1cfa52f85 100644
--- a/src/domain/webBundleAnalyzerAst.ts
+++ b/src/domain/webBundleAnalyzerAst.ts
@@ -1,6 +1,7 @@
import * as t from "@babel/types";
import { sanitizeBrowserUrl } from "./browserObservation.js";
+import { hasScheme } from "./artifactPathSyntax.js";
import {
isNullishJavaScriptSyntax,
readExactJavaScriptLiteral,
@@ -33,7 +34,7 @@ export const isUrlLikeModuleSpecifier = (specifier: string): boolean =>
specifier.startsWith("/") ||
specifier.startsWith("./") ||
specifier.startsWith("../") ||
- /^[A-Za-z][A-Za-z0-9+.-]*:/u.test(specifier);
+ hasScheme(specifier);
export const resolveSpecifier = (
specifier: string,
diff --git a/src/process/ProcessOwnership.ts b/src/process/ProcessOwnership.ts
index bbc1d5f3b..98dc2480c 100644
--- a/src/process/ProcessOwnership.ts
+++ b/src/process/ProcessOwnership.ts
@@ -106,8 +106,6 @@ export type ProcessIdentityObservation =
}
| { readonly state: "unavailable"; readonly reason: string };
-export type { ProcessLifecycleObservation } from "./ProcessLifecycle.js";
-
/** Parent and process-group membership from the same native identity read. */
export type ProcessNativeRelationObservation =
| {