Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(ci): align omission and browser transport assertions

morluto19f2969c56ae
diff --git a/scripts/verify-real-browser.mjs b/scripts/verify-real-browser.mjs
index 54c1eaa11..4ba8d1e96 100644
--- a/scripts/verify-real-browser.mjs
+++ b/scripts/verify-real-browser.mjs
@@ -546,13 +546,14 @@ async function verifyPageScopedTransport(provider, proxy, origin) {
const disconnected = await disconnectedPromise;
if (
!disconnected.ok ||
- disconnected.value.window.end_reason !== "target_terminated" ||
+ disconnected.value.window.end_reason !== "transport_disconnected" ||
!disconnected.value.timeline.some(
- ({ type }) => type === "target_terminated",
- )
+ ({ type }) => type === "transport_disconnected",
+ ) ||
+ disconnected.value.timeline.some(({ type }) => type === "target_terminated")
)
throw new Error(
- "Page-scoped CDP disconnect was not reported as target_terminated",
+ "Page-scoped CDP disconnect must report transport loss without claiming a target crash",
);
}
diff --git a/tests/boundary/cli/cliInputSchemaRequired.test.ts b/tests/boundary/cli/cliInputSchemaRequired.test.ts
index 1bf778b7a..29a5c7f76 100644
--- a/tests/boundary/cli/cliInputSchemaRequired.test.ts
+++ b/tests/boundary/cli/cliInputSchemaRequired.test.ts
@@ -63,7 +63,7 @@ const parserSchema = (
const omissionRejected = (schema: z.ZodObject | undefined): string[] =>
Object.entries(schema?.shape ?? {})
- .filter(([, field]) => !field.safeParse(undefined).success)
+ .filter(([key, field]) => !z.object({ [key]: field }).safeParse({}).success)
.map(([key]) => key)
.sort();
@@ -104,6 +104,30 @@ describe("CLI advertised input schemas", () => {
expect(mismatches).toEqual([]);
});
+ it("allows an omitted WASM timeout while validating explicitly supplied values", async () => {
+ const cli = createCli({});
+ const advertised = await advertisedSchema(cli, "inspect-wasm-artifact");
+ const options = parserSchema(cli, "inspect-wasm-artifact", "options");
+ expect(options).toBeDefined();
+ const validate = new Ajv2020({ strict: false }).compile(
+ advertised.options ?? {},
+ );
+
+ expect(options?.safeParse({}).success).toBe(true);
+ expect(validate({})).toBe(true);
+ expect(options?.safeParse({ commandTimeoutMs: undefined }).success).toBe(
+ false,
+ );
+ for (const commandTimeoutMs of [1, 30_000, 2_147_483_647]) {
+ expect(options?.safeParse({ commandTimeoutMs }).success).toBe(true);
+ expect(validate({ commandTimeoutMs })).toBe(true);
+ }
+ for (const commandTimeoutMs of [0, 1.5, 2_147_483_648]) {
+ expect(options?.safeParse({ commandTimeoutMs }).success).toBe(false);
+ expect(validate({ commandTimeoutMs })).toBe(false);
+ }
+ });
+
it("accepts the one-argument keyed-archive call and keeps its constraints", async () => {
const cli = createCli({});
const advertised = await advertisedSchema(cli, "inspect-keyed-archive");