Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(browser): reject empty capture containers beyond the 64-level nesting budget (#3975)

Anurag Singh1f9d1b5de19b
diff --git a/src/browser/history/CaptureJson.ts b/src/browser/history/CaptureJson.ts
index 1fe59e8a1..a1b5ca17a 100644
--- a/src/browser/history/CaptureJson.ts
+++ b/src/browser/history/CaptureJson.ts
@@ -29,8 +29,11 @@ export const parseCaptureJson = (
? parent.pointer
: `${parent.pointer}/${parent.pendingKey.replaceAll("~", "~0").replaceAll("/", "~1")}`;
};
- const checkDepth = (): void => {
- if (frames.length > WEB_NETWORK_CAPTURE_LIMITS.depth)
+ // The document root is container level 1. Admit a container only while
+ // its own level stays within the budget; values inside an admitted
+ // container add no level, so empty and scalar-bearing containers agree.
+ const admitContainer = (): void => {
+ if (frames.length >= WEB_NETWORK_CAPTURE_LIMITS.depth)
throw new CaptureFormatError(
"input-limit",
`${format} exceeds the 64-level complete-evidence nesting budget. This release has no runtime override.`,
@@ -54,7 +57,7 @@ export const parseCaptureJson = (
text,
{
onObjectBegin: () => {
- checkDepth();
+ admitContainer();
frames.push({
kind: "object",
pointer: valuePointer(),
@@ -84,7 +87,7 @@ export const parseCaptureJson = (
append(Object.fromEntries(frame.members));
},
onArrayBegin: () => {
- checkDepth();
+ admitContainer();
frames.push({ kind: "array", pointer: valuePointer(), items: [] });
},
onArrayEnd: () => {
@@ -94,7 +97,6 @@ export const parseCaptureJson = (
append(frame.items);
},
onLiteralValue: (value: unknown, offset, length) => {
- checkDepth();
if (typeof value === "number")
append(new LosslessNumber(text.slice(offset, offset + length)));
else if (
diff --git a/src/browser/history/HarCapture.test.ts b/src/browser/history/HarCapture.test.ts
index 055879df0..1eb306769 100644
--- a/src/browser/history/HarCapture.test.ts
+++ b/src/browser/history/HarCapture.test.ts
@@ -683,6 +683,25 @@ it("excludes a declared literal in encoded HAR text from its binary sidecar too"
expect(result.records[0]?.binary_fields[0]?.state).toBe("redacted");
});
+it.each([
+ { depth: 64, innermost: "[]", accepted: true },
+ { depth: 64, innermost: "{}", accepted: true },
+ { depth: 64, innermost: "[0]", accepted: true },
+ { depth: 65, innermost: "[]", accepted: false },
+ { depth: 65, innermost: "{}", accepted: false },
+ { depth: 65, innermost: "[0]", accepted: false },
+ { depth: 66, innermost: "[]", accepted: false },
+])(
+ "bounds a $innermost extension at container level $depth",
+ ({ depth, innermost, accepted }) => {
+ // The root and log objects are the first two levels.
+ const enclosing = depth - 3;
+ const text = `{"log":{"version":"1.2","creator":{"name":"fixture","version":"1"},"entries":[],"_extension":${"[".repeat(enclosing)}${innermost}${"]".repeat(enclosing)}}}`;
+ if (accepted) expect(decodeHarCapture(text, []).total_records).toBe(0);
+ else expect(() => decodeHarCapture(text, [])).toThrow("nesting budget");
+ },
+);
+
it("rejects excessive extension nesting instead of returning a partial capture", () => {
let extension: unknown = null;
for (let index = 0; index < 66; index++) extension = { child: extension };
diff --git a/src/browser/history/QlogCapture.test.ts b/src/browser/history/QlogCapture.test.ts
index 23c776565..2b2942b2e 100644
--- a/src/browser/history/QlogCapture.test.ts
+++ b/src/browser/history/QlogCapture.test.ts
@@ -273,6 +273,25 @@ it.each([
},
);
+it.each([
+ { depth: 64, innermost: "[]", accepted: true },
+ { depth: 64, innermost: "{}", accepted: true },
+ { depth: 64, innermost: "[0]", accepted: true },
+ { depth: 65, innermost: "[]", accepted: false },
+ { depth: 65, innermost: "{}", accepted: false },
+ { depth: 65, innermost: "[0]", accepted: false },
+ { depth: 66, innermost: "[]", accepted: false },
+])(
+ "bounds a $innermost extension at container level $depth",
+ ({ depth, innermost, accepted }) => {
+ // The root, traces array and trace object are the first three levels.
+ const enclosing = depth - 4;
+ const text = `{"qlog_format":"JSON","qlog_version":"0.3","traces":[{"events":[],"ext":${"[".repeat(enclosing)}${innermost}${"]".repeat(enclosing)}}]}`;
+ if (accepted) expect(facts(text).decoded.total_records).toBe(0);
+ else expect(() => facts(text)).toThrow("nesting budget");
+ },
+);
+
it("rejects other qlog containers/versions and excessive nesting, accepts empty profiles and UTF-8 BOM", () => {
for (const extra of [{ qlog_format: "JSON-SEQ" }, { qlog_version: "0.4" }])
expect(() => facts(capture([], extra))).toThrow("Only the aioquic");