Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(managed): retain every source location
morluto33b20991c455
diff --git a/src/dotnet/ManagedStaticProvider.ts b/src/dotnet/ManagedStaticProvider.tsindex aa404200b..690a5327b 100644--- a/src/dotnet/ManagedStaticProvider.ts+++ b/src/dotnet/ManagedStaticProvider.ts@@ -295,7 +295,6 @@ const managedLocations = (: [{ kind: "file-offset" as const, offset: result.module.row_offset }]),...result.methods.filter((method) => method.body.file_offset !== null)- .slice(0, 8).map((method) => ({kind: "file-offset" as const,offset: method.body.file_offset ?? 0,@@ -305,7 +304,7 @@ const managedLocations = (...(result.module === null? [{ kind: "file-offset" as const, offset: 0 }]: [{ kind: "file-offset" as const, offset: result.module.row_offset }]),- ...result.pinvoke_imports.slice(0, 8).map((mapping) => ({+ ...result.pinvoke_imports.map((mapping) => ({kind: "file-offset" as const,offset: mapping.row_offset,})),diff --git a/tests/boundary/providers/managed/managedStaticProvider.test.ts b/tests/boundary/providers/managed/managedStaticProvider.test.tsindex f34d38a3d..83275a28a 100644--- a/tests/boundary/providers/managed/managedStaticProvider.test.ts+++ b/tests/boundary/providers/managed/managedStaticProvider.test.ts@@ -45,6 +45,16 @@ describe("managed static provider path boundary", () => {call_edges: [expect.objectContaining({ target_name: ".ctor" })],field_accesses: [expect.objectContaining({ field_name: "counter" })],});+ const memberResult = asManagedMemberResult(members.value);+ expect(members.value.locations).toEqual(+ expect.arrayContaining(+ memberResult.methods.flatMap((method) =>+ method.body.file_offset === null+ ? []+ : [{ kind: "file-offset", offset: method.body.file_offset }],+ ),+ ),+ );const boundaries = await client.execute("inspect_managed_native_boundaries",@@ -53,7 +63,6 @@ describe("managed static provider path boundary", () => {expect(boundaries.ok).toBe(true);if (!boundaries.ok) return;const boundaryResult = asManagedNativeBoundaryResult(boundaries.value);- expect(boundaryResult).not.toHaveProperty("schema_version");expect(boundaryResult).toMatchObject({artifact: { path, sha256: parsed.value.sha256, format: "pe" },module_refs: [],@@ -98,6 +107,37 @@ describe("managed static provider path boundary", () => {error: { _tag: "AnalysisCapabilityUnavailableError" },});});++ it("retains a source location for every managed P/Invoke mapping", async () => {+ const directory = await createTestTempDirectory("rea-managed-pinvoke-");+ const bytes = buildManagedPeFixture({+ pinvoke: { moduleName: "user32.dll", importName: "MessageBoxW" },+ });+ const path = join(directory, "fixture.exe");+ await writeFile(path, bytes);+ const parsed = await parseBinaryTarget(path);+ expect(parsed.ok).toBe(true);+ if (!parsed.ok) return;++ const client = new ManagedStaticProvider().createClient(parsed.value);+ const execution = await client.execute(+ "inspect_managed_native_boundaries",+ {},+ );+ expect(execution.ok).toBe(true);+ if (!execution.ok) return;+ const result = asManagedNativeBoundaryResult(execution.value);+ expect(result.pinvoke_imports.length).toBeGreaterThan(0);+ expect(execution.value.locations).toEqual(+ expect.arrayContaining(+ result.pinvoke_imports.map((mapping) => ({+ kind: "file-offset",+ offset: mapping.row_offset,+ })),+ ),+ );+ await client.close();+ });});const asManagedResult = (execution: AnalysisExecution) =>managedArtifactInspectionSchema.parse(execution.result);