Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(javascript): preserve namespace re-export relationships (#1833)

Yann Roberto37a9eb9d65a0
diff --git a/src/domain/javascript/javascriptSemanticProjection.ts b/src/domain/javascript/javascriptSemanticProjection.ts
index e5ab86bbf..4488f584f 100644
--- a/src/domain/javascript/javascriptSemanticProjection.ts
+++ b/src/domain/javascript/javascriptSemanticProjection.ts
@@ -304,14 +304,22 @@ const collectNamedExports = (
node,
);
for (const specifier of node.specifiers)
- if (t.isExportSpecifier(specifier))
+ if (
+ t.isExportSpecifier(specifier) ||
+ (t.isExportNamespaceSpecifier(specifier) && node.exportKind !== "type")
+ )
addModuleLink(
state,
{
kind: node.source == null ? "export" : "re-export",
specifier: node.source?.value ?? null,
- importedName: propertyName(specifier.local),
- localName: node.source == null ? propertyName(specifier.local) : null,
+ importedName: t.isExportNamespaceSpecifier(specifier)
+ ? "*"
+ : propertyName(specifier.local),
+ localName:
+ node.source == null && t.isExportSpecifier(specifier)
+ ? propertyName(specifier.local)
+ : null,
exportedName: propertyName(specifier.exported),
location: range(specifier),
},
diff --git a/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts b/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts
index 483c0ccfb..d7fac0698 100644
--- a/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts
+++ b/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts
@@ -1,4 +1,5 @@
import { execFile } from "node:child_process";
+import { createHash } from "node:crypto";
import { mkdir, writeFile } from "node:fs/promises";
import { createRequire } from "node:module";
import { join, resolve } from "node:path";
@@ -770,6 +771,173 @@ describe("export writes in function evaluation contexts", () => {
});
});
+it("retains namespace re-export bindings and provenance through stdio MCP and CLI", async () => {
+ const root = await createTestTempDirectory("rea-namespace-reexports-");
+ const declarations = [
+ { clause: "* as ns", name: "ns", imported: "*" },
+ {
+ clause: '* as "namespace value"',
+ name: "namespace value",
+ imported: "*",
+ },
+ { clause: "{ value as forwarded }", name: "forwarded", imported: "value" },
+ { clause: "*", name: "*", imported: "*" },
+ ];
+ const source = declarations
+ .map(({ clause }) => `export ${clause} from "./dependency.mjs";`)
+ .join("\n");
+ const path = join(root, "barrel.mjs");
+ await Promise.all([
+ writeFile(path, source),
+ writeFile(join(root, "dependency.mjs"), "export const value = 42;"),
+ ]);
+ // Node executes only this test-owned fixture to establish its actual exports.
+ for (const name of ["ns", "namespace value"])
+ expect(await runtimeExport(path, name)).toEqual({ value: 42 });
+ for (const name of ["forwarded", "value"])
+ expect(await runtimeExport(path, name)).toBe(42);
+
+ const documents = [
+ await analyzeThroughMcp(root),
+ await runCli(["analyze-javascript-application", root, "--json"]),
+ ];
+ const digest = createHash("sha256").update(source).digest("hex");
+ for (const document of documents) {
+ const { graph } = applicationEnvelope.parse(document).normalized_result;
+ const sourceModule = graph.nodes.find(({ observations }) =>
+ observations.some(
+ ({ properties }) =>
+ properties.semantic_role === "source-module" &&
+ properties.path === "barrel.mjs",
+ ),
+ );
+ expect(sourceModule?.observations[0]?.properties).toMatchObject({
+ export_relationships: 4,
+ export_names: ["*", "forwarded", "namespace value", "ns"],
+ omitted_export_names: 0,
+ });
+ for (const [index, { clause, name, imported }] of declarations.entries()) {
+ const exported = graph.nodes.find(({ observations }) =>
+ observations.some(
+ ({ properties }) =>
+ properties.semantic_role === "export-binding" &&
+ properties.module_path === "barrel.mjs" &&
+ properties.exported_name === name,
+ ),
+ );
+ const observation = exported?.observations[0];
+ expect(observation?.properties).toMatchObject({
+ relationship_kind: "re-export",
+ declared_specifier: "./dependency.mjs",
+ imported_name: imported,
+ local_name: null,
+ });
+ if (imported === "*" && name !== "*")
+ expect(observation?.evidence).toMatchObject({
+ artifact: { available: true, sha256: digest },
+ location: {
+ available: true,
+ value: {
+ kind: "source-range",
+ source: "barrel.mjs",
+ start: { line: index + 1, column: 7 },
+ end: { line: index + 1, column: 7 + clause.length },
+ },
+ },
+ });
+ expect(graph.edges).toContainEqual(
+ expect.objectContaining({
+ source_node_id: sourceModule?.node_id,
+ target_node_id: exported?.node_id,
+ relation: "exposes",
+ properties: expect.objectContaining({ exported_name: name }),
+ evidence: expect.objectContaining({
+ artifact: observation?.evidence.artifact,
+ location: observation?.evidence.location,
+ }),
+ }),
+ );
+ expect(graph.edges).toContainEqual(
+ expect.objectContaining({
+ source_node_id: exported?.node_id,
+ relation: "imports",
+ properties: expect.objectContaining({
+ module_link_kind: "re-export",
+ imported_name: imported,
+ exported_name: name,
+ resolved_path: "dependency.mjs",
+ resolution_status: "resolved",
+ }),
+ }),
+ );
+ }
+ expect(graph.coverage).toMatchObject({
+ status: "complete",
+ omitted_count: 0,
+ truncated: false,
+ });
+ }
+});
+
+it("excludes erased namespace type exports through stdio MCP and CLI", async () => {
+ const root = await createTestTempDirectory("rea-namespace-type-exports-");
+ const path = join(root, "barrel.mts");
+ await Promise.all([
+ writeFile(
+ path,
+ 'export type * as Types from "./types.mjs";\nexport * as Values from "./values.mjs";',
+ ),
+ writeFile(
+ join(root, "types.mjs"),
+ 'throw new Error("Type-only dependency must not execute");',
+ ),
+ writeFile(join(root, "values.mjs"), "export const value = 42;"),
+ ]);
+ // Node strips the type-only declaration without loading its throwing target.
+ expect(await runtimeExport(path, "Types")).toBeUndefined();
+ expect(await runtimeExport(path, "Values")).toEqual({ value: 42 });
+
+ const documents = [
+ await analyzeThroughMcp(root),
+ await runCli(["analyze-javascript-application", root, "--json"]),
+ ];
+ for (const document of documents) {
+ const { graph } = applicationEnvelope.parse(document).normalized_result;
+ const observations = graph.nodes.flatMap(
+ ({ observations }) => observations,
+ );
+ expect(
+ observations.find(
+ ({ properties }) =>
+ properties.semantic_role === "source-module" &&
+ properties.path === "barrel.mts",
+ )?.properties,
+ ).toMatchObject({
+ export_relationships: 1,
+ export_names: ["Values"],
+ omitted_export_names: 0,
+ });
+ expect(
+ observations.filter(
+ ({ properties }) =>
+ properties.semantic_role === "export-binding" &&
+ properties.module_path === "barrel.mts" &&
+ properties.exported_name === "Types",
+ ),
+ ).toEqual([]);
+ expect(
+ graph.edges.filter(
+ ({ properties }) => properties.exported_name === "Types",
+ ),
+ ).toEqual([]);
+ expect(graph.coverage).toMatchObject({
+ status: "complete",
+ omitted_count: 0,
+ truncated: false,
+ });
+ }
+});
+
const expectRuntimeExports = async (
fixture: Awaited<ReturnType<typeof analyzeVersions>>,
expected: (count: number) => unknown,