Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(cli): avoid duplicate primary cleanup diagnostics

morluto37fcea78cecb
diff --git a/src/application/DirectAnalysisCleanup.ts b/src/application/DirectAnalysisCleanup.ts
index 3f3c54425..3f073f7b5 100644
--- a/src/application/DirectAnalysisCleanup.ts
+++ b/src/application/DirectAnalysisCleanup.ts
@@ -55,7 +55,6 @@ export const directAnalysisCleanupFailure = (
"execution_failure" in primary.data.details
? (primary.data.details.execution_failure ?? primary.data.code)
: primary.data.code,
- primary_error: projection,
cleanup_error: cleanup,
},
};
diff --git a/tests/composition/directAnalysisCleanup.test.ts b/tests/composition/directAnalysisCleanup.test.ts
index 9e533bb89..22fd84942 100644
--- a/tests/composition/directAnalysisCleanup.test.ts
+++ b/tests/composition/directAnalysisCleanup.test.ts
@@ -6,6 +6,7 @@ import {
} from "../../src/application/DirectAnalysis.js";
import type { DirectAnalysisDependencies } from "../../src/application/DirectAnalysisDependencies.js";
import { parseConfig } from "../../src/config/parseConfig.js";
+import { analysisCliErrorEnvelopeSchema } from "../../src/contracts/errorSchemas.js";
import type { AnalysisError } from "../../src/domain/analysisErrorBase.js";
import { AnalysisTimeoutError } from "../../src/domain/analysisErrorCore.js";
import { projectAnalysisError } from "../../src/domain/analysisErrorProjection.js";
@@ -104,7 +105,8 @@ describe("one-shot analysis cleanup outcomes", () => {
"read_bytes",
{},
);
- expect(result).toMatchObject({
+ const callerError = analysisCliErrorEnvelopeSchema.parse(result);
+ expect(callerError).toMatchObject({
code: "cleanup_incomplete",
category: primary.category,
message: primary.message,
@@ -114,6 +116,10 @@ describe("one-shot analysis cleanup outcomes", () => {
cleanup_error: projectAnalysisError(cleanupError),
},
});
+ expect(callerError.details).not.toHaveProperty("primary_error");
+ expect(
+ JSON.stringify(callerError).match(/retained observation/g),
+ ).toHaveLength(1);
expect(isCliOperationFailure(result)).toBe(true);
});