Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(setup): configure an empty Hermes config.yaml (#1983)

Vinícius Andrade43f9c39dfbdf
diff --git a/src/application/ClientConfigurationDocument.ts b/src/application/ClientConfigurationDocument.ts
index bad6ee52f..4ad037f07 100644
--- a/src/application/ClientConfigurationDocument.ts
+++ b/src/application/ClientConfigurationDocument.ts
@@ -104,11 +104,11 @@ const parseDocument = (
// comments, trailing commas, a BOM, or an empty existing file must be
// rejected instead of registering into a document Pi cannot load.
if (format === "pi") return objectSchema.parse(JSON.parse(text));
- // Hermes stores MCP servers in `mcp_servers` inside a YAML document.
- if (format === "hermes") return objectSchema.parse(parseYaml(text));
// An empty file, which some clients create before any server is added,
// holds no settings to preserve.
if (isEmptyClientConfigurationText(text)) return {};
+ // Hermes stores MCP servers in `mcp_servers` inside a YAML document.
+ if (format === "hermes") return objectSchema.parse(parseYaml(text));
const errors: ParseError[] = [];
// Accept a UTF-8 BOM without shifting diagnostics or editing the original text.
const jsonText = text.startsWith("\uFEFF") ? ` ${text.slice(1)}` : text;
diff --git a/tests/boundary/filesystem/hermesClientConfiguration.test.ts b/tests/boundary/filesystem/hermesClientConfiguration.test.ts
index 20db28d9a..f6b3815ee 100644
--- a/tests/boundary/filesystem/hermesClientConfiguration.test.ts
+++ b/tests/boundary/filesystem/hermesClientConfiguration.test.ts
@@ -185,4 +185,28 @@ mcp_servers:
},
});
});
+
+ it.each(["", "\n"])(
+ "configures an empty config.yaml %j as a new document",
+ async (original) => {
+ const { home, client } = await hermesClient();
+ await writeFile(client.configPath, original);
+ expect(
+ (await configureClientConfiguration(client, {}, command)).status,
+ ).toBe("configured");
+ expect(parseYaml(await readFile(client.configPath, "utf8"))).toEqual({
+ mcp_servers: {
+ rea: { command: command[0], args: command.slice(1), enabled: true },
+ },
+ });
+ expect(
+ (
+ await readClientRegistrationStatuses(home, undefined, {
+ platform: process.platform,
+ environment: {},
+ })
+ ).find(({ client: name }) => name === "hermes"),
+ ).toMatchObject({ state: "aligned", command });
+ },
+ );
});