Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(evm): trim hex carrier whitespace in linear time (#5200)
Dragolone48e747004133
diff --git a/src/evm/EvmBytecodeCarrier.test.ts b/src/evm/EvmBytecodeCarrier.test.tsindex b8d485f99..5f0bd50ea 100644--- a/src/evm/EvmBytecodeCarrier.test.ts+++ b/src/evm/EvmBytecodeCarrier.test.ts@@ -22,6 +22,14 @@ it.each(["0x1", "60 00", "0xzz", "\uFEFF6000", "\u00a06000"])();},);+it("rejects a long interior separator run in linear time", () => {+ const text = `60${" ".repeat(200_000)}00`;+ const started = performance.now();+ expect(() => decodeEvmBytecodeCarrier(Buffer.from(text), "hex")).toThrow(+ EvmCarrierFailure,+ );+ expect(performance.now() - started).toBeLessThan(1_000);+});it("distinguishes raw bytes, empty code and malformed UTF-8", () => {const bytes = Uint8Array.from([0xff, 0x00]);const decoded = decodeEvmBytecodeCarrier(bytes, "raw");diff --git a/src/evm/EvmBytecodeCarrier.ts b/src/evm/EvmBytecodeCarrier.tsindex 368b674af..9af031ec0 100644--- a/src/evm/EvmBytecodeCarrier.ts+++ b/src/evm/EvmBytecodeCarrier.ts@@ -1,6 +1,10 @@/** Expected carrier encoding failure, independent of the analysis engine. */export class EvmCarrierFailure extends Error {}+/** Outer ASCII whitespace only; BOM and other Unicode spaces stay invalid. */+const asciiWhitespace = (code: number): boolean =>+ code === 0x20 || (code >= 0x09 && code <= 0x0d);+/** Decode only the explicitly selected representation; source carrier bytes are retained separately. */export const decodeEvmBytecodeCarrier = (bytes: Uint8Array,@@ -15,9 +19,13 @@ export const decodeEvmBytecodeCarrier = (} catch (cause: unknown) {throw new EvmCarrierFailure("Hex carrier must be valid UTF-8.", { cause });}- const code = text- .replace(/^[\x09-\x0d\x20]+|[\x09-\x0d\x20]+$/g, "")- .replace(/^0x/i, "");+ // Index scans keep trimming linear; a global start|end regex backtracks+ // through every interior whitespace run.+ let start = 0;+ let end = text.length;+ while (start < end && asciiWhitespace(text.charCodeAt(start))) start += 1;+ while (end > start && asciiWhitespace(text.charCodeAt(end - 1))) end -= 1;+ const code = text.slice(start, end).replace(/^0x/i, "");if (!/^(?:[a-fA-F0-9]{2})*$/.test(code))throw new EvmCarrierFailure("Hex carrier requires complete hexadecimal byte pairs, an optional 0x prefix and outer ASCII whitespace; interior separators are invalid.",