Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(comparison): require decoded signatures for structural method matches (#604)
Rudy Mizrahi Celekli4a98c3ea0354
diff --git a/src/domain/managedMemberComparison.test.ts b/src/domain/managedMemberComparison.test.tsindex 1b4d48283..ee3a3a6d4 100644--- a/src/domain/managedMemberComparison.test.ts+++ b/src/domain/managedMemberComparison.test.ts@@ -117,6 +117,43 @@ describe("managed member comparison", () => {});describe("managed member comparison uncertainty", () => {+ it("does not infer a structural method match from undecoded signature fields", () => {+ const left = inspect(+ buildManagedPeFixture({ methodSignature: Buffer.from([0xff]) }),+ "/tmp/unknown-left.dll",+ );+ const right = inspect(+ buildManagedPeFixture({ methodSignature: Buffer.from([0xfe]) }),+ "/tmp/unknown-right.dll",+ );+ expect(left.result.methods[0]?.signature.parse_status).not.toBe("decoded");+ expect(right.result.methods[0]?.signature.parse_status).not.toBe("decoded");+ const result = compareManagedMembers(+ {+ evidenceId: left.evidenceId,+ result: {+ ...left.result,+ coverage: { ...left.result.coverage, state: "partial" },+ },+ },+ {+ evidenceId: right.evidenceId,+ result: {+ ...right.result,+ coverage: { ...right.result.coverage, state: "partial" },+ },+ },+ );+ expect(result.matching.structural_method_shape).toBe(0);+ expect(result.methods).toHaveLength(2);+ expect(+ result.methods.every(+ ({ status, match }) =>+ status === "unknown" && match.status === "unmatched",+ ),+ ).toBe(true);+ });+it("keeps unmatched members unknown when opposite metadata is incomplete", () => {const left = inspect(buildManagedPeFixture(), "/tmp/left-partial.dll");const right = inspect(buildManagedPeFixture(), "/tmp/right-partial.dll");diff --git a/src/domain/managedMemberComparisonMatch.ts b/src/domain/managedMemberComparisonMatch.tsindex e53c68485..76f889276 100644--- a/src/domain/managedMemberComparisonMatch.ts+++ b/src/domain/managedMemberComparisonMatch.ts@@ -68,7 +68,7 @@ const keyMethod = (item: Method): Keyed<Method> => ({]): null,structuralKey:- item.body.status === "present"+ item.signature.parse_status === "decoded" && item.body.status === "present"? stableKey(["method-structural",item.signature.kind,diff --git a/tests/boundary/providers/managed/managedMemberComparison.test.ts b/tests/boundary/providers/managed/managedMemberComparison.test.tsindex e0e23fef0..9dd563d4e 100644--- a/tests/boundary/providers/managed/managedMemberComparison.test.ts+++ b/tests/boundary/providers/managed/managedMemberComparison.test.ts@@ -5,12 +5,63 @@ import { describe, expect, it } from "vitest";import { createTestTempDirectory } from "../../../fixtures/temporaryDirectory.js";-import { compareManagedMemberPaths } from "../../../../src/application/ManagedMemberComparisonService.js";+import {+ compareManagedMembersEvidenceValidated,+ compareManagedMemberPaths,+} from "../../../../src/application/ManagedMemberComparisonService.js";import { parseBinaryTarget } from "../../../../src/application/BinaryTargetResolver.js";import { managedMemberComparisonResultSchema } from "../../../../src/domain/managedMemberComparison.js";+import { createEvidence } from "../../../../src/domain/evidence.js";+import { jsonValueSchema } from "../../../../src/domain/jsonValue.js";+import { compareManagedMembersInputSchema } from "../../../../src/domain/managedMemberComparison.js";+import { inspectManagedMembersBytes } from "../../../../src/dotnet/ManagedMemberInspector.js";+import { managedPeFixtureTarget } from "../../../../src/dotnet/ManagedPe.fixture.js";import { buildManagedPeFixture } from "../../../../src/dotnet/ManagedPe.fixture.js";describe("managed member comparison path workflow", () => {+ it("preserves undecoded signatures as unknown through content-addressed partial Evidence", () => {+ const observe = (signature: number, path: string) => {+ const bytes = buildManagedPeFixture({+ methodSignature: Buffer.from([signature]),+ });+ const target = managedPeFixtureTarget(bytes, path);+ const inspection = inspectManagedMembersBytes(bytes, target);+ return createEvidence(+ target,+ { id: "partial-fixture", name: "Partial fixture", version: "1" },+ {+ operation: "inspect_managed_members",+ parameters: {},+ result: jsonValueSchema.parse({+ ...inspection,+ coverage: { ...inspection.coverage, state: "partial" },+ }),+ confidence: "observed",+ authority: "shipped-artifact",+ },+ );+ };+ const input = compareManagedMembersInputSchema.parse({+ left: observe(0xff, "/tmp/partial-left.dll"),+ right: observe(0xfe, "/tmp/partial-right.dll"),+ });+ const result = compareManagedMembersEvidenceValidated(input);+ expect(result.ok).toBe(true);+ if (!result.ok) return;+ const comparison = managedMemberComparisonResultSchema.parse(+ result.value.normalized_result,+ );+ expect(comparison.coverage.status).toBe("partial");+ expect(comparison.matching.structural_method_shape).toBe(0);+ expect(comparison.methods).toHaveLength(2);+ expect(+ comparison.methods.every(+ ({ status, match }) =>+ status === "unknown" && match.status === "unmatched",+ ),+ ).toBe(true);+ });+it("compares two local paths and returns derived Evidence", async () => {const directory = await createTestTempDirectory("rea-managed-compare-");const leftPath = join(directory, "left.dll");