Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(doctor): read each client's own activation key (#6331)

Christopher Pruijsen4b4babf1e796
diff --git a/src/application/ClientRegistrationStatus.ts b/src/application/ClientRegistrationStatus.ts
index d876ee934..c11f5f585 100644
--- a/src/application/ClientRegistrationStatus.ts
+++ b/src/application/ClientRegistrationStatus.ts
@@ -356,13 +356,21 @@ export const readClientRegistrationInspections = async (
);
};
+// Codex and Kimi Code load a server marked `disabled: true` and honor only
+// `enabled`; Devin loads one marked `enabled: false` and honors only `disabled`.
+const ignoresDisabledKey = new Set(["codex", "kimi"]);
+const ignoresEnabledKey = new Set(["devin"]);
+
const registrationActivation = (
registration: z.output<typeof registrationSchema>,
client: SetupClient,
parsed: ClientConfigurationDocument,
): "enabled" | "disabled" =>
- (client.format !== "grok" && registration.disabled === true) ||
+ (client.format !== "grok" &&
+ !ignoresDisabledKey.has(client.name) &&
+ registration.disabled === true) ||
(registration.enabled === false &&
+ !ignoresEnabledKey.has(client.name) &&
!clientServerForcedEnabled(parsed, PRODUCT_IDENTITY.mcpServerKey)) ||
((parsed.dialect === "zcode" || parsed.dialect === "zcode_fallback") &&
registration.enable === false) ||
diff --git a/tests/boundary/filesystem/clientRegistrationStatus.test.ts b/tests/boundary/filesystem/clientRegistrationStatus.test.ts
index 83c7fc185..348e4641e 100644
--- a/tests/boundary/filesystem/clientRegistrationStatus.test.ts
+++ b/tests/boundary/filesystem/clientRegistrationStatus.test.ts
@@ -1,5 +1,5 @@
import { chmod, mkdir, symlink, writeFile } from "node:fs/promises";
-import { join, relative, resolve } from "node:path";
+import { dirname, join, relative, resolve } from "node:path";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
@@ -312,6 +312,79 @@ describe("commandcode registration status", () => {
});
});
+describe("client activation keys", () => {
+ it.each([
+ ["disabled = true", "aligned"],
+ ["enabled = false", "stale"],
+ ] as const)(
+ "reads only the activation key Codex honors (%s)",
+ async (activation, state) => {
+ const home = await createTestTempDirectory("rea-codex-activation-");
+ await mkdir(join(home, ".codex"));
+ const entry = resolve("scripts/rea.mjs");
+ await writeFile(
+ join(home, ".codex/config.toml"),
+ `[mcp_servers.rea]\ncommand = ${JSON.stringify(process.execPath)}\nargs = [${JSON.stringify(entry)}, "mcp"]\nstartup_timeout_sec = 30\ntool_timeout_sec = 450\n${activation}\n`,
+ );
+ expect(
+ await readClientRegistrationStatuses(home, entry, { environment: {} }),
+ ).toEqual([expect.objectContaining({ client: "codex", state })]);
+ },
+ );
+
+ // Each JSON client loads rea under the key it ignores and skips it under the key it honors.
+ it.each([
+ ["kimi", { disabled: true }, "aligned"],
+ ["kimi", { enabled: false }, "stale"],
+ ["devin", { enabled: false }, "aligned"],
+ ["devin", { disabled: true }, "stale"],
+ ] as const)(
+ "reads only the activation key %s honors (%j)",
+ async (client, activation, state) => {
+ const home = await createTestTempDirectory("rea-json-activation-");
+ const entry = resolve("scripts/rea.mjs");
+ const [config, fields] =
+ client === "kimi"
+ ? [
+ join(home, ".kimi-code/mcp.json"),
+ {
+ env: { REA_MCP_INPUT_SCHEMA_PROFILE: "compact" },
+ startupTimeoutMs: 30_000,
+ toolTimeoutMs: 450_000,
+ },
+ ]
+ : [
+ join(
+ process.platform === "win32"
+ ? join(home, "AppData", "Roaming", "devin")
+ : join(home, ".config", "devin"),
+ "mcp_config.json",
+ ),
+ {},
+ ];
+ await mkdir(dirname(config), { recursive: true });
+ await writeFile(
+ config,
+ JSON.stringify({
+ mcpServers: {
+ rea: {
+ command: process.execPath,
+ args: [entry, "mcp"],
+ ...fields,
+ ...activation,
+ },
+ },
+ }),
+ );
+ expect(
+ await readClientRegistrationStatuses(home, entry, {
+ environment: { XDG_CONFIG_HOME: join(home, ".config") },
+ }),
+ ).toEqual([expect.objectContaining({ client, state })]);
+ },
+ );
+});
+
describe("Node-wrapped registration policy", () => {
it.each([1, 30])(
"accepts Codex caller-selected startup timeout %d independently of launcher",