Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
Fix permissions count issue for `pkg=null` in ADB analysis and add test cases (#4665)
Tapraj-Pathak509d4c8f56b0
diff --git a/src/adb/AdbProvider.test.ts b/src/adb/AdbProvider.test.tsindex 2566c86b8..fdb276546 100644--- a/src/adb/AdbProvider.test.ts+++ b/src/adb/AdbProvider.test.ts@@ -706,6 +706,28 @@ exit 1`,expect(result.total_bytes).toBe(34);});+it("handles `pkg=null` by returning null for requested_permissions_count", async () => {+ const { binary } = await writeAdbStub(+ shellStub({+ "dumpsys:package": `Packages:+ Package [com.example] (abcdef):+ userId=10234+ pkg=null+ versionCode=45 minSdk=24 targetSdk=34+ codePath=/data/app/com.example+`,+ }),+ );+ const result = await evidenceResult(providerOver(binary), {+ operation: "inspect_adb_package",+ input: { serial: "emulator-5554", package: "com.example" },+ });+ expect(result).toMatchObject({+ requested_permissions_count: null,+ coverage: "complete",+ });+});+it("projects package details from dumpsys package output", async () => {const { binary } = await writeAdbStub(shellStub({diff --git a/src/adb/AdbShellOutput.test.ts b/src/adb/AdbShellOutput.test.tsindex 765dbe4c7..977401217 100644--- a/src/adb/AdbShellOutput.test.ts+++ b/src/adb/AdbShellOutput.test.ts@@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest";import {parseAmStartOutput,+ parseDumpsysPackageOutput,parseWmDensityOutput,parseWindowFocusOutput,} from "./AdbShellOutput.js";@@ -166,6 +167,23 @@ describe("parseWindowFocusOutput declaration presence", () => {});});+describe("parseDumpsysPackageOutput", () => {+ it("reports unknown requested permissions when the package is null", () => {+ expect(+ parseDumpsysPackageOutput("Package [com.example] (abcdef):\n pkg=null\n")+ .requestedPermissions,+ ).toBeNull();+ });++ it("counts listed permissions when package data is available", () => {+ expect(+ parseDumpsysPackageOutput(+ "Package [com.example] (abcdef):\n requested permissions:\n android.permission.INTERNET\n",+ ).requestedPermissions,+ ).toBe(1);+ });+});+describe("parseWmDensityOutput", () => {it("reads labeled physical and override densities", () => {expect(diff --git a/src/adb/AdbShellOutput.ts b/src/adb/AdbShellOutput.tsindex e6e7bc6f4..68ecca0f7 100644--- a/src/adb/AdbShellOutput.ts+++ b/src/adb/AdbShellOutput.ts@@ -298,6 +298,7 @@ export const parseDumpsysPackageOutput = (};let inPermissions = false;let permissions = 0;+ let packageIsNull = false;for (const line of stdout.split(/\r?\n/u)) {if (line.trim().startsWith("requested permissions:")) {inPermissions = true;@@ -316,7 +317,8 @@ export const parseDumpsysPackageOutput = (if (match === null) continue;const key = match[1]!;const value = match[2]!.trim();- if (key === "versionName" && details.versionName === null)+ if (key === "pkg" && value === "null") packageIsNull = true;+ else if (key === "versionName" && details.versionName === null)details.versionName = value === "" ? null : value;else if (key === "versionCode" && details.versionCode === null) {const parsed = /^(-?\d+)/u.exec(value);@@ -336,7 +338,10 @@ export const parseDumpsysPackageOutput = (} else if (key === "pkgFlags" && details.pkgFlags === null)details.pkgFlags = value === "" ? null : value;}- return { ...details, requestedPermissions: permissions };+ return {+ ...details,+ requestedPermissions: packageIsNull ? null : permissions,+ };};/**