Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(evidence): report contradictory unknown input as invalid input (#6302)

Wade510838bd7038
diff --git a/src/application/investigation/EvidenceLedger.ts b/src/application/investigation/EvidenceLedger.ts
index c025295a9..f8c6535fd 100644
--- a/src/application/investigation/EvidenceLedger.ts
+++ b/src/application/investigation/EvidenceLedger.ts
@@ -1,4 +1,5 @@
import canonicalize from "canonicalize";
+import { z } from "zod";
import {
createEvidenceBundle,
@@ -23,6 +24,7 @@ import {
import { err, ok, type Result } from "../../domain/result.js";
import { compareUnicodeCodePoints } from "../../domain/unicodeCodePointOrder.js";
import type { UnknownPage, UnknownQuery } from "./InvestigationRecordPort.js";
+import { requestInputError } from "../workflowInputError.js";
type EvidenceLedgerFailure = EvidenceIntegrityError;
type RecordResult = Result<"added" | "duplicate", EvidenceLedgerFailure>;
@@ -213,7 +215,10 @@ export class EvidenceLedger {
recordUnknown(
input: RecordUnknownInput,
mutationEvidence: Evidence,
- ): Result<ResidualUnknown, EvidenceIntegrityError | UnknownRegistryError> {
+ ): Result<
+ ResidualUnknown,
+ EvidenceIntegrityError | UnknownRegistryError | AnalysisInputError
+ > {
let parsedMutation: Evidence;
try {
parsedMutation = immutableEvidence(mutationEvidence);
@@ -232,7 +237,7 @@ export class EvidenceLedger {
parsedMutation.subject?.digest.sha256 ?? null,
);
} catch (cause: unknown) {
- return err(new UnknownRegistryError("invalid-transition", { cause }));
+ return err(unknownInputError("record_unknown", cause, input));
}
if (this.#unknownHeads.has(unknown.unknown_id))
return err(new UnknownRegistryError("already-exists"));
@@ -295,7 +300,10 @@ export class EvidenceLedger {
updateUnknown(
input: UpdateUnknownInput,
mutationEvidence: Evidence,
- ): Result<ResidualUnknown, EvidenceIntegrityError | UnknownRegistryError> {
+ ): Result<
+ ResidualUnknown,
+ EvidenceIntegrityError | UnknownRegistryError | AnalysisInputError
+ > {
const current = this.#unknownHeads.get(input.unknown_id);
if (current === undefined)
return err(new UnknownRegistryError("not-found"));
@@ -309,7 +317,7 @@ export class EvidenceLedger {
mutationEvidence.evidence_id,
);
} catch (cause: unknown) {
- return err(new UnknownRegistryError("invalid-transition", { cause }));
+ return err(unknownInputError("update_unknown", cause, input));
}
return this.#appendUnknown(unknown, mutationEvidence);
}
@@ -477,6 +485,16 @@ export class EvidenceLedger {
}
}
+/** A caller's unknown that fails its schema is an input mistake, not a state change. */
+const unknownInputError = (
+ operation: "record_unknown" | "update_unknown",
+ cause: unknown,
+ input: RecordUnknownInput | UpdateUnknownInput,
+): UnknownRegistryError | AnalysisInputError =>
+ cause instanceof z.ZodError
+ ? requestInputError(operation, cause, input)
+ : new UnknownRegistryError("invalid-transition", { cause });
+
const unknownRevisionKey = (unknown: ResidualUnknown): string =>
`${unknown.unknown_id}:${String(unknown.revision)}`;
diff --git a/tests/boundary/mcp/serverUnknownsMcp.test.ts b/tests/boundary/mcp/serverUnknownsMcp.test.ts
index e39ce2aec..755fbd260 100644
--- a/tests/boundary/mcp/serverUnknownsMcp.test.ts
+++ b/tests/boundary/mcp/serverUnknownsMcp.test.ts
@@ -404,3 +404,98 @@ it("pages filtered unknown heads through the public MCP contract", async () => {
).toBe(true);
}
});
+
+it("reports contradictory unknown input as a correctable request", async () => {
+ const session = createTestBinarySession(providerWithCapabilities([]));
+ const server = createServer({ kind: "session", session });
+ const client = new Client({ name: "unknown-input", version: "1" });
+ const [clientTransport, serverTransport] =
+ InMemoryTransport.createLinkedPair();
+ resources.push(client, server);
+ await server.connect(serverTransport);
+ await client.connect(clientTransport);
+ const fields = {
+ severity: "medium",
+ required_authority: "analyst-inference",
+ required_confidence: "observed",
+ required_environment: null,
+ recommended_probes: [],
+ relationships: [],
+ supporting_evidence_ids: [],
+ contradicting_evidence_ids: [],
+ };
+ const created = structured(
+ await client.callTool({
+ name: "record_unknown",
+ arguments: {
+ ...fields,
+ question: "Does the result apply?",
+ domain: "input",
+ },
+ }),
+ ).result as {
+ unknown_id: string;
+ revision: number;
+ mutation_evidence_ids: string[];
+ };
+ const evidenceId = created.mutation_evidence_ids[0];
+
+ const overlap = parseMcpToolError(
+ await client.callTool({
+ name: "record_unknown",
+ arguments: {
+ ...fields,
+ question: "Can one observation both support and contradict?",
+ domain: "input",
+ supporting_evidence_ids: [evidenceId],
+ contradicting_evidence_ids: [evidenceId],
+ },
+ }),
+ ).error;
+ expect(overlap).toMatchObject({
+ code: "invalid_request",
+ category: "invalid_input",
+ retryable: false,
+ details: {
+ issues: [
+ expect.objectContaining({
+ message: "Evidence cannot simultaneously support and contradict",
+ }),
+ ],
+ },
+ });
+
+ const update = {
+ ...fields,
+ unknown_id: created.unknown_id,
+ expected_revision: created.revision,
+ };
+ const unresolved = parseMcpToolError(
+ await client.callTool({
+ name: "update_unknown",
+ arguments: { ...update, status: "resolved", resolution: null },
+ }),
+ ).error;
+ expect(unresolved).toMatchObject({
+ code: "invalid_request",
+ category: "invalid_input",
+ retryable: false,
+ details: {
+ issues: [expect.objectContaining({ path: ["resolution"] })],
+ },
+ });
+ expect(session.listUnknowns()).toMatchObject([{ revision: 1 }]);
+
+ const stale = parseMcpToolError(
+ await client.callTool({
+ name: "update_unknown",
+ arguments: {
+ ...update,
+ expected_revision: 2,
+ status: "open",
+ resolution: null,
+ },
+ }),
+ ).error;
+ expect(stale).toMatchObject({ code: "revision_conflict" });
+});