Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(frida): preserve attach targets and reconcile early detachment
morluto56128a8424d8
diff --git a/src/application/frida/FridaInstrumentationManager.test.ts b/src/application/frida/FridaInstrumentationManager.test.tsindex 11f9ca81e..86733cf59 100644--- a/src/application/frida/FridaInstrumentationManager.test.ts+++ b/src/application/frida/FridaInstrumentationManager.test.ts@@ -137,6 +137,7 @@ class FakeDevice implements Device {readonly process = { pid: 512, name: "fixture" } satisfies Process;readonly session = new FakeSession();resumed: number[] = [];+ attachedTargets: Array<number | string> = [];resumeFailureCount = 0;readonly spawned: string[] = [];@@ -161,7 +162,8 @@ class FakeDevice implements Device {this.resumed.push(pid);}- async attach(): Promise<Session> {+ async attach(target: number | string): Promise<Session> {+ this.attachedTargets.push(target);return this.session;}}@@ -207,6 +209,110 @@ const startLocalAttachedSession = async (// eslint-disable-next-line max-lines-per-function -- related manager lifecycle cases share the same focused fake provider.describe("FridaInstrumentationManager", () => {+ it("attaches by PID when Frida omits the target from process lookup", async () => {+ const bindings = new FakeDeviceManager();+ bindings.device.getProcessByPid = async () => {+ throw new Error("Process not found");+ };+ const manager = new FridaInstrumentationManager({+ deviceManager: bindings,+ });+ const started = await manager.startSession({+ mode: "attach",+ deviceId: "local",+ pid: 512,+ });+ expect(started.ok).toBe(true);+ if (!started.ok) return;+ expect(started.value.pid).toBe(512);+ expect(bindings.device.attachedTargets).toEqual([512]);+ expect(started.value.target).toBe("pid 512");+ expect(bindings.device.session.isDetached()).toBe(false);+ await manager.closeAll();+ expect(bindings.device.session.isDetached()).toBe(true);+ });++ it("keeps the caller PID when Frida resolves a different process", async () => {+ const bindings = new FakeDeviceManager();+ bindings.device.getProcessByPid = async () => ({+ ...bindings.device.process,+ pid: 513,+ });+ const manager = new FridaInstrumentationManager({+ deviceManager: bindings,+ });+ const started = await manager.startSession({+ mode: "attach",+ deviceId: "local",+ pid: 512,+ });+ expect(started.ok).toBe(true);+ if (!started.ok) return;+ expect(started.value.pid).toBe(512);+ expect(started.value.target).toBe("fixture (pid 512)");+ expect(bindings.device.attachedTargets).toEqual([512]);+ await manager.closeSession(started.value.sessionId);+ });++ it("records a session already detached during process metadata lookup", async () => {+ const bindings = new FakeDeviceManager();+ let lookupStarted!: () => void;+ const lookupEntered = new Promise<void>((resolve) => {+ lookupStarted = resolve;+ });+ let finishLookup!: () => void;+ const lookupGate = new Promise<void>((resolve) => {+ finishLookup = resolve;+ });+ bindings.device.getProcessByPid = async () => {+ lookupStarted();+ await lookupGate;+ return bindings.device.process;+ };+ const manager = new FridaInstrumentationManager({+ deviceManager: bindings,+ });+ const starting = manager.startSession({+ mode: "attach",+ deviceId: "local",+ pid: 512,+ });+ await lookupEntered;+ bindings.device.session.markDetached();+ finishLookup();++ const started = await starting;+ expect(started.ok).toBe(true);+ if (!started.ok) return;+ expect(started.value.pid).toBe(512);+ expect(bindings.device.attachedTargets).toEqual([512]);+ expect(started.value.state).toBe("detached");+ expect(manager.status(started.value.sessionId)?.state).toBe("detached");+ await manager.closeSession(started.value.sessionId);+ });++ it("still reports a real attach failure when process lookup is unavailable", async () => {+ const bindings = new FakeDeviceManager();+ bindings.device.getProcessByPid = async () => {+ throw new Error("Process not found");+ };+ bindings.device.attach = async () => {+ throw new Error("attach denied");+ };+ const manager = new FridaInstrumentationManager({+ deviceManager: bindings,+ });+ const started = await manager.startSession({+ mode: "attach",+ deviceId: "local",+ pid: 512,+ });+ expect(started.ok).toBe(false);+ if (started.ok) return;+ expect(JSON.stringify(started.error)).toContain("attach denied");+ await manager.closeAll();+ });+it("retains a failed startup's spawn and remote lease until cleanup succeeds", async () => {const bindings = new FakeDeviceManager();bindings.device.attach = async () => {diff --git a/src/frida/FridaInstrumentationManager.ts b/src/frida/FridaInstrumentationManager.tsindex ea77f6e81..7ef5d115f 100644--- a/src/frida/FridaInstrumentationManager.ts+++ b/src/frida/FridaInstrumentationManager.ts@@ -275,9 +275,14 @@ export class FridaInstrumentationManager implements FridaInstrumentationPort {let pid: number;let target: string;if (input.mode === "attach") {- const process = await device.getProcessByPid(input.pid);- pid = process.pid;- target = `${process.name} (pid ${process.pid})`;+ pid = input.pid;+ target = `pid ${pid}`;+ try {+ const process = await device.getProcessByPid(pid);+ target = `${process.name} (pid ${pid})`;+ } catch {+ // Frida can attach to processes absent from its enumeration snapshot.+ }} else {pid = await device.spawn(input.program,@@ -314,6 +319,10 @@ export class FridaInstrumentationManager implements FridaInstrumentationPort {session.detached.connect(() => {managed.state = "detached";});+ // A target can exit while metadata lookup/attach is pending, before+ // Frida installs this listener. Subscribe first, then reconcile the+ // current provider state so an already-emitted detach is not lost.+ if (session.isDetached()) managed.state = "detached";this.#sessions.set(id, managed);return ok(sessionObservation(managed));} catch (cause: unknown) {