Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
fix(process): refuse malformed timeouts for stoppable commands
Kaoru082259c91c88fe88
diff --git a/src/process/ExecFileOutput.test.ts b/src/process/ExecFileOutput.test.tsindex 00b925007..6a5eb5b2e 100644--- a/src/process/ExecFileOutput.test.ts+++ b/src/process/ExecFileOutput.test.ts@@ -123,6 +123,22 @@ describe.skipIf(process.platform === "win32")(expect(await readFile(stopped, "utf8")).toBe("SIGINT");});+ it.each([-1, Number.NaN, 1.5, Number.POSITIVE_INFINITY])(+ "refuses a malformed timeout (%s) before starting the command, as execFile does",+ async (timeout) => {+ // Starting this command would fail with ENOENT instead.+ await expect(+ execFileOutput("/nonexistent/rea-command", [], {+ timeout,+ stopSignal: "SIGINT",+ }),+ ).rejects.toMatchObject({ code: "ERR_OUT_OF_RANGE" });+ await expect(+ execFileOutput("/nonexistent/rea-command", [], { timeout }),+ ).rejects.toMatchObject({ code: "ERR_OUT_OF_RANGE" });+ },+ );+it("kills a timed-out process that ignores the stop signal", async () => {const script = ['for (const name of ["SIGINT", "SIGTERM"]) process.on(name, () => {});',diff --git a/src/process/ExecFileOutput.ts b/src/process/ExecFileOutput.tsindex 294014c19..94a73aa9f 100644--- a/src/process/ExecFileOutput.ts+++ b/src/process/ExecFileOutput.ts@@ -53,6 +53,19 @@ const timeoutError = (return error;};+/**+ * Node's execFile contract for `timeout`. A stoppable command keeps its own+ * deadline, so it must refuse the values execFile would refuse.+ */+const invalidTimeout = (timeout: number): RangeError | undefined => {+ if (Number.isSafeInteger(timeout) && timeout >= 0) return undefined;+ const error = new RangeError(+ `The value of "timeout" is out of range. It must be an unsigned integer. Received ${String(timeout)}`,+ );+ Reflect.set(error, "code", "ERR_OUT_OF_RANGE");+ return error;+};+/** Captured subprocess output read from an execFileOutput rejection. */export interface ExecFileOutputFailure {readonly stdout: string;@@ -93,6 +106,14 @@ export const execFileOutput = (): Promise<{ readonly stdout: string; readonly stderr: string }> =>new Promise((resolve, reject) => {const { stopSignal, signal, timeout, ...execOptions } = options;+ const invalid =+ stopSignal === undefined || timeout === undefined+ ? undefined+ : invalidTimeout(timeout);+ if (invalid !== undefined) {+ reject(invalid);+ return;+ }if (stopSignal !== undefined && signal?.aborted === true) {reject(abortError(signal));return;