Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(hopper): preserve streamed Unicode lease owner identities

morluto5a28a147f19f
diff --git a/src/hopper/HopperTargetLease.test.ts b/src/hopper/HopperTargetLease.test.ts
index 87d835502..1408edaa2 100644
--- a/src/hopper/HopperTargetLease.test.ts
+++ b/src/hopper/HopperTargetLease.test.ts
@@ -296,6 +296,38 @@ describe("Linux Hopper application leases", () => {
},
);
+ it("preserves a Unicode owner identity split across socket writes", async () => {
+ const directory = await temporaryDirectory();
+ const socketPath = await releasedApplicationSocket(directory);
+ const owner = { runId: "session-中文-🔬", processId: process.pid };
+ const response = Buffer.from(`${JSON.stringify(owner)}\n`);
+ const split = response.indexOf(Buffer.from("中")) + 1;
+ const sockets = new Set<Socket>();
+ const server = createServer((socket) => {
+ sockets.add(socket);
+ socket.on("close", () => sockets.delete(socket));
+ socket.on("error", () => undefined);
+ socket.write(response.subarray(0, split), () => {
+ // Let the client consume the incomplete UTF-8 sequence before the tail.
+ setImmediate(() =>
+ setImmediate(() => socket.end(response.subarray(split))),
+ );
+ });
+ });
+ server.listen(socketPath);
+ await once(server, "listening");
+ try {
+ expect(
+ await acquireLinuxHopperApplicationLease({ directory, runId: "next" }),
+ ).toEqual({ acquired: false, owner });
+ expect((await lstat(socketPath)).isSocket()).toBe(true);
+ } finally {
+ for (const socket of sockets) socket.destroy();
+ server.close();
+ await once(server, "close");
+ }
+ });
+
it("recovers a socket left by a process that exited without releasing it", async () => {
const directory = await temporaryDirectory();
const socketPath = await releasedApplicationSocket(directory);
diff --git a/src/process/HopperLease.ts b/src/process/HopperLease.ts
index 51f1b6640..6e6097401 100644
--- a/src/process/HopperLease.ts
+++ b/src/process/HopperLease.ts
@@ -273,6 +273,7 @@ const readOwner = (
): Promise<HopperTargetLeaseOwner | "missing" | "stale"> =>
new Promise((resolveOwner, rejectOwner) => {
const socket = createConnection(socketPath);
+ socket.setEncoding("utf8");
let response = "";
let settled = false;
const fail = (reason: string, cause?: unknown): void => {
@@ -297,8 +298,8 @@ const readOwner = (
socket.destroy();
resolveOwner(owner);
};
- socket.on("data", (chunk: Buffer) => {
- response += chunk.toString("utf8");
+ socket.on("data", (chunk: string) => {
+ response += chunk;
const newline = response.indexOf("\n");
if (newline < 0) return;
const parsed = safeParseJson(response.slice(0, newline));