Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(artifacts): keep the post-snapshot detach check out of provenance

Kaoru082262634e4c0177
diff --git a/src/artifacts/NativeDmgArtifactReader.ts b/src/artifacts/NativeDmgArtifactReader.ts
index b6dc543c0..b5c6ee73a 100644
--- a/src/artifacts/NativeDmgArtifactReader.ts
+++ b/src/artifacts/NativeDmgArtifactReader.ts
@@ -141,14 +141,17 @@ export class NativeDmgArtifactReader implements ArtifactReader {
);
}
- /** Report whether hdiutil still lists a device; unknown state counts as attached. */
+ /**
+ * Report whether hdiutil still lists a device; unknown state counts as
+ * attached. Like detach, this cleanup query runs after the inventory
+ * snapshot has captured provenance, so it is not recorded there.
+ */
async #isAttached(device: string): Promise<boolean> {
try {
const info = await runChecked(this.host, ["info", "-plist"], undefined, {
timeoutMs: DETACH_TIMEOUT_MS,
});
const parsed = infoOutputSchema.parse(parse(info.stdout));
- this.#provenance.push(command(["info", "-plist"], ["read"]));
return parsed.images.some((image) =>
image["system-entities"].some(
(entity) => entity["dev-entry"] === device,
diff --git a/tests/boundary/providers/native/nativeDmgArtifactReader.test.ts b/tests/boundary/providers/native/nativeDmgArtifactReader.test.ts
index e5fcd9f70..b04633b96 100644
--- a/tests/boundary/providers/native/nativeDmgArtifactReader.test.ts
+++ b/tests/boundary/providers/native/nativeDmgArtifactReader.test.ts
@@ -201,7 +201,6 @@ describe("APFS disk image detach", () => {
"verify",
"attach",
"detach",
- "info",
]);
});