Reverse engineer anything with agents, from app behavior down to native binaries.
TypeScript agent-skillsai-agentsbinary-analysisclaude-codeclicodexcordisdecompilerdeveloper-toolsdshdsh-pluginghidrahopperllmmcpmodel-context-protocolreareverse-engineeringstatic-analysistouhou
perf(native): record macOS command provenance once in its Evidence (#1430)
Kaoru08226375ccaf04b4
diff --git a/src/native/NativeMacOSProvider.ts b/src/native/NativeMacOSProvider.tsindex 12c94814f..d63db2506 100644--- a/src/native/NativeMacOSProvider.ts+++ b/src/native/NativeMacOSProvider.ts@@ -233,7 +233,6 @@ class NativeMacOSClient implements AnalysisClient {return observation.ok? ok(createAnalysisExecution(observation.value.result, IDENTITY, {- rawResult: { provenance: observation.value.provenance },limitations: observation.value.limitations,locations: observation.value.locations,}),@@ -317,7 +316,6 @@ class NativeMacOSClient implements AnalysisClient {});return ok({result: jsonValueSchema.parse(result),- provenance,limitations: [],locations: architectureLocations(result.architectures.items),});@@ -351,7 +349,6 @@ class NativeMacOSClient implements AnalysisClient {});return ok({result: jsonValueSchema.parse(result),- provenance,limitations: [],locations: [],});@@ -448,7 +445,6 @@ class NativeMacOSClient implements AnalysisClient {});return ok({result: jsonValueSchema.parse(result),- provenance,limitations: result.limitations,locations: [],});@@ -611,7 +607,6 @@ class NativeMacOSClient implements AnalysisClient {});return ok({result: jsonValueSchema.parse(result),- provenance,limitations: parsed.value.limitations,locations: [{ kind: "artifact-path", path: plist.value }],});@@ -659,7 +654,6 @@ class NativeMacOSClient implements AnalysisClient {interface NativeObservation {readonly result: JsonValue;- readonly provenance: readonly NativeCommandInvocation[];readonly limitations: readonly string[];readonly locations: readonly EvidenceLocation[];}diff --git a/src/native/NativeMachoInspection.ts b/src/native/NativeMachoInspection.tsindex 417b43fef..2ef2c95ae 100644--- a/src/native/NativeMachoInspection.ts+++ b/src/native/NativeMachoInspection.ts@@ -15,7 +15,6 @@ import { parseOtoolLoadCommands } from "./parsers/otool.js";interface NativeMachoObservation {readonly result: JsonValue;- readonly provenance: readonly NativeCommandInvocation[];readonly limitations: readonly string[];readonly locations: readonly EvidenceLocation[];}@@ -116,7 +115,6 @@ export const inspectNativeMacho = async (: normalized;return ok({result: jsonValueSchema.parse(result),- provenance: result.provenance,limitations: result.limitations,locations: fileOffsetLocations(result, segmentOffset),});diff --git a/tests/boundary/providers/native/nativeProvider.test.ts b/tests/boundary/providers/native/nativeProvider.test.tsindex d5be920ba..70a3b06ad 100644--- a/tests/boundary/providers/native/nativeProvider.test.ts+++ b/tests/boundary/providers/native/nativeProvider.test.ts@@ -552,6 +552,43 @@ describe("native macOS provider inspection", () => {});});+describe("native macOS provider raw results", () => {+ it("records command provenance once, in the normalized result", async () => {+ directory = await createTestTempDirectory("rea-native-");+ const app = join(directory, "Fixture.app");+ const executable = join(app, "Contents/MacOS/Fixture");+ await mkdir(join(app, "Contents/MacOS"), { recursive: true });+ await writeFile(executable, "fixture");+ await writeFile(join(app, "Contents/Info.plist"), "fixture");+ const client = new NativeMacOSProvider(+ {},+ new FixtureRunner(),+ "darwin",+ ).createClient(await nativeMachoTargetForFile(executable, app));+ const requests: readonly (readonly [+ Parameters<typeof client.execute>[0],+ Parameters<typeof client.execute>[1],+ ])[] = [+ ["inspect_macho", {}],+ ["list_architectures", {}],+ ["inspect_signature", {}],+ ["inspect_plist", {}],+ ["demangle_swift", { symbols: ["$s4Test3fooyyF", "plain_symbol"] }],+ ];++ for (const [operation, parameters] of requests) {+ const execution = await client.execute(operation, parameters);+ if (!execution.ok) throw execution.error;+ expect(execution.value.rawResult, operation).toBeNull();+ expect(execution.value.result, operation).toMatchObject({+ provenance: expect.arrayContaining([+ expect.objectContaining({ tool: expect.any(String) }),+ ]),+ });+ }+ });+});+describe("native plist defaults for iOS-style bundles", () => {it("defaults to the Info.plist the bundle program was resolved from", async () => {directory = await createTestTempDirectory("rea-native-flat-");