Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

perf(javascript)!: stop repeating the semantic identifier strategy per fact (#1474)

Kaoru08227296f2b5bfff
diff --git a/src/domain/javascript/javascriptSemanticGraph.ts b/src/domain/javascript/javascriptSemanticGraph.ts
index 69b3bb967..9ab2dd485 100644
--- a/src/domain/javascript/javascriptSemanticGraph.ts
+++ b/src/domain/javascript/javascriptSemanticGraph.ts
@@ -127,10 +127,6 @@ export const createJavaScriptSemanticGraphNode = (
...parsed,
application_node_ids: uniqueSorted(parsed.application_node_ids),
evidence: evidenceContexts.intern(parsed.evidence),
- identifier_strategy: {
- strategy: "semantic-content-sha256" as const,
- stability: "artifact-version" as const,
- },
};
return javaScriptSemanticNodeSchema.parse({
...semantic,
@@ -147,10 +143,6 @@ export const createJavaScriptSemanticGraphRelation = (
const semantic = {
...parsed,
evidence: evidenceContexts.intern(parsed.evidence),
- identifier_strategy: {
- strategy: "semantic-content-sha256" as const,
- stability: "relationship-exact" as const,
- },
};
return javaScriptSemanticRelationSchema.parse({
...semantic,
diff --git a/src/domain/javascript/javascriptSemanticGraphSchemas.ts b/src/domain/javascript/javascriptSemanticGraphSchemas.ts
index fb03f1a4d..4048ae698 100644
--- a/src/domain/javascript/javascriptSemanticGraphSchemas.ts
+++ b/src/domain/javascript/javascriptSemanticGraphSchemas.ts
@@ -233,11 +233,9 @@ export const javaScriptSemanticNodeInputSchema = z.strictObject({
export const javaScriptSemanticNodeSchema =
javaScriptSemanticNodeInputSchema.extend({
evidence: javaScriptSemanticEvidenceReferenceSchema,
- node_id: semanticNodeIdSchema,
- identifier_strategy: z.strictObject({
- strategy: z.literal("semantic-content-sha256"),
- stability: z.literal("artifact-version"),
- }),
+ node_id: semanticNodeIdSchema.describe(
+ "SHA-256 of the node kind and identity; stable for one artifact version.",
+ ),
});
/** One directed semantic relationship before its ID is derived. */
@@ -254,11 +252,9 @@ export const javaScriptSemanticRelationInputSchema = z.strictObject({
export const javaScriptSemanticRelationSchema =
javaScriptSemanticRelationInputSchema.extend({
evidence: javaScriptSemanticEvidenceReferenceSchema,
- relation_id: semanticRelationIdSchema,
- identifier_strategy: z.strictObject({
- strategy: z.literal("semantic-content-sha256"),
- stability: z.literal("relationship-exact"),
- }),
+ relation_id: semanticRelationIdSchema.describe(
+ "SHA-256 of the exact relation content, including its evidence reference.",
+ ),
});
/** Reasons semantic analysis can leave an explicit frontier. */