Skip to content

armgit / rea

Public Imported from GitHub
0

Reverse engineer anything with agents, from app behavior down to native binaries.

fix(javascript): ignore bare CommonJS exports rebinding

morluto8b2f8514c50e
diff --git a/src/domain/javascript/javascriptSemanticProjection.ts b/src/domain/javascript/javascriptSemanticProjection.ts
index a5577bf97..f52d4495f 100644
--- a/src/domain/javascript/javascriptSemanticProjection.ts
+++ b/src/domain/javascript/javascriptSemanticProjection.ts
@@ -641,7 +641,7 @@ const commonJsExportName = (
node: t.Node,
state: JavaScriptSemanticAnalysisState,
): string | undefined => {
- if (isUnshadowedGlobal(node, state, "exports")) return "default";
+ // Rebinding the CommonJS `exports` alias does not replace `module.exports`.
if (!t.isMemberExpression(node) && !t.isOptionalMemberExpression(node))
return undefined;
const key = semanticStaticPropertyKey(node.property, node.computed);
diff --git a/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts b/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts
index f32f9e5e2..bb2b10c34 100644
--- a/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts
+++ b/tests/acceptance/applications/exportedFunctionBindingsCli.test.ts
@@ -1,5 +1,6 @@
import { execFile } from "node:child_process";
import { mkdir, writeFile } from "node:fs/promises";
+import { createRequire } from "node:module";
import { join, resolve } from "node:path";
import { promisify } from "node:util";
@@ -13,6 +14,7 @@ import { javaScriptExportShapeComparisonResultSchema } from "../../../src/domain
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
const execute = promisify(execFile);
+const requireFixture = createRequire(import.meta.url);
const comparisonEnvelope = z.object({
normalized_result: javaScriptExportShapeComparisonResultSchema,
});
@@ -111,6 +113,28 @@ describe("exported function binding resolution through the CLI", () => {
expectUncertainComparison(cli);
expect(await compareThroughMcp(fixture.input)).toEqual(cli);
});
+
+ it("does not treat rebinding the CommonJS exports alias as a default export", async () => {
+ const fixture = await analyzeVersions(
+ (count) =>
+ `exports = function parse() { return { kind: "result", count: ${String(count)} }; };`,
+ "default",
+ "app.cjs",
+ );
+
+ // This is a test-owned fixture, so Node's actual CommonJS loader is the
+ // oracle for what the application exports.
+ expect(requireFixture(fixture.leftPath)).toEqual({});
+ expect(requireFixture(fixture.rightPath)).toEqual({});
+
+ const cli = await compareThroughCli(fixture);
+ expect(cli).toMatchObject({
+ left: { status: "missing" },
+ right: { status: "missing" },
+ summary: { added: 0, removed: 0, changed: 0 },
+ });
+ expect(await compareThroughMcp(fixture.input)).toEqual(cli);
+ });
});
describe("stable exported function bindings through the CLI", () => {
@@ -588,6 +612,7 @@ const compareThroughMcp = async (input: Record<string, unknown>) => {
arguments: input,
});
expect(response.isError).not.toBe(true);
+ await client.ping();
return comparisonEnvelope.parse(response.structuredContent)
.normalized_result;
} finally {